[Spice-commits] Changes to 'bugfix.1'
Gerd Hoffmann
kraxel at kemper.freedesktop.org
Fri Oct 15 02:28:19 PDT 2010
New branch 'bugfix.1' available with the following commits:
commit 487c8ddd7454d7357b886d0a81fab2bdd9d95f06
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Thu Oct 14 16:55:01 2010 +0200
spice display: replace private lock with qemu mutex.
qemu_spice_create_update() must aquire the global qemu mutex to
make sure DisplayState doesn't change while we are accessing it.
Once this is in place the private lock is pretty pointless as
everything it protects is covered by the global qemu mutex now.
Drop it.
commit f3d7d80a52e71a35a5f603dcead181f9f9e9709c
Author: Hans de Goede <hdegoede at redhat.com>
Date: Fri Oct 15 09:47:53 2010 +0200
spice-core: fix watching for write events
commit f871d6893a7bf8c14db162f6e75a5f8157e4c2bb
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 19:14:29 2010 +0000
trace: print a warning if user tries to enable an unknown trace event
There was no warning if a bad trace event name was given to
'trace-event' command, thus the user could think that the command
was successful even if this was not the case.
Print a warning if the user tries to enable a trace event which is not
known.
Acked-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 2abf314dddcfc1792a981ef6ecda343384b2a1a2
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:38:08 2010 +0000
mips: avoid write only variables
Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
/src/qemu/target-mips/translate.c: In function 'gen_ld':
/src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set but not used [-Werror=unused-but-set-variable]
Fix by adding a dummy cast so that the variable is not unused.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 577f25a5eb2b1b3338fe03d31c6e87da5ce29e7c
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:38:08 2010 +0000
ppc: avoid write only variables
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-ppc/op_helper.c: In function 'helper_icbi':
/src/qemu/target-ppc/op_helper.c:351:14: error: variable 'tmp' set but not used [-Werror=unused-but-set-variable]
/src/qemu/target-ppc/op_helper.c: In function 'do_6xx_tlb':
/src/qemu/target-ppc/op_helper.c:3805:28: error: variable 'EPN' set but not used [-Werror=unused-but-set-variable]
/src/qemu/target-ppc/op_helper.c: In function 'do_74xx_tlb':
/src/qemu/target-ppc/op_helper.c:3838:28: error: variable 'EPN' set but not used [-Werror=unused-but-set-variable]
Fix by adding a dummy cast so that the variable is not unused. Delete tmp.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 4581cbcdc3c70fa94c729da7e25c6a152936cfd3
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:38:08 2010 +0000
i386: avoid a write only variable
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-i386/op_helper.c: In function 'switch_tss':
/src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap' set but not used [-Werror=unused-but-set-variable]
Fix by adding a dummy cast so that the variable is not unused. Add also
pointer to docs.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 2ded6ad761613e01d4690f290771961ba690d17e
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:38:08 2010 +0000
vnc: avoid write only variables
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/ui/vnc.c: In function 'vnc_client_cache_auth':
/src/qemu/ui/vnc.c:217:12: error: variable 'qdict' set but not used [-Werror=unused-but-set-variable]
/src/qemu/ui/vnc.c: In function 'vnc_display_open':
/src/qemu/ui/vnc.c:2526:9: error: variable 'acl' set but not used [-Werror=unused-but-set-variable]
Fix by making the variable declarations and their uses also conditional
to debug definition.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 03e654c083e4a26a57423dbaf251f649d3250c92
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:38:08 2010 +0000
cris: avoid a write only variable
Compiling with GCC 4.6.0 20100925 produced a warning:
In file included from /src/qemu/target-cris/translate.c:3154:0:
/src/qemu/target-cris/translate_v10.c: In function 'dec10_prep_move_m':
/src/qemu/target-cris/translate_v10.c:111:22: error: variable 'rd' set but not used [-Werror=unused-but-set-variable]
Fix by deleting rd, adjust the only user.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 49a2942d9be0b08aed3e63901561745378ea5e4f
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:41:29 2010 +0000
Delete write only variables
Compiling with GCC 4.6.0 20100925 produced warnings like:
/src/qemu/net/tap-win32.c: In function 'tap_win32_open':
/src/qemu/net/tap-win32.c:582:12: error: variable 'hThread' set but not used [-Werror=unused-but-set-variable]
Fix by removing the unused variables.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit ae0bfb79aa0ac411a433433af4d74f1f08255608
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:38:07 2010 +0000
ppc: remove video.x
Only Mac-on-Linux stuff used video.x, OpenBIOS does not need it.
Remove video.x MoL hacks.
Signed-off-by: Alexander Graf <agraf at suse.de>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit f3f5b867259dcb205b1f4fdd93165dec71e89201
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:38:07 2010 +0000
lsi53c895a: avoid a write only variable
Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
/src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not used [-Werror=unused-but-set-variable]
Fix by adding a dummy cast so that the variable is not unused for
non-debug case.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit ef4760626e88bc3e7a1b46c7370378cbd12d379f
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:38:07 2010 +0000
eepro100: initialize a variable in all cases
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/hw/eepro100.c: In function 'eepro100_read4':
/src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used uninitialized in this function [-Werror=uninitialized]
/src/qemu/hw/eepro100.c: In function 'eepro100_read2':
/src/qemu/hw/eepro100.c:1328:14: error: 'val' may be used uninitialized in this function [-Werror=uninitialized]
/src/qemu/hw/eepro100.c: In function 'eepro100_read1':
/src/qemu/hw/eepro100.c:1285:13: error: 'val' may be used uninitialized in this function [-Werror=uninitialized]
Fix by initializing 'val' at start.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 8c78881f481401ec3cfbdce2267101cf300cd4b1
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:38:07 2010 +0000
cirrus: avoid write only variables
Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
In file included from /src/qemu/hw/cirrus_vga_rop.h:174:0,
from /src/qemu/hw/cirrus_vga.c:284:
/src/qemu/hw/cirrus_vga_rop2.h: In function 'cirrus_patternfill_0_8':
/src/qemu/hw/cirrus_vga_rop2.h:48:18: error: variable 'col' set but not used [-Werror=unused-but-set-variable]
/src/qemu/hw/cirrus_vga_rop2.h: In function 'cirrus_colorexpand_transp_0_8':
/src/qemu/hw/cirrus_vga_rop2.h:104:18: error: variable 'col' set but not used [-Werror=unused-but-set-variable]
Fix the warnings by introducing an inline function, which avoids
exposing write-only variables.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 83e3f76c2565a06877dc415ac9f5cf6f1c75614c
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Wed Oct 13 18:38:07 2010 +0000
block: avoid a write only variable
Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/block/qcow2-refcount.c: In function 'update_refcount':
/src/qemu/block/qcow2-refcount.c:552:13: error: variable 'dummy' set but not used [-Werror=unused-but-set-variable]
Fix by adding a dummy cast so that the result is not unused.
Acked-by: Kevin Wolf <kwolf at redhat.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit a2d3f69530b5b16947a8af0f184b3988eb64cadd
Merge: d7489b72cae6ba5aaf7f3ac868b7fd18c0a59809 c885212109b0ad79888ced410c2ff0d0e883cb15
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Mon Oct 11 15:37:11 2010 -0500
Merge remote branch 'mst/for_anthony' into staging
commit d7489b72cae6ba5aaf7f3ac868b7fd18c0a59809
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sat Oct 9 08:24:17 2010 +0000
trace: remove timestamp files when cleaning up
'make clean' did not remove trace.[ch]-timestamp files,
only trace.[ch]. But 'make' did not know how to make trace.[ch]
files if the timestamp files were present.
Fix by removing the timestamp files along with trace.[ch].
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit ba80782912293c9b9828d0cf406f90b76bf4f61b
Author: Stefan Weil <weil at mail.berlios.de>
Date: Thu Oct 7 21:15:58 2010 +0200
configure: Send error message from spice check to /dev/null
pkg-config is not always available (e.g. on win32 hosts),
but we don't want to see the 'command not found' error message.
Redirect stdout and stderr to /dev/null.
v2:
* Removed changes which should not have been here.
Cc: Gerd Hoffmann <kraxel at redhat.com>
Signed-off-by: Stefan Weil <weil at mail.berlios.de>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 6650b7100b58d9f81ae5117d03e89dc97f142897
Author: Stefan Weil <weil at mail.berlios.de>
Date: Thu Oct 7 18:55:48 2010 +0200
win32: Set unbuffered stdout
Win32 does not support line-buffering, but it allows
unbuffered output.
Unbuffered output is a good approximation. For typical output
statements which usually end with '\n', it's even identical.
Buffered output is unusable for program traces because of
its large delay.
Cc: Blue Swirl <blauwirbel at gmail.com>
Signed-off-by: Stefan Weil <weil at mail.berlios.de>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit ea95f15602234c1ff9c9be176ebe8bba55ee4dab
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Thu Oct 7 12:07:15 2010 +0100
.gitignore: Ignore *-timestamp
Timestamp files were recently added to reduce make churn on source files
that use tracing. The timestamp files should never be committed and
should not be visible in git status.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit b755a4289ea6ab881c63b52c4f7f849edd93a232
Author: Vincent Minet <vincent at vincent-minet.net>
Date: Tue Oct 5 02:23:12 2010 +0200
acpi: Fix an infinite loop in acpi_table_add
Commit d729bb9a7700e364b1c5f9893d61f07a9e002bce has a typo, causing an
infinite loop in acpi_table_add.
Signed-off-by: Vincent Minet <vincent at vincent-minet.net>
Acked-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 10d554c65a1dbb4dc8cf87f1119883aa1b27cef4
Author: Stefan Weil <weil at mail.berlios.de>
Date: Wed Oct 6 21:09:17 2010 +0200
configure: Remove unneeded defines from checks
_GNU_SOURCE is already defined in QEMU_CFLAGS which
is passed to gcc in shell function compile_prog.
Removing the definition from several checks avoids compiler warnings
(which are now written to config.log).
Signed-off-by: Stefan Weil <weil at mail.berlios.de>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 832ce9c286a907be8e6aab43fb0ae0037268476a
Author: Scott Wood <scottwood at freescale.com>
Date: Tue Oct 5 14:28:17 2010 -0500
configure: include stddef.h for NULL
This fixes an observed failure to detect madvise() on Linux.
To avoid similar issues, all other tests that use NULL but don't already
have stddef.h (or another header that is defined to provide NULL,
such as stdio.h, unistd.h, or time.h) are also fixed.
Signed-off-by: Scott Wood <scottwood at freescale.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit bbf0a440813816410eeee465b71b37100b2ec9ca
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Tue Oct 5 14:28:53 2010 +0100
trace: Trace bdrv_aio_{readv,writev}
Observing block layer aio readv/writev operations is useful for
debugging image formats or understanding guest disk I/O patterns.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit ea9c16989b0c814d5dd2a09a576018a6aa320a27
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Tue Oct 5 14:28:52 2010 +0100
trace: Use TP_PROTO() and TP_ARGS() for LTTng UST
The LTTng UserSpace Tracer formerly used TPPROTO() and TPARGS() instead
of TP_PROTO() and TP_ARGS() like the kernel uses. This has been changed
so QEMU needs to follow.
I am not aware of a graceful way of making the transition but since no
one complained that the UST build is broken, it should be fine to just
switch over without compatibility for old UST headers. The newer UST
headers are shipping in distro packages so it is realistic to make this
change now.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 5eb5527b1eaec0955a91f8532424bb45611b7b0c
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Tue Oct 5 14:28:51 2010 +0100
trace: Don't strip lines containing '#' arbitrarily
Although comment lines must be skipped, the '#' character can occur in
valid format strings. Be more careful when checking for comments.
Leave comments at the end of the line where they will not interfere with
other processing.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 9a85d3944715c709d740edb987b84bd657b9d7ef
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Tue Oct 5 14:28:50 2010 +0100
trace: Use portable format strings
It is not portable to use "%ld" for int64_t because int64_t may have
type long on 64-bit platforms and long long on 32-bit platforms. Use
the standard library PRId64 macros to keep format strings portable.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 3e18c6bf7740e4a75503b803ec7d5dc29a531e4f
Author: Edgar E. Iglesias <edgar.iglesias at gmail.com>
Date: Thu Oct 7 21:20:52 2010 +0200
cris: Consider the TLB valid bit on writes to the TLB
When updating the guest TLB we only need to flush previous
mappings from the entry written if the entry was valid.
Also fixes a compiler warning reported by Blue Swirl.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias at gmail.com>
commit c885212109b0ad79888ced410c2ff0d0e883cb15
Author: Michael S. Tsirkin <mst at redhat.com>
Date: Wed Oct 6 15:20:28 2010 +0200
vhost: error code
fix up errors returned to include errno, not just -1
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
commit 54dd932128ae08d6a5a6668551508e30520b0f86
Author: Michael S. Tsirkin <mst at redhat.com>
Date: Wed Oct 6 15:20:17 2010 +0200
virtio: change set guest notifier to per-device
When using irqfd with vhost-net to inject interrupts,
a single evenfd might inject multiple interrupts.
Implementing this is much easier with a single
per-device callback to set guest notifiers.
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
commit 010ec6293409f10b88631c36145944b9c3277ce1
Author: Stefan Weil <weil at mail.berlios.de>
Date: Wed Sep 29 21:59:55 2010 +0200
eepro100: Add support for multiple individual addresses (multiple IA)
I reviewed the latest sources of Linux, FreeBSD and NetBSD.
They all reset the multiple IA bit (multi_ia in BSD) to zero,
but I did not find code which sets this bit to one
(like it is done by some routers).
Running Windows guests also did not set this bit.
Intel's Open Source Software Developer Manual does not
give much information on the semantics related to this bit,
so I had to guess how it works. The guess was good enough
to make the router emulation work.
Related changes in this patch:
* Update naming and documentation of the internal hash register.
It is not limited to multicast, but also used for multiple IA.
* Dump complete configuration register when debug traces are enabled.
* Debug output when multiple IA bit is set during CmdConfigure.
* Debug output when frames are received because multiple IA bit is set,
or when they are ignored although it is set.
Cc: Michael S. Tsirkin <mst at redhat.com>
Signed-off-by: Stefan Weil <weil at mail.berlios.de>
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
commit afbaa7b4382faced3c364606a5e5d5389462147b
Author: Michael S. Tsirkin <mst at redhat.com>
Date: Mon Sep 27 18:41:30 2010 +0200
virtio-net: unify vhost-net start/stop
Move all of vhost-net start/stop logic to a single routine,
and call it from everywhere.
Additionally, start/stop vhost-net on link up/down:
we should not transmit anything if user asked us to
put the link down.
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
Acked-by: Alex Williamson <alex.williamson at redhat.com>
commit e0c472d8c2795e523b0f9006dbe5bc22545c8300
Author: Michael S. Tsirkin <mst at redhat.com>
Date: Mon Sep 27 18:32:52 2010 +0200
virtio: invoke set_status callback on reset
As status is set to 0 on reset, invoke the relevant callback. This makes
for a cleaner code in devices as they don't need to duplicate the code
in their reset routine, as well as excercises this path a little more.
In particular this makes it possible to unify
vhost-net handling code with the following patch.
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
commit a083a89d7277f3268a251ce635d9aae5559242bd
Author: Michael S. Tsirkin <mst at redhat.com>
Date: Mon Sep 20 18:08:41 2010 +0200
net: delay freeing peer host device
With -netdev, virtio devices present offload
features to guest, depending on the backend used.
Thus, removing host netdev peer while guest is
active leads to guest-visible inconsistency and/or crashes.
As a solution, while guest (NIC) peer device exists,
we prevent the host peer from being deleted.
This patch does this by adding peer_deleted flag in nic state:
if host device is going away while guest device
is around, set this flag and keep a shell of
the host device around for as long as guest device exists.
The link is put down so all packets will get discarded.
At the moment, management can detect that device deletion
is delayed by doing info net. As a next step, we shall add
commands that control hotplug/unplug without
removing the device, and an event to report that
guest has responded to the hotplug event.
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
Acked-by: Alex Williamson <alex.williamson at redhat.com>
More information about the Spice-commits
mailing list