[Spice-commits] Branch 'spice.kvm.v28' - hw/qxl.c

Gerd Hoffmann kraxel at kemper.freedesktop.org
Thu Jan 27 02:06:56 PST 2011


 hw/qxl.c |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 89a1737645b0ad0e58b577a9295046dda638322b
Author: Alon Levy <alevy at redhat.com>
Date:   Tue Jan 25 16:42:14 2011 +0200

    hw/qxl: another missing unlock
    
    We need to unlock the mutex before waiting on read via
    the worker call since the worker will try to lock and hang
    otherwise.
    
    Signed-off-by: Alon Levy <alevy at redhat.com>

diff --git a/hw/qxl.c b/hw/qxl.c
index a5af690..0c715d5 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -791,7 +791,9 @@ static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta)
            __FUNCTION__, memslot.slot_id,
            memslot.virt_start, memslot.virt_end);
 
+    qxl_unlock_iothread(&d->ssd);
     d->ssd.worker->add_memslot(d->ssd.worker, &memslot);
+    qxl_lock_iothread(&d->ssd);
     d->guest_slots[slot_id].ptr = (void*)memslot.virt_start;
     d->guest_slots[slot_id].size = memslot.virt_end - memslot.virt_start;
     d->guest_slots[slot_id].delta = delta;


More information about the Spice-commits mailing list