[Spice-commits] [Spice-devel] configure.ac

[Marc-André Lureau]

So it seems that GLIB_WITH_NLS does much more checks to find out which
combination of -lintl and -liconv is needed and changing LIBS
accordingly, which will then correctly link the mentionned test and
finally correctly set DATADIRNAME.

I see several possibilities:
1) keeping AM_GLIB_GNU_GETTEXT
2) configure users should either set DATADIRNAME themself or call with
correct CFLAGS/LIBS so the check pass (works here if I call configure
with LIBS="-lintl")
3) fix intltool to do something like GLIB_WITH_NLS
4) modify configure.ac to add GLIB_WITH_NLS checks

I prefer solution 1. I understand we may want solution 3.
Unfortunately, being not so motivated and not skilled in this area I
would rather keep it the way it is now and report a bug to intltool.

On Mon, Jan 23, 2012 at 2:56 PM, Marc-André Lureau
<marcandre.lureau at gmail.com> wrote:
> On Mon, Jan 23, 2012 at 1:24 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
>> Yeah, you really don't want to be calling both IT_PROG_INTLTOOL *and*
>> AM_GLIB_GNU_GETTEXT in the same configure.ac script. It causes a real
>> mess which prevents users to overriding the install locations with
>> make variables, or configure flags.
>>
>> We had this problem in virt-viewer for a while, until we killed off
>> the call to AM_GLIB_GNU_GETTEXT.
>
> Unfortunately, with this version on mingw:
>
> GETTEXT_PACKAGE=spice-gtk
> AC_SUBST(GETTEXT_PACKAGE)
> AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE],"$GETTEXT_PACKAGE", [GETTEXT package name])
> IT_PROG_INTLTOOL([0.40.0])
>
> I get mo files installed under $prefix/lib instead of $prefix/share,
> because DATADIRNAME='lib', which seems to come from the following
> configure check:
>
> # Set DATADIRNAME correctly if it is not set yet
> # (copied from glib-gettext.m4)
> if test -z "$DATADIRNAME"; then
>   cat confdefs.h - <<_ACEOF >conftest.$ac_ext
> /* end confdefs.h.  */
> int
> main ()
> {
> extern int _nl_msg_cat_cntr;
>                        return _nl_msg_cat_cntr
>   ;
>   return 0;
> }
> _ACEOF
> if ac_fn_c_try_link "$LINENO"; then :
>   DATADIRNAME=share
> else
> [...]
>
>
> I am still investigating, but the current version in git works fine..
>
> --
> Marc-André Lureau



-- 
Marc-André Lureau