[Spice-commits] Changes to 'wip'

Wed Mar 14 17:26:33 PDT 2012

New branch 'wip' available with the following commits:
commit e610cee76ee1e94881f810777a3b0d5d325bf5e7
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 23:22:46 2012 +0100

    Remove need for SPICE_CANVAS_INTERNAL
    
    Why is this useful?

commit e13505b4d8ae191183af4e61ffa07026b904abe3
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 23:07:15 2012 +0100

    fix void* arithmetic
    
    marshaller.c:528:50: error: pointer of type 'void *' used in arithmetic [-Werror=pointer-arith]

commit b05fd1e16bee1f6f5a1faf1bfbe722853a199321
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 22:40:53 2012 +0100

    build: replace INCLUDES with AM_CPPFLAGS
    
    Fix warning `INCLUDES' is the old name for `AM_CPPFLAGS' (or `*_CPPFLAGS')

commit 28529cb002a7f727e23f14b3ca9cf136dbd844ad
Author: Daniel P. Berrange <berrange at redhat.com>
Date:   Fri Feb 10 15:03:31 2012 +0000

    Add missing includes & make some functions static
    
    A number of functions were used without prior declaration. In
    some cases this was due to missing include files. In other cases
    the functions should have just been static.
    
    Ideally this would allow -Wmissing-declarations to be enabled, but
    the files generated by spice_codegen.py will still trip up on this.

commit cd9a624fa16774aa63fa2b9c2d60fc2735b61c26
Author: Daniel P. Berrange <berrange at redhat.com>
Date:   Fri Feb 10 14:30:56 2012 +0000

    Add printf format annotations to all '...' functions
    
    To allow the compile to detect incorrect printf formats, any
    var-args function should have a format annotation
    
    * common/macros.h: Helper to define ATTR_PRINTF for code
      which can't depend on glib
    * common/canvas_base.c, common/lz.h, common/macros.h: Annotate
      some var-args methods

commit 39bcb732589c68c346c3b0aa1e6252454db1c651
Author: Daniel P. Berrange <berrange at redhat.com>
Date:   Fri Feb 10 14:05:27 2012 +0000

    Fix some integer range checks which always evaluate false
    
    There are some integer range checks which always evaluate false
    due to use of unsigned integer types. One of these would prevent
    detection of encoding errors from celt. The others are simply
    no-ops.
    
    * common/pixman_utils.c: SpiceROP is an enum & thus unsigned

commit bb0dba4cd93aea6e32f06dfef0e2a9851c043443
Author: Daniel P. Berrange <berrange at redhat.com>
Date:   Fri Feb 10 13:56:04 2012 +0000

    Avoid warnings about empty conditional statement bodies
    
    Add extra {} braces around if/else statements which only
    call SPICE_DEBUG to avoid:
    
    ../common/ssl_verify.c: In function 'verify_pubkey':
    ../common/ssl_verify.c:87:50: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
    ../common/ssl_verify.c: In function 'verify_hostname':
    ../common/ssl_verify.c:254:53: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
    ../common/ssl_verify.c: In function 'verify_subject':
    ../common/ssl_verify.c:381:41: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]

commit bd636ddaa9e9552643087d945936c2f1ecbfc9bf
Author: Marc-AndrÃ© Lureau <marcandre.lureau at redhat.com>
Date:   Thu Dec 22 01:33:48 2011 +0100

    build: remove 'win' directory
    
    Let's use the only included file directly instead.

commit 1579273caad1a24177ce12d7938201d8cd95e719
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Thu May 5 16:39:23 2011 +0200

    messages.h: add smartcard bits

commit afb30947667a71d7cc3b9f4b2d1eee1d640f02d7
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 21:09:31 2012 +0100

    Add client_marshallers.h client_demarshallers.h from spice-gtk
    
    spice-gtk uses a more up to date version of client/marshallers.h and client/demarshallers.h

commit 4830d56da9567ceb11eef9baf0a516755bcdf89b
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 21:01:48 2012 +0100

    Use SPICE_{BEGIN,END}_DECLS

commit 3b7d6ee5bb4d8085b6ababbf5217e334555eca17
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Fri May 6 16:40:43 2011 +0200

    add const to arrays in marshalling functions

commit 24366bc52a087a6ad5bf952bf7df7e7de823f43e
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Sat Apr 30 18:20:23 2011 +0200

    ssl_verify: include <string.h>
    
    ssl_verify.c is using memcmp which comes from string.h, this was
    breaking compilation with -Werror -Wall on Mac OS X

commit 816034acf6df774b0dbe8cdcf016407dfc34c0f8
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 20:50:52 2012 +0100

    ssl_verify: comment X509_NAME undef

commit 24b026432449239511a4d2e4be038c44b632f826
Author: Marc-AndrÃ© Lureau <marcandre.lureau at redhat.com>
Date:   Sun Apr 3 15:49:36 2011 +0200

    Use a log handler to modify abort() behaviour
    
    Be more library friendly, by not aborting in library errors.
    
    spice_common now includes a proper log handler that will abort by
    default when reaching a warning.
    
    SPICE_ABORT_LEVEL can be changed to modify run-time abort level.
    
    SPICE_DEBUG_LEVEL can be changed to be more verbose. By default, only
    log level more importants than WARNING.
    
    Only memory-related functions are allowed to abort(), since they are
    not recoverable errors in the library.

commit 93a7da6789e193ad2902e3b54c6e79591a6dc5b7
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 18:01:38 2012 +0100

    update gitignore

commit bfc8a43b48aafd65a5ac7f22c05dd629f58a2cd6
Author: Marc-AndrÃ© Lureau <marcandre.lureau at redhat.com>
Date:   Sun Apr 3 02:29:14 2011 +0200

    common: remove unnecessary outdated c++ debug

commit bb4bf7b8e3ec14b1311d11eb3c4a40157c1e4856
Author: Marc-AndrÃ© Lureau <marcandre.lureau at redhat.com>
Date:   Mon Jan 24 21:09:52 2011 +0100

    common: ring.h should include stddef for NULL usage

commit 45c592a89c89490c90338cfa639b0f0de8c09dc1
Author: Marc-AndrÃ© Lureau <marcandre.lureau at redhat.com>
Date:   Fri Mar 2 13:45:15 2012 +0100

    Send name & uuid to capable clients
    
    Add spice_server_set_name() and spice_server_set_uuid() that allows
    the client to identify a Spice server (useful to associate settings
    with a particular server)
    
    The SPICE_MSG_MAIN_NAME and SPICE_MSG_MAIN_UUID messages are only sent
    to capable clients, announcing SPICE_MAIN_CAP_NAME_AND_UUID.

commit ce489769500e31cb9734972ebbda39f81c9bd60d
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Wed Feb 29 19:01:59 2012 +0100

    mingw: workaround weird openssl build failure
    
    If X509_NAME isn't undefined before including x509v3.h, very
    weird compilation error occurs. It seems to be caused by duplicate
    definitions for this symbols coming from wincrypto.h

commit 5bcece537e2be12fd13ea85a636ba2e28c66c256
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Wed Feb 29 19:01:58 2012 +0100

    mingw: don't try to redefine alloca
    
    mingw already has a #define alloca __builtin_alloca so trying to
    redefine it triggers a warning.

commit ec250967e2f77b710fa6ba97aa46b0349f77dd6b
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Wed Feb 29 19:01:54 2012 +0100

    mingw: use uintptr_t when converting a pointer to an int
    
    win64 uses 32 bit long, so we cannot use a long to hold a 64 bit
    pointer. Thankfully, there's a [u]intptr_t type available exactly
    for these uses.

commit 29a31db629c1ee7b6d1a00ef7ec0e4fd69234259
Author: Dan McGee <dpmcgee at gmail.com>
Date:   Tue Feb 14 09:57:54 2012 -0600

    Remove extra '\n' from red_printf() calls
    
    red_printf() takes care of adding a newline to all messages; remove the
    extra newline from all messages and macros that were doubling them up.
    
    Signed-off-by: Dan McGee <dpmcgee at gmail.com>

commit 4b6d1d534709b0cf9dc72c16b194768160f1f44e
Author: Dan McGee <dpmcgee at gmail.com>
Date:   Mon Feb 13 13:53:32 2012 -0600

    Add casts for compatibility purposes
    
    Some non-Linux platforms return a (caddr_t *) result for the return
    value of mmap(), which is very unfortunate. Add a (void *) cast to
    explicitly avoid the warning when compiling with -Werror.
    
    For the IO vector related stuff, signed vs. unsigned comes into play so
    adding a (void *) cast here is technically correct for all platforms.
    
    Signed-off-by: Dan McGee <dpmcgee at gmail.com>