[Spice-commits] Changes to 'spice.v51'

Gerd Hoffmann kraxel at kemper.freedesktop.org
Thu Mar 22 06:31:05 PDT 2012

New branch 'spice.v51' available with the following commits:
commit a13ccc991a852cf12f2c05f537c40ce239ae464f
Author: Alon Levy <alevy at redhat.com>
Date:   Wed Mar 21 18:17:18 2012 +0200

    ui/spice-display: use uintptr_t when casting qxl physical addresses
    The current intptr_t casts are a problem when the address's highest
    bit is 1, and it is cast to a intptr_t and then to uint64_t, such
    as at:
         surface.mem        = (intptr_t)ssd->buf;
    This causes the sign bit to be extended which causes a wrong address to
    be passed on to spice, which then complains when it gets the wrong
    slot_id number, since the slot_id is taken from the higher bits.
    The assertion happens early - during the first primary surface creation.
    This fixes running "-vga qxl -spice" with 32 bit compiled
    Signed-off-by: Alon Levy <alevy at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 34d14c6d8c7af0d2457cf5730fe5a65a878c509d
Author: Peter Maydell <peter.maydell at linaro.org>
Date:   Wed Mar 7 13:36:48 2012 +0000

    ui/spice-display.c: Fix compilation warnings on 32 bit hosts
    Fix compilation failures ("cast from pointer to integer of
    different size [-Werror=pointer-to-int-cast]") by using
    uintptr_t instead.
    Signed-off-by: Peter Maydell <peter.maydell at linaro.org>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

More information about the Spice-commits mailing list