[Spice-commits] Changes to 'wip2'

Thu Mar 22 12:22:24 PDT 2012

New branch 'wip2' available with the following commits:
commit c1e4e1be639d81119c7d7b35446e98f54775a353
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Tue Mar 20 12:53:30 2012 +0100

    build-sys: make it a seperately buildable spice-common library
    
    - autotoolize
    - fix headers inclusion
    - generate gitignores
    - workaround serverSMARTCARD support with dirty hack...

commit feaee860768c0a815f0e2e98d6fd51e6fff4321f
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Tue Mar 20 21:38:33 2012 +0100

    spice.proto: fix demarshaller crash with name message
    
    It turned out the demarshaller wasn't allocating enough space to
    memcpy the name. In order to take into account the size of a variable
    array, it needs to be marked with the @end tag so that the
    "extra_size" is added to the allocated memory.
    
    It would be nice if the demarshaller would somehow fail if this wasn't
    set explicitly, or do the right thing by default.
    
    @end the name so that demarshaller

commit bc4f5db323266cf7ac3f1ac6dd15509778cd3bf4
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 21 01:46:44 2012 +0100

    codegen: ifdef/endif function declaration too
    
    Compile out part that we are not supporting.  In the future, we might
    want to declare a fake type and an empty function to keep API
    compatibility

commit b6afcd632ef7bd3fecc0b0d7a76d55b15da4ba85
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 21 01:45:04 2012 +0100

    codegen: include headers locally

commit 2d4e0d20003dce8399ad89663d6353778b6c917f
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 21 01:43:29 2012 +0100

    codegen: struct marshallers are not current function helper
    
    This solves the issue of struct_marshallers being included within the
    current ifdef/endif body, although they are independant functions.

commit 3df7798413bd554d97f1351c1dba16961f32c6fe
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Wed Jun 22 13:54:55 2011 +0200

    use new @ifdef directive for smartcard messages
    
    We don't want to conditionally compile the smartcard messages
    depending on whether USE_SMARTCARD is set or not, we can now use
    the @ifdef attribute for that.

commit 7f86151f18ae59376401085066e19fdd244dae18
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Thu May 5 16:39:23 2011 +0200

    add smartcard bits to spice.proto

commit 69aecfc1bc4a957d6fa0edec5d65f7e0ed4cb0ad
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Sep 30 11:19:38 2011 +0200

    spice_codegen: Always write a channels entry for an ifdef-ed channel
    
    Before this patch, if a channel is defined conditionally in spice.proto
    (because it depends on external headers like the smartcard channel),
    spice_codegen would write an entry to the channels array in
    spice_get_*_channel_parser which would only take up a place in the array
    if the ifdef condition is true, thus moving up all other intializers
    one place when it is not true. This was causing issues (crashes) when building
    spice-gtk with the combination of usbredir support enabled and smartcard
    support disabled.
    
    This patch fixes this by adding #else { NULL, 0 }, to the generated code.
    
    Thanks to coolper chen <lixin.chen at saicocch.com> for reporting this!
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>

commit a7cc3c6a5661d1b7bd632b55161c219684419f83
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Wed Jun 22 13:26:15 2011 +0200

    handle @ifdef on messages and channels

commit 7307fccb71ad55911800d2e183d4a8f879ffdb01
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Wed Jun 22 13:23:47 2011 +0200

    allow attributes on channel elements in .proto files
    
    We want to be able to add an @ifdef annotation to optional messages
    For example, we want to compile in the smartcard messages only if
    libcacard is available

commit eb01d2fc46430bcd6dd9f9017b0c7f0e9169285d
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Wed Jun 22 13:22:22 2011 +0200

    add ifdef/endif methods to spice code generator
    
    These methods will be needed to be able to make some fields optional
    in spice.proto

commit 51cf6fce726bf1ebbfbbe7b01eda008bc6fa8ab5
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Thu May 5 17:57:33 2011 +0200

    fix copy & paste error in ptypes.py

commit f7af6264eac996f0119acc92d809a43601d8fe40
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Tue Mar 20 02:28:20 2012 +0100

    Add SPICE_ATTR_NORETURN and use it for a few functions

commit a1df67b3c576b6791a836ae58fde76bdf2ab58f7
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Thu Mar 15 15:57:04 2012 +0100

    Fix build with SPICE_DISABLE_ABORT

commit 13fb823795c8e015bdace23edcda1715b60828df
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 23:22:46 2012 +0100

    Remove need for SPICE_CANVAS_INTERNAL
    
    Why is this useful?

commit 61c30fcdcf392465de67f4ac21799863cb584263
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 23:07:15 2012 +0100

    fix void* arithmetic
    
    marshaller.c:528:50: error: pointer of type 'void *' used in arithmetic [-Werror=pointer-arith]

commit f87bb23ad2a5caf5c1823367dc2248a83d91f3c0
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 22:40:53 2012 +0100

    build: replace INCLUDES with AM_CPPFLAGS
    
    Fix warning `INCLUDES' is the old name for `AM_CPPFLAGS' (or `*_CPPFLAGS')

commit fbb6b9984afc8983ce1fa1db6bdee2b1150631b5
Author: Daniel P. Berrange <berrange at redhat.com>
Date:   Fri Feb 10 15:03:31 2012 +0000

    Add missing includes & make some functions static
    
    A number of functions were used without prior declaration. In
    some cases this was due to missing include files. In other cases
    the functions should have just been static.
    
    Ideally this would allow -Wmissing-declarations to be enabled, but
    the files generated by spice_codegen.py will still trip up on this.

commit 985ec9d6ec56f15a72ec974ff2fd1f7bab68cd91
Author: Daniel P. Berrange <berrange at redhat.com>
Date:   Fri Feb 10 14:30:56 2012 +0000

    Add printf format annotations to all '...' functions
    
    To allow the compile to detect incorrect printf formats, any
    var-args function should have a format annotation
    
    * common/macros.h: Helper to define ATTR_PRINTF for code
      which can't depend on glib
    * common/canvas_base.c, common/lz.h, common/macros.h: Annotate
      some var-args methods

commit 9f7d6175e7f8af3cb8b3556affe04d49d35be663
Author: Daniel P. Berrange <berrange at redhat.com>
Date:   Fri Feb 10 14:05:27 2012 +0000

    Fix some integer range checks which always evaluate false
    
    There are some integer range checks which always evaluate false
    due to use of unsigned integer types. One of these would prevent
    detection of encoding errors from celt. The others are simply
    no-ops.
    
    * common/pixman_utils.c: SpiceROP is an enum & thus unsigned

commit 3bc7d096b61983c7b6d8334bf79b8bc64933fe6e
Author: Daniel P. Berrange <berrange at redhat.com>
Date:   Fri Feb 10 13:56:04 2012 +0000

    Avoid warnings about empty conditional statement bodies
    
    Add extra {} braces around if/else statements which only
    call SPICE_DEBUG to avoid:
    
    ../common/ssl_verify.c: In function 'verify_pubkey':
    ../common/ssl_verify.c:87:50: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
    ../common/ssl_verify.c: In function 'verify_hostname':
    ../common/ssl_verify.c:254:53: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
    ../common/ssl_verify.c: In function 'verify_subject':
    ../common/ssl_verify.c:381:41: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]

commit 0a96fe9364c5e5056abc1069a142fc2a8da052e1
Author: Marc-AndrÃ© Lureau <marcandre.lureau at redhat.com>
Date:   Thu Dec 22 01:33:48 2011 +0100

    build: remove 'win' directory
    
    Let's use the only included file directly instead.

commit 4feaffad8ef7544bc6bddd94a3b0eca129302339
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Thu May 5 16:39:23 2011 +0200

    messages.h: add smartcard bits

commit 508547c100cee6f21fe7f06356d525f76a18740a
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 21:09:31 2012 +0100

    Add client_marshallers.h client_demarshallers.h from spice-gtk
    
    spice-gtk uses a more up to date version of client/marshallers.h and client/demarshallers.h

commit c4482c7ff2bf441e6a9e06f30f1b247171bb0738
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 21:01:48 2012 +0100

    Use SPICE_{BEGIN,END}_DECLS

commit e800e51d4ecbae0b0023bd829d0cf9082381fc00
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Fri May 6 16:40:43 2011 +0200

    add const to arrays in marshalling functions

commit c968e76f967f19830e4eca83c555fc05ae31ca1b
Author: Christophe Fergeau <cfergeau at redhat.com>
Date:   Sat Apr 30 18:20:23 2011 +0200

    ssl_verify: include <string.h>
    
    ssl_verify.c is using memcmp which comes from string.h, this was
    breaking compilation with -Werror -Wall on Mac OS X

commit 3e4b2571a2908ac6a4bd8c48e985ad8d8fd009cb
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 20:50:52 2012 +0100

    ssl_verify: comment X509_NAME undef

commit c1403ee6bf4dfdd8f614f84ef145083b06a9f23e
Author: Marc-AndrÃ© Lureau <marcandre.lureau at redhat.com>
Date:   Sun Apr 3 15:49:36 2011 +0200

    Use a log handler to modify abort() behaviour
    
    Be more library friendly, by not aborting in library errors.
    
    spice_common now includes a proper log handler that will abort by
    default when reaching a warning.
    
    SPICE_ABORT_LEVEL can be changed to modify run-time abort level.
    
    SPICE_DEBUG_LEVEL can be changed to be more verbose. By default, only
    log level more importants than WARNING.
    
    Only memory-related functions are allowed to abort(), since they are
    not recoverable errors in the library.

commit bb133148d85e66349b34375dd849d5d8c422da67
Author: Marc-AndrÃ© Lureau <marcandre.lureau at gmail.com>
Date:   Wed Mar 14 18:01:38 2012 +0100

    update gitignore

commit cf705650d42364cf2b611086a20c322f77b74de1
Author: Marc-AndrÃ© Lureau <marcandre.lureau at redhat.com>
Date:   Sun Apr 3 02:29:14 2011 +0200

    common: remove unnecessary outdated c++ debug

commit 124f767b94403fdde6c7ebc082e314e2f1364003
Author: Marc-AndrÃ© Lureau <marcandre.lureau at redhat.com>
Date:   Mon Jan 24 21:09:52 2011 +0100

    common: ring.h should include stddef for NULL usage