[Spice-commits] gtk/spice-widget.c

Marc-André Lureau elmarco at kemper.freedesktop.org
Tue May 29 06:31:56 PDT 2012


 gtk/spice-widget.c |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit ee5fc3507883403ae98a315a8b68a8855bd1b2ed
Author: Marc-André Lureau <marcandre.lureau at redhat.com>
Date:   Tue May 29 14:03:26 2012 +0200

    widget: disconnect session_inhibit_keyboard_grab_changed
    
    There is one handler we forgot to disconnect on dispose()
    that may cause a crash.
    
    I am thinking of generalizing usage of
    spice_g_signal_connect_object()..
    
    Should fix:
    https://bugzilla.redhat.com/show_bug.cgi?id=823570

diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
index 0abd4c6..2ae76d8 100644
--- a/gtk/spice-widget.c
+++ b/gtk/spice-widget.c
@@ -298,6 +298,8 @@ static void spice_display_dispose(GObject *obj)
                                              display);
         g_signal_handlers_disconnect_by_func(d->session, G_CALLBACK(channel_destroy),
                                              display);
+        g_signal_handlers_disconnect_by_func(d->session, G_CALLBACK(session_inhibit_keyboard_grab_changed),
+                                             display);
         g_object_unref(d->session);
         d->session = NULL;
         d->gtk_session = NULL;


More information about the Spice-commits mailing list