[Spice-commits] gtk/spice-widget-cairo.c

Marc-André Lureau elmarco at kemper.freedesktop.org
Mon Apr 8 09:17:20 PDT 2013


 gtk/spice-widget-cairo.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0e268110f15070a85ef6bd2079ea7c24e07fd3c3
Author: Marc-André Lureau <marcandre.lureau at redhat.com>
Date:   Tue Mar 26 22:43:04 2013 +0100

    cairo: fix reference leak
    
    cairo_surface_finish() doesn't remove the reference,
    cairo_surface_destroy() does and will call surface_finish().
    
    Thanks to Uli Schlachter for noticing that in:
    https://bugs.freedesktop.org/show_bug.cgi?id=61876

diff --git a/gtk/spice-widget-cairo.c b/gtk/spice-widget-cairo.c
index bd8e351..e0fe1ed 100644
--- a/gtk/spice-widget-cairo.c
+++ b/gtk/spice-widget-cairo.c
@@ -64,7 +64,7 @@ void spicex_image_destroy(SpiceDisplay *display)
     SpiceDisplayPrivate *d = SPICE_DISPLAY_GET_PRIVATE(display);
 
     if (d->ximage) {
-        cairo_surface_finish(d->ximage);
+        cairo_surface_destroy(d->ximage);
         d->ximage = NULL;
     }
     if (d->convert && d->data) {


More information about the Spice-commits mailing list