[Spice-commits] Changes to 'rebase/spice-next'

[Gerd Hoffmann]

New branch 'rebase/spice-next' available with the following commits:
commit 1edce337a2af57af335995b2f88f782609957733
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Apr 5 11:30:24 2013 +0200

    spice-qemu-char: vmc_write: Don't write more bytes then we're asked too
    
    This one took me eons to debug, but I've finally found it now, oh well.
    
    The usage of the MIN macro in this line:
        last_out = MIN(len, qemu_chr_be_can_write(scd->chr));
    
    Causes qemu_chr_be_can_write to be called *twice*, since the MIN macro
    evaluates its arguments twice (bad MIN macro, bad!). And the result of
    the call can change between the 2 calls since the guest may have consumed
    some data from the virtio ringbuffer between the calls!
    
    When this happens it is possible for qemu_chr_be_can_write to return less
    then len in the call made for the comparision, and then to return more then
    len in the actual call for the return-value of MIN, after which we will end
    up writing len data + some extra garbage, not good.
    
    This patch fixes this by only calling qemu_chr_be_can_write once.
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 75554c5e36e1688c23806d47ddfedbbf9988d44d
Author: Alon Levy <alevy at redhat.com>
Date:   Fri Apr 5 11:30:23 2013 +0200

    spice-qemu-char: Remove intermediate buffer
    
    virtio-serial's buffer is valid when it calls us, and we don't
    access it otherwise: vmc_read is only called in response to wakeup,
    or else we set datalen=0 and throttle. Then vmc_read is called back,
    we return 0 (not accessing the buffer) and set the timer to unthrottle.
    
    Also make datalen int and not ssize_t (to fit spice_chr_write signature).
    
    HdG: Update to apply to spice-qemu-char with new gio-channel based
    flowcontrol support.
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 93daf994e6377d123d8c0143521b9cb3742ea6a9
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Apr 5 11:30:22 2013 +0200

    spice-qemu-char: Add watch support
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 6cde045aba097f9769ec1e5a83c49ecaa6d00ae1
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Apr 5 11:30:21 2013 +0200

    spice-qemu-char: Remove #ifdef-ed code for old spice-server compat
    
    We now require spice-server to be >= 0.12.0 so this is no longer needed.
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 42da104f3fa87a07f612806409fefb17db7e83b2
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Apr 5 11:30:20 2013 +0200

    virtio-console: Remove any pending watches on close
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit c8c2e60acaceac8628b72757ca3a69342447478c
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Apr 5 11:30:19 2013 +0200

    virtio-console: Also throttle when less was written then requested
    
    This is necessary so that we get properly woken up to write the rest.
    
    This patch also changes the len argument to the have_data callback, to
    avoid doing an unsigned signed comparison.
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Acked-by: Amit Shah <amit.shah at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 28264369abfdfa06fe326bac35a51605f571e1f6
Author: Alon Levy <alevy at redhat.com>
Date:   Wed Mar 13 17:58:35 2013 +0200

    spice: (32 bit only) fix surface cmd tracking destruction
    
    No change for 64 bit arches, but for 32 bit previously we zeroed half
    the surfaces cmd array, instead of all of it.
    
    Signed-off-by: Alon Levy <alevy at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit a35b9e55039836020461ee96396358f02064bb93
Author: Gerd Hoffmann <kraxel at redhat.com>
Date:   Thu Apr 4 10:15:34 2013 +0200

    qxl: add 2000x2000 and 2048x2048 video modes

commit 6bf87809978b3814acfa43ac7c4d25b1a752cbc5
Author: Gerd Hoffmann <kraxel at redhat.com>
Date:   Fri Mar 15 11:53:47 2013 +0100

    qxl: add 4k + 8k resolutions
    
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>