[Spice-commits] Changes to 'spice.v69'

[Gerd Hoffmann]

New branch 'spice.v69' available with the following commits:
commit 75c439bc65c07d76f5e74c734ed5432bc6114a3b
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Apr 5 11:30:24 2013 +0200

    spice-qemu-char: vmc_write: Don't write more bytes then we're asked too
    
    This one took me eons to debug, but I've finally found it now, oh well.
    
    The usage of the MIN macro in this line:
        last_out = MIN(len, qemu_chr_be_can_write(scd->chr));
    
    Causes qemu_chr_be_can_write to be called *twice*, since the MIN macro
    evaluates its arguments twice (bad MIN macro, bad!). And the result of
    the call can change between the 2 calls since the guest may have consumed
    some data from the virtio ringbuffer between the calls!
    
    When this happens it is possible for qemu_chr_be_can_write to return less
    then len in the call made for the comparision, and then to return more then
    len in the actual call for the return-value of MIN, after which we will end
    up writing len data + some extra garbage, not good.
    
    This patch fixes this by only calling qemu_chr_be_can_write once.
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit b010cec86b9a4a0b63162cd27e37c2d99e90ed66
Author: Alon Levy <alevy at redhat.com>
Date:   Fri Apr 5 11:30:23 2013 +0200

    spice-qemu-char: Remove intermediate buffer
    
    virtio-serial's buffer is valid when it calls us, and we don't
    access it otherwise: vmc_read is only called in response to wakeup,
    or else we set datalen=0 and throttle. Then vmc_read is called back,
    we return 0 (not accessing the buffer) and set the timer to unthrottle.
    
    Also make datalen int and not ssize_t (to fit spice_chr_write signature).
    
    HdG: Update to apply to spice-qemu-char with new gio-channel based
    flowcontrol support.
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit ae893e5e818878caf433d716d37be9df297403fe
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Apr 5 11:30:22 2013 +0200

    spice-qemu-char: Add watch support
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 52fe0e75b757c7c54fd3b967c9ff70d337790195
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Apr 5 11:30:21 2013 +0200

    spice-qemu-char: Remove #ifdef-ed code for old spice-server compat
    
    We now require spice-server to be >= 0.12.0 so this is no longer needed.
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit c3d6b96ebba18d016be26ffa475feea0d81801a2
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Apr 5 11:30:20 2013 +0200

    virtio-console: Remove any pending watches on close
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit f9fb0532fb0c7155c0616614dc12ecccf93f8afb
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Fri Apr 5 11:30:19 2013 +0200

    virtio-console: Also throttle when less was written then requested
    
    This is necessary so that we get properly woken up to write the rest.
    
    This patch also changes the len argument to the have_data callback, to
    avoid doing an unsigned signed comparison.
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>
    Acked-by: Amit Shah <amit.shah at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 8bb9f51ca243551fb838a3a6a2983016ed2bbb73
Author: Alon Levy <alevy at redhat.com>
Date:   Wed Mar 13 17:58:35 2013 +0200

    spice: (32 bit only) fix surface cmd tracking destruction
    
    No change for 64 bit arches, but for 32 bit previously we zeroed half
    the surfaces cmd array, instead of all of it.
    
    Signed-off-by: Alon Levy <alevy at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 5c74fb27f94821057c7929a8244cabe86adf2b8d
Author: Gerd Hoffmann <kraxel at redhat.com>
Date:   Thu Apr 4 10:15:34 2013 +0200

    qxl: add 2000x2000 and 2048x2048 video modes
    
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>