[Spice-commits] Changes to 'rebase/spice-next'
Gerd Hoffmann
kraxel at kemper.freedesktop.org
Mon Jan 14 00:05:39 PST 2013
New branch 'rebase/spice-next' available with the following commits:
commit 08688af04dc1137ac2f420b35c235183926b4a23
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Jan 10 14:24:50 2013 +0100
qxl: Don't drop client capability bits
interface_set_client_capabilities() copies only the first few bits,
because it falls into a Classic C trap: you can declare a parameter
uint8_t caps[58], but the resulting parameter type is uint8_t *, not
uint8_t[58]. In particular, sizeof(caps) is sizeof(uint8_t *), not
the intended sizeof(uint8_t[58]).
Harmless, because the bits aren't used, yet. Broken in commit
c10018d6. Spotted by Coverity.
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
commit bc5f92e5db6f303e73387278e32f8669f0abf0e5
Author: Markus Armbruster <armbru at pond.sub.org>
Date: Thu Jan 10 14:24:49 2013 +0100
qxl: Fix SPICE_RING_PROD_ITEM(), SPICE_RING_CONS_ITEM() sanity check
The pointer arithmetic there is safe, but ugly. Coverity grouses
about it. However, the actual comparison is off by one: <= end
instead of < end. Fix by rewriting the check in a cleaner way.
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
More information about the Spice-commits
mailing list