[Spice-commits] server/char_device.c

Hans de Goede jwrdegoede at kemper.freedesktop.org
Mon Mar 4 10:48:21 PST 2013

 server/char_device.c |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit b42f2e1fc9f5a19a969fc33abe3979c9abb3bb0a
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Mon Mar 4 16:35:54 2013 +0100

    Silence __spice_char_device_write_buffer_get: internal buf is not available
    These messages are printed when the server tries to push a mouse event to
    the agent before the previous one has been flushed. This is a normal condition
    (which gets tracked by the reds->pending_mouse_event boolean), and as such
    it should *not* trigger the printing of error messages.
    I've seen these messages occasionally before, but with agent file-xfer they
    are trivial to trigger, simply send a large file to the agent and while it
    is transferring move the mouse over the client window. Note that due to the
    client tokens not allowing the client to completely saturate the agent
    channel mouse events do still get send to the agent, just with a slightly
    larger interval. So everything is working as designed and this spice_printerr
    is just leading to people chasing ghosts.
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>

diff --git a/server/char_device.c b/server/char_device.c
index 1d5bed9..49c5dc0 100644
--- a/server/char_device.c
+++ b/server/char_device.c
@@ -497,7 +497,6 @@ static SpiceCharDeviceWriteBuffer *__spice_char_device_write_buffer_get(SpiceCha
     SpiceCharDeviceWriteBuffer *ret;
     if (!client && !dev->num_self_tokens) {
-        spice_printerr("internal buf is not available");
         return NULL;

More information about the Spice-commits mailing list