[Spice-commits] gtk/spice-channel.c

Marc-André Lureau elmarco at kemper.freedesktop.org
Fri Nov 22 07:22:07 PST 2013


 gtk/spice-channel.c |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 76885eaa181d64ef92c19cbdcbba16b12ee4a43f
Author: Marc-André Lureau <marcandre.lureau at redhat.com>
Date:   Fri Nov 22 15:52:55 2013 +0100

    channel: swap channel GSocketConnection on migration
    
    When migration completes, unrefing the new connection leads to original
    GSocket pending refs, and thus the sockets stay in CLOSE_WAIT.
    
    This is a regression from 8029bd0 where GSocketConnection is kept around
    to satisfy old glib.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1024501
    
    This will also probably fix:
    https://bugzilla.redhat.com/show_bug.cgi?id=952375

diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index e8758c0..e4683f8 100644
--- a/gtk/spice-channel.c
+++ b/gtk/spice-channel.c
@@ -2727,6 +2727,7 @@ void spice_channel_swap(SpiceChannel *channel, SpiceChannel *swap, gboolean swap
 
     /* TODO: split channel in 2 objects: a controller and a swappable
        state object */
+    SWAP(conn);
     SWAP(sock);
     SWAP(ctx);
     SWAP(ssl);


More information about the Spice-commits mailing list