[Spice-commits] 3 commits - gtk/spice-client-glib-usb-acl-helper.c gtk/spice-widget.c NEWS

[Marc-André Lureau]

 NEWS                                   |   11 +++++++++++
 gtk/spice-client-glib-usb-acl-helper.c |    3 ++-
 gtk/spice-widget.c                     |    2 +-
 3 files changed, 14 insertions(+), 2 deletions(-)

New commits:
commit 632836ed77c3e15df7d3282dea3df0dd3a334ddd
Author: Marc-André Lureau <marcandre.lureau at redhat.com>
Date:   Wed Sep 18 14:26:36 2013 +0200

    Release v0.21

diff --git a/NEWS b/NEWS
index 07d5ac7..8ecae50 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,14 @@
+v0.21
+=====
+
+- improve inverted cursor support
+- win32 usb redirected device uninstall fix
+- add support for libusb hotplug API
+- smartcard initialization fixes
+- c&p converts line-endings if necessary
+- rendering and overall performance improvements
+- build and bindings fixes
+
 v0.20
 =====
 
commit cf8fb0bfadbb047a93fa42b04ca53c402ad94986
Author: Colin Walters <walters at verbum.org>
Date:   Wed Aug 21 17:15:39 2013 -0400

    acl helper: Use ruid of invoker rather than looking up euid in /proc
    
    This way we avoid a race condition if the parent execve()s a setuid
    program (possibly this program).
    
    This is the same as the fix for pkexec which is CVE-2011-1485:
    See: https://bugzilla.redhat.com/show_bug.cgi?id=692922

diff --git a/gtk/spice-client-glib-usb-acl-helper.c b/gtk/spice-client-glib-usb-acl-helper.c
index 93b9b3a..3ed6cad 100644
--- a/gtk/spice-client-glib-usb-acl-helper.c
+++ b/gtk/spice-client-glib-usb-acl-helper.c
@@ -348,7 +348,8 @@ int main(void)
             FATAL_ERROR("Parent process was reaped by init(1)\n");
             return 1;
     }
-    subject = polkit_unix_process_new(parent_pid);
+    /* Do what pkexec does */
+    subject = polkit_unix_process_new_for_owner(parent_pid, 0, getuid ());
 
     stdin_unix_stream = g_unix_input_stream_new(STDIN_FILENO, 0);
     stdin_stream = g_data_input_stream_new(stdin_unix_stream);
commit 085d9a786d3656d7ebfb7aed199d8fe0aedf5f2c
Author: Marc-André Lureau <marcandre.lureau at redhat.com>
Date:   Wed Sep 18 17:28:42 2013 +0200

    build-sys: fix bad cast on win64
    
    spice-widget.c:814:50: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
             g_return_if_fail(SystemParametersInfo(SPI_SETMOUSESPEED, 0, (PVOID)d->win_mouse_speed, 0));

diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
index d25edca..4ac1a2f 100644
--- a/gtk/spice-widget.c
+++ b/gtk/spice-widget.c
@@ -811,7 +811,7 @@ static void set_mouse_accel(SpiceDisplay *display, gboolean enabled)
 #elif defined GDK_WINDOWING_WIN32
     if (enabled) {
         g_return_if_fail(SystemParametersInfo(SPI_SETMOUSE, 0, &d->win_mouse, 0));
-        g_return_if_fail(SystemParametersInfo(SPI_SETMOUSESPEED, 0, (PVOID)d->win_mouse_speed, 0));
+        g_return_if_fail(SystemParametersInfo(SPI_SETMOUSESPEED, 0, (PVOID)(INT_PTR)d->win_mouse_speed, 0));
     } else {
         int accel[3] = { 0, 0, 0 }; // disabled
         g_return_if_fail(SystemParametersInfo(SPI_GETMOUSE, 0, &d->win_mouse, 0));