[Spice-commits] Changes to 'rebase/spice-next'

Gerd Hoffmann kraxel at kemper.freedesktop.org
Fri Dec 12 06:08:20 PST 2014


New branch 'rebase/spice-next' available with the following commits:
commit 00bf5da98cfe9187b4a2da5d515aaaeb1292e36d
Author: Gonglei <arei.gonglei at huawei.com>
Date:   Fri Dec 5 16:30:10 2014 +0800

    spice: fix memory leak
    
    If errors happen for middle items of channel_list,
    qmp_query_spice_channels() returns NULL, and the variable
    cur_item going out of scope leaks the storage it points to.
    
    The flag is a compatibility thing for older spice-server
    versions. Meanwhile our minimum spice version requirement is
    new enough that we should never ever see this error, and if we
    do something went very seriously wrong. Let's using assert()
    instead of returning NULL to avoid a memory leak.
    
    Suggested-by: Paolo Bonzini <pbonzini at redhat.com>
    Signed-off-by: Gonglei <arei.gonglei at huawei.com>
    Reviewed-by: Eric Blake <eblake at redhat.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 915231827c0575a4bbde57713e1a7ed237a5e1c6
Author: Marc-André Lureau <marcandre.lureau at gmail.com>
Date:   Mon Nov 17 16:52:49 2014 +0100

    spice: remove spice-experimental.h include
    
    Nothing seems to be using functions from spice-experimental.h (better
    that way). Let's remove its inclusion.
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit ebae0e507d928b3a9815ccc2c13105c52101af73
Author: Marc-André Lureau <marcandre.lureau at gmail.com>
Date:   Tue Nov 11 13:39:19 2014 +0100

    spice: do not require TCP ports
    
    It is possible to use Spice server without TCP port.  On local VM,
    qemu (and libvirt) can add new clients thanks to QMP add_client command.
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 973cc8bdf73398f62722ff1f72eb71bec30af9a2
Author: Gerd Hoffmann <kraxel at redhat.com>
Date:   Sat Nov 8 08:56:34 2014 +0100

    spice: rework mirror allocation, add no-resize fast path
    
    Add fast path to qemu_spice_display_switch in case old and new
    displaysurface have identical size (happens with display panning
    and page flipping).  We just swap the backing store then and don't
    go through the whole process of deleting and creating the primary
    surface.
    
    To simplify the code a bit move mirror surface allocation to
    qemu_spice_display_switch().
    
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit d1451b633eaa237e60e36011be952bb025c4c11a
Author: Gerd Hoffmann <kraxel at redhat.com>
Date:   Tue Nov 4 14:16:12 2014 +0100

    spice: reduce refresh rate in native mode
    
    Now that cursor updates are out of the way qxl needs the refresh timer
    only when when running in vga mode, for dirty bitmap checking.  In
    native qxl mode the guest will notify us, so we don't need to poll and
    can use the idle interval (one refresh wakeup every few seconds).
    
    Cc: Marc-André Lureau <marcandre.lureau at gmail.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

commit 2d2d0381cb5223d9a51478c9a03c8d791fee0db9
Author: Gerd Hoffmann <kraxel at redhat.com>
Date:   Tue Nov 4 13:59:59 2014 +0100

    spice: use bottom half instead of refresh timer for cursor updates
    
    Calling directly doesn't work due to the qxl-render code running in
    spice server thread context.  Meanwhile bottom half scheduling is
    thread-safe though, so we can use that to kick a cursor update in
    main i/o thread context.
    
    Cc: Marc-André Lureau <marcandre.lureau at gmail.com>
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>



More information about the Spice-commits mailing list