[Spice-commits] gtk/spice-session.c

[Marc-André Lureau]

 gtk/spice-session.c |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 3bf5ef7dc32da6349e82c0bc39b7884ce6d517de
Author: Marc-André Lureau <marcandre.lureau at redhat.com>
Date:   Wed Apr 22 17:55:32 2015 +0200

    session: disable default socket proxy
    
    GSocketClient uses the system proxy by default, and it may end up using
    the system HTTP proxy with bad results if CONNECT is not
    supported. spice-gtk uses it's own SPICE_PROXY instead, and doesn't rely
    on GSocketClient default proxy but GProxyAddress instead. Disabling the
    default proxy solve a wrong proxy from being used.
    
    It may be worth to revisit this change if GSocketClient can be told to
    ignore proxies that are not eligible for Spice connections. (HTTP could
    be though, in which case it would be a user configuration issue)
    
    Fixes:
    https://bugzilla.redhat.com/show_bug.cgi?id=1040679

diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 52fa394..f85e5c1 100644
--- a/gtk/spice-session.c
+++ b/gtk/spice-session.c
@@ -2132,6 +2132,7 @@ GSocketConnection* spice_session_channel_open_host(SpiceSession *session, SpiceC
     }
 
     open_host.client = g_socket_client_new();
+    g_socket_client_set_enable_proxy(open_host.client, FALSE);
     g_socket_client_set_timeout(open_host.client, SOCKET_TIMEOUT);
 
     g_idle_add(open_host_idle_cb, &open_host);