[Spice-commits] server/dcc-encoders.c

Frediano Ziglio fziglio at kemper.freedesktop.org
Tue Nov 24 09:01:14 PST 2015


 server/dcc-encoders.c |    5 +++++
 1 file changed, 5 insertions(+)

New commits:
commit ca41ff2be08f36d712f829d8eaf44e33ae75b07b
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Sat Nov 21 12:02:50 2015 +0000

    dcc: remove possible dandling pointers
    
    Set pointers to NULL after releasing encoders.
    This to make sure no further access will occurs.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Victor Toso <victortoso at redhat.com>
    Acked-by: Pavel Grunt <pgrunt at redhat.com>

diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index 1eaa604..a373412 100644
--- a/server/dcc-encoders.c
+++ b/server/dcc-encoders.c
@@ -409,12 +409,17 @@ void dcc_encoders_init(DisplayChannelClient *dcc)
 void dcc_encoders_free(DisplayChannelClient *dcc)
 {
     quic_destroy(dcc->quic);
+    dcc->quic = NULL;
     lz_destroy(dcc->lz);
+    dcc->lz = NULL;
     jpeg_encoder_destroy(dcc->jpeg);
+    dcc->jpeg = NULL;
 #ifdef USE_LZ4
     lz4_encoder_destroy(dcc->lz4);
+    dcc->lz4 = NULL;
 #endif
     zlib_encoder_destroy(dcc->zlib);
+    dcc->zlib = NULL;
 }
 
 static void marshaller_compress_buf_free(uint8_t *data, void *opaque)


More information about the Spice-commits mailing list