[Spice-commits] Changes to '0.12'
Christophe Fergau
teuf at kemper.freedesktop.org
Wed Jan 13 08:38:35 PST 2016
New branch '0.12' available with the following commits:
commit 870e06feb6b050b71b044491392e6c23edb32a91
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Jan 13 16:59:01 2016 +0100
Update spice-common
This fixes a compilation problem on EL6. git shortlog of the
spice-common changes brought in by the submodule update:
Christophe Fergeau (2):
m4: Fix SPICE_WARNING on el6
test: Use _LDADD rather than _LDFLAGS
Frediano Ziglio (1):
ring: use NULL instead of 0 for null pointers
Lukas Venhoda (9):
pixman_utils: Add macros for color byte ordering
pixman_utils: Use PIXMAN_LE_ constants in spice_bitmap_try_as_pixman()
ppc: Add support for bigendian color byte order
ppc: Fix colors on ppc when using QUIC
ppc: Fix colors on ppc when using LZ
ppc: Fix colors on ppc when using LZ4
ppc: Fix colors on ppc when using jpeg
ppc: Fix alpha state checking on BE machines
Remove trailing whitespace
Pavel Grunt (1):
m4: Add macro for --with-sasl
Victor Toso (1):
Remove headers that are included in spice_common.h
commit 8b25e5149b2a7816c7cff87469e1a4ce316e328e
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Fri Jan 8 13:09:17 2016 +0100
Update NEWS for 0.12.7 release
commit 34539aeb1e6b3463e70af88feba478948ed71c04
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Tue Sep 29 11:53:40 2015 +0200
spicevmc: Drop unsent data on client disconnection
When redirecting a USB webcam over a slow link, it's currently possible
to hit an assertion in spice-server by running cheese (application using
the webcam), killing the client with ctrl+c and then restarting the
client:
qemu-kvm: spicevmc.c:324: spicevmc_red_channel_alloc_msg_rcv_buf:
Assertion `!state->recv_from_client_buf' failed.
This happens when red_peer_handle_incoming tries to allocate memory for
a message using spicevmc:
handler->msg = handler->cb->alloc_msg_buf(handler->opaque, msg_type,
msg_size);
red_peer_handle_incoming() is called when there is client data to be
read, and does
- call alloc_msg_buf() to allocate memory for the message
- read the message
- if the read was partial, return early, the main loop will call again
red_peer_handle_incoming() when there is more data available for that
channel
- parse the message
- call release_msg_buf() to free the message
For channels based on spicevmc (usbredir and port), alloc_msg_buf()
stores message data in SpiceVmcState::recv_from_client_buf and before
allocating new memory, it asserts that it's NULL.
This is what causes this crash in the following scenario:
- SpiceVmc::alloc_msg_buf() is called and allocates memory for a new
message in SpiceVmcState::recv_from_client_buf
- red_peer_handle_incoming() returns early as all the spicevmc message
data hasn't been received yet
- the client gets killed
- the main channel notices the disconnect and calls
main_dispatcher_client_disconnect() which will disconnect all the
channels
- SpiceVmc::on_disconnect is called
- after the new client connects, SpiceVmc::alloc_msg_buf() is called,
notices that SpiceVmcState::recv_from_client_buf is already set, and
asserts()
This commit makes sure the partial SpiceVmcState::recv_from_client_buf
data is cleared on disconnect so that the assert does not trigger.
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1264113
commit 9eb8cd1b6e98d775446d870be42bcc694b01206f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Dec 3 08:36:25 2015 +0000
pass proper type to SPICE_CONTAINEROF
In some case the member specified to SPICE_CONTAINEROF was not
exactly the same type of the pointer passed.
This can cause issues if structure changes so use proper member.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Fabiano Fidêncio <fidencio at redhat.com>
commit 98417d8309893e14efadfe5d2f9002b94d6c56a6
Author: Sunny Shin <sunny4s.git at gmail.com>
Date: Tue Dec 1 13:46:30 2015 +0900
channel: add option tcp keepalive timeout to channels
commit a81a25adc17215cc523827ec7c0c1438d01aeba4
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Mon Jan 11 19:28:32 2016 +0100
server: Fix conversions between QXLPHYSICAL and pointers
This avoids compilation errors with -Werror on 32 bit systems as the
pointer size differs from that of a QXLPHYSICAL.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
commit 5331b7cb2b5c91b09aa23d12bd406edb41df7ae6
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Mon Jan 11 19:28:29 2016 +0100
server: Simplify the next chunk initialization in red_replay_data_chunks()
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
commit 5a27d06ab4b75e67d6ce80125198874c379167b7
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Mon Jan 11 19:28:26 2016 +0100
server: Fix a pointer to uint64_t cast in spice_replay_next_cmd()
This avoids a compilation error with -Werror on 32 bit systems as the
pointer size differs from that of an uint64_t.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
commit f831984888aade15c11e8bcbbc3d55bb7a7e30b9
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Tue Dec 15 17:49:59 2015 +0000
server: Use '%zu' to print size_t variables
The size_t definition is different between 32 and 64 bit systems so that
neither '%u' nor '%lu' work for both. '%zu' should be used instead.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
commit e8f89571bedced0c70ab49a8fdd3927cfa8851a2
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Tue Dec 15 17:43:44 2015 +0000
server: Use PRI macros in printf for 32/64 bit compatibility
Some integer type definitions are different between 32 and 64 bit
systems which causes problems in printf. The PRI macros automatically
provide the printf format appropriate for the system.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
commit 2c6db246d6b3e1d6a3dc0b8f8a830567183e5640
Author: Victor Toso <victortoso at redhat.com>
Date: Fri Nov 13 10:46:43 2015 +0100
spicevmc: set state of DeviceInstance to NULL
After spice_char_device_state_destroy is called spicevmc should not keep
reference to that memory. state->chardev_st and sin->st point to the
same SpiceCharDeviceState and both should be set to NULL when it is
destroyed.
commit 14182e29af3a20aee367ad71ed2c94928174b170
Author: Victor Toso <victortoso at redhat.com>
Date: Fri Nov 13 10:44:55 2015 +0100
char-device: set to NULL freed pointers on destroy
As SpiceCharDeviceState is only unref'ed on
spice_char_device_state_destroy the same device could be destroyed more
then once so the pointers that are freed should be set to NULL.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1281455
commit e3c541c009c3943bde29996c9bb038c0b1e745ce
Author: Victor Toso <victortoso at redhat.com>
Date: Wed Aug 19 12:05:46 2015 +0200
char-device: free all memory pool when no clients
When no client is connect we should not need to keep the memory pool
used by char-device. In most situations this is not significant but
when using webdav this could mean freeing MAX_POOL_SIZE bytes
Related: https://bugs.freedesktop.org/show_bug.cgi?id=91350
commit 73e1b3c18b874a330c36b1394d2a296e23668de0
Author: Victor Toso <victortoso at redhat.com>
Date: Wed Aug 19 11:26:34 2015 +0200
char-device: Define a memory pool limit
Otherwise the amount of unused memory could grow while transfering big
chunks of data. This change only means that once the memory was used it
will not be stored again after the limit was reached.
Related: https://bugs.freedesktop.org/show_bug.cgi?id=91350
commit 565d6f5d6ae7aea87b646999acdebeb0a142c258
Author: Victor Toso <victortoso at redhat.com>
Date: Wed Aug 19 10:53:22 2015 +0200
char-device: fix usage of free/unref on WriteBuffer
There are places were the could should definetly free the
SpiceCharDeviceWriteBuffer and places that it should only unref it. The
current use of spice_char_device_write_buffer_free was missleading.
This patch creates the spice_char_device_write_buffer_unref and properly
call these two functions.
Related: https://bugs.freedesktop.org/show_bug.cgi?id=91350
commit bf9fd235b99f8222e50553d62fada1751afdd280
Author: Lukas Venhoda <lvenhoda at redhat.com>
Date: Wed Dec 16 15:51:11 2015 +0100
dcc: Don't disconnect channel, when compression is not supported
Don't disconnect the display channel, when unsupported compression is
requested from the client. Not changing the compression is enough.
https://bugs.freedesktop.org/show_bug.cgi?id=92821
Acked-by: Victor Toso <victortoso at redhat.com>
Acked-by: Frediano Ziglio <fziglio at redhat.com>
commit b172850200ccc70103c47c792aea4c8e7e3a8908
Author: Pavel Grunt <pgrunt at redhat.com>
Date: Thu Nov 5 16:25:55 2015 +0100
spicevmc: Return early when instance has no device state
Same approach as in spice_server_char_device_wakeup().
Avoid segmentation fault when the webdav channel (spice port channel) is
used with the vnc display:
#0 0x00007ffff7aab734 in spice_char_device_state_opaque_get (dev=0x0)
at char_device.c:720
#1 0x00007ffff7b0850c in spice_server_port_event (sin=<optimized out>, event=<optimized out>) at spicevmc.c:578
#2 0x0000555555787ba4 in set_guest_connected (port=<optimized out>, guest_connected=1) at hw/char/virtio-console.c:89
#3 0x0000555555678d7c in control_out (len=<optimized out>, buf=0x55555775c3a0, vser=0x5555578d1540) at /home/pgrunt/RH/qemu/hw/char/virtio-serial-bus.c:404
#4 0x0000555555678d7c in control_out (vdev=0x5555578d1540, vq=0x555557941bc8)
at /home/pgrunt/RH/qemu/hw/char/virtio-serial-bus.c:441
#5 0x000055555588eb98 in aio_dispatch (ctx=0x5555562e1a50) at aio-posix.c:160
#6 0x00005555558829ee in aio_ctx_dispatch (source=<optimized out>, callback=<optimized out>, user_data=<optimized out>) at async.c:226
#7 0x00007ffff2010e3a in g_main_context_dispatch () at /lib64/libglib-2.0.so.0
#8 0x000055555588d8fb in main_loop_wait () at main-loop.c:211
#9 0x000055555588d8fb in main_loop_wait (timeout=<optimized out>)
at main-loop.c:256
#10 0x000055555588d8fb in main_loop_wait (nonblocking=<optimized out>)
at main-loop.c:504
#11 0x000055555561b664 in main () at vl.c:1891
commit a21410330d922bda4cbe7a1850085c8aaae92c8b
Author: Pavel Grunt <pgrunt at redhat.com>
Date: Fri Nov 13 09:14:29 2015 +0100
reds: Do not abort due to wrong header
Just prevent the buggy client from connecting.
#0 0x00007fffe83b2a98 in raise () at /lib64/libc.so.6
#1 0x00007fffe83b469a in abort () at /lib64/libc.so.6
#2 0x00007ffff7b1533d in spice_logv (log_domain=0x7ffff7b87226 "Spice", log_level=SPICE_LOG_LEVEL_ERROR, strloc=0x7ffff7b92aba "reds.c:1373", function=0x7ffff7b94f40 <__FUNCTION__.31775> "reds_send_link_ack", format=0x7ffff7b871fe "assertion `%s' failed", args=args at entry=0x7fffffffcb68) at log.c:109
#3 0x00007ffff7b15468 in spice_log (log_domain=log_domain at entry=0x7ffff7b87226 "Spice", log_level=log_level at entry=SPICE_LOG_LEVEL_ERROR, strloc=strloc at entry=0x7ffff7b92aba "reds.c:1373", function=function at entry=0x7ffff7b94f40 <__FUNCTION__.31775> "reds_send_link_ack", format=format at entry=0x7ffff7b871fe "assertion `%s' failed") at log.c:123
#4 0x00007ffff7aee335 in reds_handle_read_link_done (link=0x555556b27c70)
at reds.c:1373
#5 0x00007ffff7aee335 in reds_handle_read_link_done (opaque=0x555556b27c70)
at reds.c:2139
#6 0x000055555588acc6 in qemu_iohandler_poll ()
#7 0x000055555588a8e1 in main_loop_wait ()
#8 0x0000555555614064 in main ()
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1281442
Acked-by: Fabiano Fidêncio <fidencio at redhat.com>
Acked-by: Frediano Ziglio <fziglio at redhat.com>
commit b50e45ed68937673402c6933f7c849b1dd02e941
Author: Marc-André Lureau <mlureau at redhat.com>
Date: Thu Dec 10 01:04:21 2015 +0100
build-sys: disable static lib by default
It's not used in general, so no need to build it by default.
Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
Acked-by: Frediano Ziglio <fziglio at redhat.com>
commit f92bb37fc46f79599b0c30f3a00b452d341fd17b
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Dec 16 14:37:13 2015 +0100
build: Remove unused SPICEC_STATIC_LINKAGE_BSTATIC
A left-over from the client code.
commit 8e60c5df3dee6b890a2f7fa8bdcae10efba1a071
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Dec 22 15:39:26 2015 +0000
replay: better help for -s option
-s accepts an option to delay command queueing.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Marc-André Lureau <mlureau at redhat.com>
commit f44a63b8ecf64e5baed8f69cb04eafebe06bfadb
Author: Jeremy White <jwhite at codeweavers.com>
Date: Tue Dec 8 09:11:08 2015 -0600
Flush display commands before validating the surface.
This fixes a display glitch in xspice which is caused when
a surface create is queued, but then a direct call to update
the area is issued. Unless we flush the queue, the surface
does not exist, and we fail.
Signed-off-by: Jeremy White <jwhite at codeweavers.com>
commit aa09f04717a7c29c29dd302717816b3a8eda3168
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Aug 4 16:05:38 2015 +0100
dcc: do not cause problem with multiple threads.
With multiple cards configured you can have multiple workers running in
different thread.
With such configuration static variables not syncronized could lead
to undefined behavior.
Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
commit 2862f0820d4d2c3257d98f48505743d171cf4bc0
Author: Marc-André Lureau <marcandre.lureau at gmail.com>
Date: Fri Nov 27 20:41:22 2015 +0100
smartcard: include libcacard.h if possible
Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
commit 4b82701b369344ecb83e7baa82d97e45d225b2d5
Author: Marc-André Lureau <marcandre.lureau at gmail.com>
Date: Sat Nov 21 01:55:16 2015 +0100
Add travis CI file
Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
commit ced752ac240421a71fb24f7b480f81baeefd8c1c
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Fri Dec 11 18:48:13 2015 +0100
Update spice-common
shortlog for the spice-common changes this brings in:
Christophe Fergeau (3):
build-sys: Add missing # to comment
ssl-verify: Handle NULL return from g_inet_address_new_from_string()
ssl-verify: Don't leak GInetAddress
Francois Gouget (3):
build-sys: Add the SPICE_WARNING() and SPICE_PRINT_MESSAGES m4 macros
build-sys: Add SPICE_CHECK_GSTREAMER()
build-sys: Add SPICE_CHECK_GSTREAMER_ELEMENTS()
Lukas Venhoda (1):
canvas_base: Remove redundant switch case block
Marc-André Lureau (2):
Fix make distcheck
Use new libcacard.h if possible
commit bfa5e5ce40d8aecc72d038ae9c85fd587fb1572a
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Fri Oct 16 17:29:46 2015 +0200
build-sys: Adjust to new spice-common spice-deps.m4
This commit also updates the spice-common submodule
Christophe Fergeau (7):
Add marshaller test case
build-sys: Use ${PKG_CONFIG} rather than pkg-config
build-sys: Rework SPICE_CHECK_* m4 macros
build-sys: Add gio-2.0 to SPICE_CHECK_GLIB2
build-sys: Fix error in SPICE_CHECK_LZ4 description
build-sys: Set automake conditional in SPICE_CHECK_SMARTCARD
build-sys: Rename SUPPORT_GL to HAVE_GL
Javier Celaya (1):
Fix linearization of several marshallers with one item
Lukas Venhoda (3):
ssl-verify: Only check addr length when using IP addr
m4: Require glib version >= 2.22
ssl-verify: Changed IPv4 hostname to IPv6
commit 337108469dba379e2504da831bfe11a0985038ae
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Oct 14 13:18:35 2015 +0100
remove small leak in MJPEG code
cinfo.dest is allocated in spice_jpeg_mem_dest but never freed.
Note that jpeg_destroy_compress does not free this field as is
supposed to be a buffer provided by jpeg caller.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 7c5e5b02bad215c24ff9ec5384014f1016c5334b
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Oct 7 17:22:50 2015 +0200
Add missing license headers
commit c0639738b4bf36895db616a6fa7bcda5bf41afac
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Oct 7 17:22:39 2015 +0200
syntax-check: Exclude png files from sc_prohibit_empty_lines_at_EOF
commit 6564806e4f4727f7389ee0297f18e5722844710e
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Oct 7 15:57:59 2015 +0200
syntax-check: Clean-up exception rules
Some files no longer exists, some exceptions are no longer needed, ...
commit ecb2428adbbcec60dca23193309c4cb6bc3843af
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Oct 7 17:16:56 2015 +0200
syntax-check: Remove unused #include <strings.h>
commit 80c3b866ffe819a71c878166bbc3608ae281f31a
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Oct 7 17:16:25 2015 +0200
syntax-check: Add missing #include <config.h>
commit bb165ac3ab00d9739a00938d7ff054cd8089b614
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Oct 7 17:15:51 2015 +0200
syntax-check: Don't use tabs for indentation
commit 5228cd2a31773482beead4d07f9538dac3913f0d
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Thu Oct 8 10:06:17 2015 +0200
syntax-check: Exclude red_replay_qxl.c from sc_cast_of_argument_to_free
red_replay_qxl.c stores some pointers QXLPHYSICAL data members (ie
uint64_t), and then needs to free them, so the cast is required.
commit 0ef10ddfdaffcb362a22009cacac8d672aaade23
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Oct 7 17:15:02 2015 +0200
syntax-check: Ignore .png files in sc_trailing_blank test
commit 2739738c9d77c6812805e497fc83e231c3fe6b58
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Oct 7 17:14:44 2015 +0200
syntax-check: manual: Remove duplicate word
commit e5c606998d7ad2fdce09867735749eef4c71ab33
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Wed Oct 7 17:14:33 2015 +0200
syntax-check: Add missing AUTHORS
commit b3898b486161f8164f307e76d5cdc759f1f13222
Author: snir sheriber <ssheribe at redhat.com>
Date: Sun Oct 18 10:51:56 2015 +0300
fix spelling mistakes in comments (reseting to resetting & dummym to dummy)
Acked-by: Frediano Ziglio <fziglio at redhat.com>
commit 9e88d6656575757ccbb1bfef1ffe457673610a82
Author: Jeremy White <jwhite at codeweavers.com>
Date: Thu Oct 15 15:29:12 2015 -0500
Update the .gitignore files for the new manual,
for a few newly generated tests, and for the spice-server.h.
More information about the Spice-commits
mailing list