[Spice-commits] 6 commits - configure.ac docs/spice_style.txt

[Frediano Ziglio]

 configure.ac         |    2 +-
 docs/spice_style.txt |   21 +++++++--------------
 2 files changed, 8 insertions(+), 15 deletions(-)

New commits:
commit 448f037a3c9e6df9ba497cf1f8e95d86f15ca91b
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Wed May 11 10:40:40 2016 +0100

    style: use capital case for C language
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Pavel Grunt <pgrunt at redhat.com>

diff --git a/configure.ac b/configure.ac
index d789fbc..c743875 100644
--- a/configure.ac
+++ b/configure.ac
@@ -236,7 +236,7 @@ AC_MSG_NOTICE([
         ==============
 
         prefix:                   ${prefix}
-        c compiler:               ${CC}
+        C compiler:               ${CC}
 
         LZ4 support:              ${enable_lz4}
         Smartcard:                ${have_smartcard}
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 90d7dc5..7de4a43 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -80,7 +80,7 @@ Use const keyword when applicable to improve code reliability and celerity.
 goto
 ----
 
-Using goto is allowed in c code for error handling. In any other case it will be used only as a special exception.
+Using goto is allowed in C code for error handling. In any other case it will be used only as a special exception.
 
 Defining Constant values
 ------------------------
commit 0149b3794666408d0f3a38c78fee5622b69ec046
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Wed May 11 10:39:39 2016 +0100

    style: remove outdated void argument
    
    For C is better to have void instead of arguments as otherwise
    K&R rules apply.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Pavel Grunt <pgrunt at redhat.com>

diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 683c53c..90d7dc5 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -87,11 +87,6 @@ Defining Constant values
 
 Use defines for constant values for improving readability and ease of changes. Alternatively, use global `const` variables.
 
-void argument
--------------
-
-Don't add explicitly void argument in functions without arguments. (i.e., void function_name() is OK)
-
 Short functions
 ---------------
 
commit 04c238e09e13a2557a03f41de5236fe6a6dc17d0
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Wed May 11 10:38:27 2016 +0100

    style: update file name style
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Pavel Grunt <pgrunt at redhat.com>

diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index bc12cb1..683c53c 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -12,7 +12,7 @@ Source Files
 Names
 ~~~~~
 
-Use lower case and separate words using underscore (e.g., file_name.c, header.h).
+Use lower case and separate words using dashes (e.g., file-name.c, header.h).
 
 Use standard file extension for C source and header files.
 
commit fb336b8a1c99ae44b894381d29bd7b8d3d6d5b52
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Wed May 11 10:38:07 2016 +0100

    style: update copyright lines
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Pavel Grunt <pgrunt at redhat.com>

diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 80f5ad0..bc12cb1 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -1,9 +1,7 @@
 Spice project coding style and coding conventions
 =================================================
 
-Draft 2
-
-Copyright (C) 2009 Red Hat, Inc.
+Copyright (C) 2009-2016 Red Hat, Inc.
 Licensed under a Creative Commons Attribution-Share Alike 3.0
 United States License (see http://creativecommons.org/licenses/by-sa/3.0/us/legalcode).
 
commit 586a07a2d3ba5a6aa7df159a3ae97683c12448f2
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Wed May 11 10:28:52 2016 +0100

    style: fix condition indentation example
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Pavel Grunt <pgrunt at redhat.com>

diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index e4328fc..80f5ad0 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -214,12 +214,12 @@ if (long_name && very_long_name && very_long ||
                                                var_name) {
 ----
 +
-or indent using two tabs
+or indent under the round bracket using spaces
 +
 [source,c]
 ----
 if (long_name && very_long_name && long_name ||
-        var_name) {
+    var_name) {
 ----
 +
 Break function arguments list in long condition statement according to <<function_indentation, Function Indentation>> section.
commit a3871e62a773f7f52c15b90cb009a7ec4a64cc48
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Wed May 11 10:28:13 2016 +0100

    style: we are now using capital FIXME and TODO
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Pavel Grunt <pgrunt at redhat.com>

diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 8966365..e4328fc 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -59,10 +59,10 @@ Static storage initialization
 
 To improve code readability, explicitly initialize variables that depend on default initialization with zero/null.
 
-Fixme and todo
+FIXME and TODO
 --------------
 
-Comments that are prefixed with `fixme` describe a bug that need to be fixed. Generally, it is not allowed to commit new code having `fixme` comment. Committing  `fixme` is allowed only for existing bugs. Comments that are prefixed with `todo` describe further features, optimization or code improvements, and they are allowed to be committed along with the relevant code.
+Comments that are prefixed with `FIXME` describe a bug that need to be fixed. Generally, it is not allowed to commit new code having `FIXME` comment. Committing  `FIXME` is allowed only for existing bugs. Comments that are prefixed with `TODO` describe further features, optimization or code improvements, and they are allowed to be committed along with the relevant code.
 
 ASSERT
 ------