[Spice-commits] server/red-worker.c

Frediano Ziglio fziglio at kemper.freedesktop.org
Thu Sep 22 08:10:42 UTC 2016


 server/red-worker.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

New commits:
commit d06fd6a2f9a21ef6d6dde1e1e93233fcff84c473
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Fri Sep 16 22:08:18 2016 +0100

    worker: Do not check surface twice
    
    validate_surface already do the same checks.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Jonathon Jongsma <jjongsma at redhat.com>

diff --git a/server/red-worker.c b/server/red-worker.c
index 27ab8a2..a2cd2e8 100644
--- a/server/red-worker.c
+++ b/server/red-worker.c
@@ -662,15 +662,11 @@ static void destroy_primary_surface(RedWorker *worker, uint32_t surface_id)
 {
     DisplayChannel *display = worker->display_channel;
 
-    if (!display_channel_validate_surface(display, surface_id))
-        return;
-    spice_warn_if_fail(surface_id == 0);
-
-    spice_debug(NULL);
-    if (!display_channel_surface_has_canvas(display, surface_id)) {
+    if (!display_channel_validate_surface(display, surface_id)) {
         spice_warning("double destroy of primary surface");
         return;
     }
+    spice_warn_if_fail(surface_id == 0);
 
     flush_all_qxl_commands(worker);
     display_channel_destroy_surface_wait(display, 0);


More information about the Spice-commits mailing list