[Spice-commits] 3 commits - server/gstreamer-encoder.c server/spice-bitmap-utils.c server/tests

[Frediano Ziglio]

 server/gstreamer-encoder.c  |    2 ++
 server/spice-bitmap-utils.c |    4 ++++
 server/tests/test-gst.c     |    2 ++
 server/tests/video-encoders |    2 +-
 4 files changed, 9 insertions(+), 1 deletion(-)

New commits:
commit dfe9fe9ebe4b764dde19dda89e4a1c9cd1bb1db9
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Fri Apr 7 12:09:51 2017 +0100

    test: Add vp9 support to GStreamer test
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Christophe Fergeau <cfergeau at redhat.com>

diff --git a/server/tests/test-gst.c b/server/tests/test-gst.c
index 82b9594e..d4ebaacf 100644
--- a/server/tests/test-gst.c
+++ b/server/tests/test-gst.c
@@ -300,6 +300,8 @@ static const EncoderInfo encoder_infos[] = {
       "caps=image/jpeg", "jpegdec" },
     { "gstreamer:vp8",   gstreamer_encoder_new, SPICE_VIDEO_CODEC_TYPE_VP8,
       "caps=video/x-vp8", "vp8dec" },
+    { "gstreamer:vp9",   gstreamer_encoder_new, SPICE_VIDEO_CODEC_TYPE_VP9,
+      "caps=video/x-vp9", "vp9dec" },
     { "gstreamer:h264",  gstreamer_encoder_new, SPICE_VIDEO_CODEC_TYPE_H264,
 #ifdef HAVE_GSTREAMER_0_10
       "", "h264parse ! ffdec_h264" },
diff --git a/server/tests/video-encoders b/server/tests/video-encoders
index ca955c7d..039dd219 100755
--- a/server/tests/video-encoders
+++ b/server/tests/video-encoders
@@ -11,7 +11,7 @@ base_test() {
 # note that due to some internal alignment we are using odd number for sizes
 for clipping in '' '--clipping (10%,10%)x(409,307)'
 do
-    for encoder in mjpeg 'gstreamer:mjpeg --min-psnr 16' gstreamer:vp8 gstreamer:h264
+    for encoder in mjpeg 'gstreamer:mjpeg --min-psnr 16' gstreamer:vp8 gstreamer:vp9 gstreamer:h264
     do
         for split in '' '--split-lines=40'
         do
commit e9035e52390a0527bc0d6b5952c1fe5f9a04a1a9
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Fri Mar 24 12:10:59 2017 +0000

    Attempt to create bitmap debug directory
    
    The DUMP_BITMAP compile option enable some debugging code to
    output image bitmaps in a subdirectory of /tmp.
    However if this directory does not exists the server will crash
    as not able to create a file in it.
    Try to create directory before creating the file.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Christophe Fergeau <cfergeau at redhat.com>

diff --git a/server/spice-bitmap-utils.c b/server/spice-bitmap-utils.c
index 439f05da..09c081df 100644
--- a/server/spice-bitmap-utils.c
+++ b/server/spice-bitmap-utils.c
@@ -18,6 +18,9 @@
 #ifdef HAVE_CONFIG_H
 #include <config.h>
 #endif
+
+#include <sys/stat.h>
+
 #include "spice-bitmap-utils.h"
 
 #define RED_BITMAP_UTILS_RGB16
@@ -252,6 +255,7 @@ void dump_bitmap(SpiceBitmap *bitmap)
     file_size = bitmap_data_offset + (bitmap->y * row_size);
 
     id = ++file_id;
+    mkdir(RAM_PATH, 0755);
     sprintf(file_str, "%s/%u.bmp", RAM_PATH, id);
 
     f = fopen(file_str, "wb");
commit 4725ec03b1bbfc002f53f1e6467a8f28a4cb8dcd
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Fri Apr 7 13:21:49 2017 +0100

    gstreamer: Remove some leaks if pipeline cannot be created
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Pavel Grunt <pgrunt at redhat.com>

diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
index 1ce8d58a..bb4f27ba 100644
--- a/server/gstreamer-encoder.c
+++ b/server/gstreamer-encoder.c
@@ -1745,6 +1745,8 @@ VideoEncoder *gstreamer_encoder_new(SpiceVideoCodecType codec_type,
 
     if (!create_pipeline(encoder)) {
         /* Some GStreamer dependency is probably missing */
+        pthread_cond_destroy(&encoder->outbuf_cond);
+        pthread_mutex_destroy(&encoder->outbuf_mutex);
         free(encoder);
         encoder = NULL;
     }