[Spice-commits] server/red-worker.c

Frediano Ziglio fziglio at kemper.freedesktop.org
Fri Aug 25 15:08:01 UTC 2017


 server/red-worker.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 23fd55948bc5b862397804096606d1dac27bc322
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Thu Aug 24 14:30:20 2017 +0100

    red-worker: Remove small memory leak
    
    If a DisplayChannelClient cannot be instantiated capabilities
    are not released correctly.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Christophe Fergeau <cfergeau at redhat.com>

diff --git a/server/red-worker.c b/server/red-worker.c
index 03a409cd..8fd964ea 100644
--- a/server/red-worker.c
+++ b/server/red-worker.c
@@ -724,14 +724,13 @@ static void handle_dev_display_connect(void *opaque, void *payload)
 
     dcc = dcc_new(display, msg->client, msg->stream, msg->migration, &msg->caps,
                   worker->image_compression, worker->jpeg_state, worker->zlib_glz_state);
+    red_channel_capabilities_reset(&msg->caps);
     if (!dcc) {
         return;
     }
     display_channel_update_compression(display, dcc);
     guest_set_client_capabilities(worker);
     dcc_start(dcc);
-
-    red_channel_capabilities_reset(&msg->caps);
 }
 
 static void handle_dev_display_disconnect(void *opaque, void *payload)


More information about the Spice-commits mailing list