[Spice-commits] 2 commits - data/org.spicespace.spicy.json src/channel-inputs.c

[Pavel Grunt]

 data/org.spicespace.spicy.json |   71 +++++++++++++++++++++++++++++++++++++++++
 src/channel-inputs.c           |    6 +--
 2 files changed, 73 insertions(+), 4 deletions(-)

New commits:
commit 64a0eeab8ddd2ca6b2d3b57b7f46e99877bfab7e
Author: Pavel Grunt <pgrunt at redhat.com>
Date:   Fri Jul 21 11:02:57 2017 +0200

    Add flatpak builder manifest file for spicy
    
    To give an example for creating flatpaks depending on spice-gtk
    
    How to build and run the flatpak:
    spicy uses GNOME SDK runtime, version 3.24. The runtime provides tools
    and libraries necessary to build the flatpak
     $ flatpak remote-add --if-not-exists gnome https://sdk.gnome.org/gnome.flatpakrepo
     $ flatpak install gnome org.gnome.Sdk//3.24
    
    To build and run the flatpak of spicy:
     $ flatpak-builder spicy data/org.spicespace.spicy.json
     $ flatpak build-export repo spicy
     $ flatpak --user remote-add --no-gpg-verify --if-not-exists spice-repo repo
     $ flatpak --user install spice-repo org.spicespace.spicy
     $ flatpak run org.spicespace.spicy
    Acked-by: Christophe Fergeau <cfergeau at redhat.com>

diff --git a/data/org.spicespace.spicy.json b/data/org.spicespace.spicy.json
new file mode 100644
index 0000000..1e03bf9
--- /dev/null
+++ b/data/org.spicespace.spicy.json
@@ -0,0 +1,71 @@
+{
+    "app-id": "org.spicespace.spicy",
+    "runtime": "org.gnome.Platform",
+    "runtime-version": "3.24",
+    "sdk": "org.gnome.Sdk",
+    "command": "spicy",
+    "tags": ["devel", "development", "nightly"],
+        "finish-args": [
+        "--share=ipc", "--socket=x11",
+        "--socket=wayland",
+        "--socket=pulseaudio",
+        "--share=network"
+    ],
+    "modules": [
+        {
+            "name": "python-six",
+            "buildsystem": "simple",
+            "build-commands": [
+                "pip3 install --target=/app six-1.10.0-py2.py3-none-any.whl"
+            ],
+            "sources": [
+                {
+                   "type": "file",
+                   "url": "https://pypi.python.org/packages/c8/0a/b6723e1bc4c516cb687841499455a8505b44607ab535be01091c0f24f079/six-1.10.0-py2.py3-none-any.whl#md5=3ab558cf5d4f7a72611d59a81a315dc8",
+                   "sha256": "0ff78c403d9bccf5a425a6d31a12aa6b47f1c21ca4dc2573a7e2f32a97335eb1"
+                }
+            ]
+        },
+        {
+            "name": "pyparsing",
+            "buildsystem": "simple",
+            "build-commands": [
+                "pip3 install --target=/app pyparsing-2.0.3-py2.py3-none-any.whl"
+            ],
+            "sources": [
+                {
+                    "type": "file",
+                    "url": "https://pypi.python.org/packages/8f/f4/3a70b5e5b865b1ec45fe48dc5a57cd4facb5c7bd80e5cb1255c362732e81/pyparsing-2.0.3-py2.py3-none-any.whl#md5=4c16ef222caea2e5de741ae503aae652",
+                    "sha256": "a9c896bab06dbf3759ad5fb63cfdb3777191e2c4ae640e6dd69ed37530f6ba56"
+                }
+            ]
+        },
+        {
+            "builddir": true,
+            "name": "spice-protocol",
+            "sources": [
+                {
+                    "type": "git",
+                    "url": "git://anongit.freedesktop.org/spice/spice-protocol"
+                }
+            ]
+        },
+        {
+            "builddir": true,
+            "name": "spice-gtk",
+            "build-options": {
+                "env": {
+                    "PYTHONPATH": "/app"
+                }
+            },
+            "config-opts": [ "--disable-controller", "--disable-vala",
+                             "--disable-gtk-doc", "--enable-python-checks" ],
+            "sources": [
+                {
+                    "type": "git",
+                    "url": "git://anongit.freedesktop.org/spice/spice-gtk"
+                }
+            ]
+        }
+    ]
+}
commit c57c57a40c2d06e728b7f0f7e2a6cdf64f320fd0
Author: Pavel Grunt <pgrunt at redhat.com>
Date:   Tue Jul 11 13:34:12 2017 +0200

    Revert "Ignore modifiers messages if no modifiers changed"
    
    This reverts commit 73cd553fb0fbd213b64d72f8b4289ed8a17fc6c0.
     "This avoid keep sending modifiers changes if guest is not
      synchronising the changes.
    
      I consider this as an improving as this avoids client to try again
      and again to force synchronisation however this does not prevent
      every unwanted keystroke insertion which possibly can be a real
      problem on some configurations.
    
      For instance if guest do not handle caps lock as the client do
      if client uses another modifiers (as num lock) this can force
      inserting virtual caps keypress."
    
    It may be an optimization, but it complicates turning off
    the capslock once it is enabled. The bug is reproducible
    in rhel7/fedora guests.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=101344
    Acked-by: Victor Toso <victortoso at redhat.com>

diff --git a/src/channel-inputs.c b/src/channel-inputs.c
index f79bc38..7572bff 100644
--- a/src/channel-inputs.c
+++ b/src/channel-inputs.c
@@ -242,10 +242,8 @@ static void inputs_handle_modifiers(SpiceChannel *channel, SpiceMsgIn *in)
     SpiceInputsChannelPrivate *c = SPICE_INPUTS_CHANNEL(channel)->priv;
     SpiceMsgInputsKeyModifiers *modifiers = spice_msg_in_parsed(in);
 
-    if (c->modifiers != modifiers->modifiers) {
-        c->modifiers = modifiers->modifiers;
-        g_coroutine_signal_emit(channel, signals[SPICE_INPUTS_MODIFIERS], 0);
-    }
+    c->modifiers = modifiers->modifiers;
+    g_coroutine_signal_emit(channel, signals[SPICE_INPUTS_MODIFIERS], 0);
 }
 
 /* coroutine context */