[Spice-commits] src/spice-gstaudio.c

[Victor Toso de Carvalho]

 src/spice-gstaudio.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 808ac1d9b3fd926f660231776d5c66946fda5664
Author: Victor Toso <me at victortoso.com>
Date:   Wed Mar 8 15:22:21 2017 +0100

    gstaudio: Remove fixed TODOs about setting record volume
    
    * directsoundsrc doesn't support IDirectSoundBuffer_SetVolume
    
    This was fixed by 1b564bfb8b0db in gst-plugins-bad, see:
    https://bugzilla.gnome.org/show_bug.cgi?id=744383
    
    * pulsesrc doesn't support volume property, it's all coming!
    
    This was fixed by 1f4bb687940f87a0 in gst-plugins-good, see:
    https://bugzilla.gnome.org/show_bug.cgi?id=595055
    
    Signed-off-by: Victor Toso <victortoso at redhat.com>
    Acked-by: Pavel Grunt <pgrunt at redhat.com>

diff --git a/src/spice-gstaudio.c b/src/spice-gstaudio.c
index 1d96c77..014c3a5 100644
--- a/src/spice-gstaudio.c
+++ b/src/spice-gstaudio.c
@@ -430,9 +430,6 @@ static void record_volume_changed(GObject *object, GParamSpec *pspec, gpointer d
     vol = 1.0 * volume[0] / VOLUME_NORMAL;
     SPICE_DEBUG("record volume changed to %u (%0.2f)", volume[0], 100*vol);
 
-    /* TODO directsoundsrc doesn't support IDirectSoundBuffer_SetVolume */
-    /* TODO pulsesrc doesn't support volume property, it's all coming! */
-
     if (GST_IS_BIN(p->record.src))
         e = gst_bin_get_by_interface(GST_BIN(p->record.src), GST_TYPE_STREAM_VOLUME);
     else
@@ -441,7 +438,7 @@ static void record_volume_changed(GObject *object, GParamSpec *pspec, gpointer d
     if (GST_IS_STREAM_VOLUME(e))
         gst_stream_volume_set_volume(GST_STREAM_VOLUME(e), GST_STREAM_VOLUME_FORMAT_CUBIC, vol);
     else
-        g_warning("gst lacks volume capabilities on src (TODO)");
+        g_warning("gst lacks volume capabilities on src");
 
     g_object_unref(e);
 }
@@ -467,7 +464,7 @@ static void record_mute_changed(GObject *object, GParamSpec *pspec, gpointer dat
     if (GST_IS_STREAM_VOLUME (e))
         gst_stream_volume_set_mute(GST_STREAM_VOLUME(e), mute);
     else
-        g_warning("gst lacks mute capabilities on src: %d (TODO)", mute);
+        g_warning("gst lacks mute capabilities on src: %d", mute);
 
     g_object_unref(e);
 }