[Spice-commits] src/spice-widget.c

Frediano Ziglio fziglio at kemper.freedesktop.org
Mon Apr 23 08:04:50 UTC 2018

 src/spice-widget.c |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 216065cc98eb12d4c71624f536034cd60d35c328
Author: Victor Toso <me at victortoso.com>
Date:   Wed Apr 4 17:31:11 2018 +0200

    spice-widget: remove old warning
    This log was introduced in 13f5ebbf07a3 to track the situation where
    the GdkCursor pointer would be invalid/NULL. That was possible if the
    caller passed a NULL for rgba pointer in cursor_set().
    Code has changed a bit since then, it isn't necessary to log a warn in
    the unlikely event of cursor_shape being NULL.
    Signed-off-by: Victor Toso <victortoso at redhat.com>
    Reported-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Frediano Ziglio <fziglio at redhat.com>

diff --git a/src/spice-widget.c b/src/spice-widget.c
index 5abc119..73db593 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2659,7 +2659,6 @@ static void cursor_set(SpiceCursorChannel *channel,
     g_object_get(G_OBJECT(channel), "cursor", &cursor_shape, NULL);
     if (G_UNLIKELY(cursor_shape == NULL || cursor_shape->data == NULL)) {
-        g_warn_if_reached();
         if (cursor_shape != NULL) {
             g_boxed_free(SPICE_TYPE_CURSOR_SHAPE, cursor_shape);

More information about the Spice-commits mailing list