[Spice-commits] 2 commits - .gitlab-ci.yml server/glz-encoder-dict.c

[GitLab Mirror]

 .gitlab-ci.yml            |   19 +++++++++++++++++++
 server/glz-encoder-dict.c |    3 ++-
 2 files changed, 21 insertions(+), 1 deletion(-)

New commits:
commit c778c7ce93652b93f7f5a810607e7f69ea120d4d
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Tue Jul 10 21:03:48 2018 +0100

    glz-encoder-dict: Remove a warning compiling with CentOS 7
    
    CentOS 7 compiler generate this warning:
    
    glz-encoder-dict.c: In function 'glz_dictionary_pre_encode':
    glz-encoder-dict.c:516:30: error: 'prev_seg_id' may be used uninitialized in this function [-Werror=maybe-uninitialized]
                 dict->window.segs[prev_seg_id].next = seg_id;
                                  ^
    glz-encoder-dict.c:492:22: note: 'prev_seg_id' was declared here
         uint32_t seg_id, prev_seg_id;
                          ^
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Christophe Fergeau <cfergeau at redhat.com>

diff --git a/server/glz-encoder-dict.c b/server/glz-encoder-dict.c
index 4b0a422a..2a01641f 100644
--- a/server/glz-encoder-dict.c
+++ b/server/glz-encoder-dict.c
@@ -489,7 +489,8 @@ static WindowImage *glz_dictionary_window_add_image(SharedDictionary *dict, LzIm
 {
     unsigned int num_lines = num_first_lines;
     unsigned int row;
-    uint32_t seg_id, prev_seg_id;
+    uint32_t seg_id;
+    uint32_t prev_seg_id = 0;
     uint8_t* lines = first_lines;
     // alloc image info,update used head tail,  if used_head null - update  head
     WindowImage *image = __glz_dictionary_window_alloc_image(dict);
commit 65eca77c81c35fec6ef57e28849ac2fe05d023ac
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Wed Jun 20 18:19:25 2018 +0100

    ci: Run an additional make check using Centos
    
    Make sure we can compile and run base tests using latest Centos.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Christophe Fergeau <cfergeau at redhat.com>

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index becdb28b..50fb7a15 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -50,3 +50,22 @@ distcheck:
   script:
   - ./autogen.sh --enable-celt051 --enable-manual
   - make distcheck
+
+# Same as makecheck job but use a Centos image
+makecheck-centos:
+  before_script:
+    - >
+      yum install git libtool make libasan orc-devel
+      python3 python3-six python3-pyparsing glib-networking
+      yum-utils yum-plugin-copr
+      -y
+    - yum copr enable @spice/nightly -y
+    - yum-builddep spice -y
+  image: centos:latest
+  script:
+  - >
+    CFLAGS='-O2 -pipe -g -fsanitize=address -fno-omit-frame-pointer -Wframe-larger-than=40920'
+    LDFLAGS='-fsanitize=address -lasan'
+    ./autogen.sh --enable-celt051
+  - make
+  - make -C server check || (cat server/tests/test-suite.log && exit 1)