[Spice-commits] src/spice-gstaudio.c

[GitLab Mirror]

 src/spice-gstaudio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f18589bc933e2d383f5cd2e7f3bfbc00c09b1150
Author: Marc-André Lureau <marcandre.lureau at redhat.com>
Date:   Sat Jan 5 18:09:01 2019 +0400

    gstaudio: set state to NULL before unref
    
    (lt-spicy:13097): GStreamer-CRITICAL **: 18:01:13.698:
    Trying to dispose element pipeline1, but it is in READY instead of the NULL state.
    You need to explicitly set elements to the NULL state before
    dropping the final reference, to allow them to clean up.
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
    Acked-by: Snir Sheriber <ssheribe at redhat.com>

diff --git a/src/spice-gstaudio.c b/src/spice-gstaudio.c
index aff69d2..d0cfbc6 100644
--- a/src/spice-gstaudio.c
+++ b/src/spice-gstaudio.c
@@ -191,7 +191,7 @@ static void record_start(SpiceRecordChannel *channel, gint format, gint channels
     if (p->record.pipe &&
         (p->record.rate != frequency ||
          p->record.channels != channels)) {
-        record_stop(gstaudio);
+        gst_element_set_state(p->record.pipe, GST_STATE_NULL);
         g_clear_pointer(&p->record.pipe, gst_object_unref);
     }