[Spice-commits] 3 commits - server/tests
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Jul 18 14:56:43 UTC 2019
server/tests/Makefile.am | 2
server/tests/valgrind/glib.supp | 207 ++++++++++++++++++++++++++++++++++++---
server/tests/valgrind/spice.supp | 57 ++++++++++
3 files changed, 251 insertions(+), 15 deletions(-)
New commits:
commit 2ababd61771ad6f2ab2310ecd7d31c5bf6ca8d46
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Jul 17 14:34:14 2019 +0100
ci: Add some Valgrind suppressions for Fedora 30
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Uri Lublin <uril at redhat.com>
diff --git a/server/tests/valgrind/spice.supp b/server/tests/valgrind/spice.supp
index 1bfe8100..aa64b61b 100644
--- a/server/tests/valgrind/spice.supp
+++ b/server/tests/valgrind/spice.supp
@@ -36,3 +36,22 @@
...
fun:p11_kit_modules_load
}
+
+{
+ gnutls_x509_ext_import_subject_alt_names
+ Memcheck:Cond
+ ...
+ fun:gnutls_x509_ext_import_subject_alt_names
+ fun:gnutls_x509_crt_import
+ fun:gnutls_x509_trust_list_iter_get_ca
+}
+
+{
+ glib_g_socket_client_class_init
+ Memcheck:Leak
+ fun:calloc
+ ...
+ fun:type_class_init_Wm
+ ...
+ fun:g_socket_client_class_init
+}
commit d2979e23e96598f4fd3058ea66c30e9659c1dfe4
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Jul 18 08:19:04 2019 +0100
ci: Update glib.supp file
Sync with Glib master file.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Uri Lublin <uril at redhat.com>
diff --git a/server/tests/valgrind/glib.supp b/server/tests/valgrind/glib.supp
index 9236b3d1..ddc2b172 100644
--- a/server/tests/valgrind/glib.supp
+++ b/server/tests/valgrind/glib.supp
@@ -201,10 +201,20 @@
}
{
- g-type-class-init
+ g-type-class-init-calloc
Memcheck:Leak
fun:calloc
...
+ fun:g_type_create_instance
+ ...
+ fun:type_class_init_Wm
+}
+
+{
+ g-type-class-init
+ Memcheck:Leak
+ fun:g_type_create_instance
+ ...
fun:type_class_init_Wm
}
@@ -219,6 +229,26 @@
}
{
+ g-io-module-default-singleton-calloc
+ Memcheck:Leak
+ fun:calloc
+ ...
+ fun:g_type_create_instance
+ ...
+ fun:_g_io_module_get_default
+}
+
+# This one seems to show up sometimes with g_type_create_instance() at the top
+# of the stack, as well.
+{
+ g-io-module-default-singleton
+ Memcheck:Leak
+ fun:g_type_create_instance
+ ...
+ fun:_g_io_module_get_default
+}
+
+{
g-io-module-default-singleton-module
Memcheck:Leak
fun:calloc
@@ -229,7 +259,17 @@
}
{
- g-get-language-names
+ g-io-module-default-singleton-name
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:g_strdup
+ ...
+ fun:_g_io_module_get_default*
+}
+
+{
+ g-get-language-names-malloc
Memcheck:Leak
fun:malloc
...
@@ -237,6 +277,14 @@
}
{
+ g-get-language-names-calloc
+ Memcheck:Leak
+ fun:calloc
+ ...
+ fun:g_get_language_names
+}
+
+{
g-static-mutex
Memcheck:Leak
fun:malloc
@@ -543,3 +591,173 @@
...
fun:g_object_new_valist
}
+
+# g_set_user_dirs() deliberately leaks the previous cached g_get_user_*() values.
+{
+ g_set_user_dirs_str
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:set_str_if_different
+ fun:g_set_user_dirs
+}
+
+# g_set_user_dirs() deliberately leaks the previous cached g_get_user_*() values.
+{
+ g_set_user_dirs_strv
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:set_strv_if_different
+ fun:g_set_user_dirs
+}
+
+# g_get_system_data_dirs() caches a one-time allocation
+{
+ g_get_system_data_dirs
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:g_build_system_data_dirs
+ fun:g_get_system_data_dirs
+}
+
+# g_get_user_data_dir() caches a one-time allocation
+{
+ g_get_user_data_dir
+ Memcheck:Leak
+ fun:realloc
+ ...
+ fun:g_build_user_data_dir
+ fun:g_get_user_data_dir
+}
+
+# gdesktopappinfo.c caches a one-time allocation global table of @desktop_file_dirs.
+{
+ desktop_file_dirs_malloc
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:desktop_file_dirs_lock
+}
+
+# gdesktopappinfo.c caches a one-time allocation global table of @desktop_file_dirs.
+{
+ desktop_file_dirs_realloc
+ Memcheck:Leak
+ fun:realloc
+ ...
+ fun:desktop_file_dirs_lock
+}
+
+# gdesktopappinfo.c caches a one-time allocation global table of @desktop_file_dirs.
+{
+ desktop_file_dir_unindexed_setup_search
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:desktop_file_dir_unindexed_setup_search
+ fun:desktop_file_dir_unindexed_setup_search
+}
+
+# g_io_extension_point_register() caches a one-time allocation global table of @extension_points.
+{
+ g_io_extension_point_register
+ Memcheck:Leak
+ fun:calloc
+ ...
+ fun:g_io_extension_point_register
+}
+
+# g_strerror() caches a one-time allocation global table of @errors.
+{
+ g_strerror
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:g_locale_to_utf8
+ fun:g_strerror
+}
+
+# g_socket_connection_factory_register_type() caches a one-time allocation global table of @connection_types.
+{
+ g_socket_connection_factory_register_type
+ Memcheck:Leak
+ fun:calloc
+ ...
+ fun:g_socket_connection_factory_register_type
+}
+
+# g_dbus_error_quark() never unregisters itself as a GDBusError domain, as it’s always available
+{
+ g_dbus_error_quark
+ Memcheck:Leak
+ fun:calloc
+ ...
+ fun:g_dbus_error_register_error_domain
+ fun:g_dbus_error_quark
+}
+
+# Thread-private data allocated once per thread
+{
+ g_private_set_alloc0
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:g_private_set_alloc0
+}
+{
+ g_private_set_alloc0-calloc
+ Memcheck:Leak
+ fun:calloc
+ ...
+ fun:g_private_set_alloc0
+}
+
+# Thread-private GMainContext stack
+{
+ g_main_context_push_thread_default
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:g_queue_new
+ fun:g_main_context_push_thread_default
+}
+
+# One-time allocations for #GFileInfo attribute cache
+{
+ g_file_info_attribute_cache
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:ensure_attribute_hash
+ ...
+ fun:g_file_*
+}
+{
+ g_file_info_attribute_cache2
+ Memcheck:Leak
+ fun:calloc
+ ...
+ fun:ensure_attribute_hash
+ ...
+ fun:g_file_*
+}
+{
+ g_file_info_attribute_cache3
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:lookup_namespace
+ ...
+ fun:g_file_*
+}
+{
+ g_file_info_attribute_cache4
+ Memcheck:Leak
+ fun:calloc
+ ...
+ fun:lookup_namespace
+ ...
+ fun:g_file_*
+}
commit 911455ba6557f880d8196e704819a97696fb7531
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Jul 18 08:17:44 2019 +0100
ci: Separate SPICE specific Valgrind suppression
Previously we add suppression to glib.supp file (suppressions from
Glib).
Keep the glib.supp file pristine and add another file specific
for SPICE.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Uri Lublin <uril at redhat.com>
diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
index 26aadd5f..ccaf5c87 100644
--- a/server/tests/Makefile.am
+++ b/server/tests/Makefile.am
@@ -1,7 +1,7 @@
NULL =
@VALGRIND_CHECK_RULES@
-VALGRIND_SUPPRESSIONS_FILES = $(srcdir)/valgrind/glib.supp
+VALGRIND_SUPPRESSIONS_FILES = $(srcdir)/valgrind/glib.supp $(srcdir)/valgrind/spice.supp
EXTRA_DIST = \
$(VALGRIND_SUPPRESSIONS_FILES) \
meson.build \
diff --git a/server/tests/valgrind/glib.supp b/server/tests/valgrind/glib.supp
index ca0684d6..9236b3d1 100644
--- a/server/tests/valgrind/glib.supp
+++ b/server/tests/valgrind/glib.supp
@@ -543,42 +543,3 @@
...
fun:g_object_new_valist
}
-
-{
- px_proxy_factory_get_proxies
- Memcheck:Leak
- fun:malloc
- fun:tls_get_addr_tail
- ...
- fun:px_proxy_factory_get_proxies
-}
-
-{
- px_proxy_factory_get_proxies2
- Memcheck:Leak
- fun:malloc
- ...
- fun:__tls_get_addr
- ...
- fun:px_proxy_factory_get_proxies
-}
-
-{
- gnutls_tls_rnd_leak
- Memcheck:Leak
- fun:malloc
- ...
- fun:__tls_get_addr
- ...
- fun:gnutls_rnd
-}
-
-{
- gnutls_tls_p11_kit_leak
- Memcheck:Leak
- fun:malloc
- ...
- fun:__tls_get_addr
- ...
- fun:p11_kit_modules_load
-}
diff --git a/server/tests/valgrind/spice.supp b/server/tests/valgrind/spice.supp
new file mode 100644
index 00000000..1bfe8100
--- /dev/null
+++ b/server/tests/valgrind/spice.supp
@@ -0,0 +1,38 @@
+{
+ px_proxy_factory_get_proxies
+ Memcheck:Leak
+ fun:malloc
+ fun:tls_get_addr_tail
+ ...
+ fun:px_proxy_factory_get_proxies
+}
+
+{
+ px_proxy_factory_get_proxies2
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:__tls_get_addr
+ ...
+ fun:px_proxy_factory_get_proxies
+}
+
+{
+ gnutls_tls_rnd_leak
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:__tls_get_addr
+ ...
+ fun:gnutls_rnd
+}
+
+{
+ gnutls_tls_p11_kit_leak
+ Memcheck:Leak
+ fun:malloc
+ ...
+ fun:__tls_get_addr
+ ...
+ fun:p11_kit_modules_load
+}
More information about the Spice-commits
mailing list