[Spice-commits] AUTHORS server/tests

[GitLab Mirror]

 AUTHORS                         |    1 +
 server/tests/test-qxl-parsing.c |    2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 19f9f454e0777d851f26d14df0c7984267c57015
Author: Christian Ehrhardt <christian.ehrhardt at canonical.com>
Date:   Wed Jun 5 16:18:41 2019 +0200

    test: fix test-qxl-parsing on ppc64el and armhf
    
    On ppc64el and armhf the handling of "1 << mem_info.memslot_id_shift"
    will end up beign a zero which breaks the test.
    
    Marking the implicit value 1 as a 64 bit value (to match the uint64_t
    target) fixes the issue.
    
    Fixes #31
    
    Signed-off-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
    Acked-by: Frediano Ziglio <fziglio at redhat.com>

diff --git a/AUTHORS b/AUTHORS
index c7ccd433..49eeb71d 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -72,5 +72,6 @@ Patches also contributed by
     Olivier Fourdan <ofourdan at redhat.com>
     worldofpeace <worldofpeace at protonmail.ch>
     Thiago Mendes <tribeirom at gmail.com>
+    Christian Ehrhardt <christian.ehrhardt at canonical.com>
 
    ....send patches to get your name here...
diff --git a/server/tests/test-qxl-parsing.c b/server/tests/test-qxl-parsing.c
index 60ca8f88..234bdabc 100644
--- a/server/tests/test-qxl-parsing.c
+++ b/server/tests/test-qxl-parsing.c
@@ -96,7 +96,7 @@ static void test_memslot_invalid_slot_id(void)
     RedMemSlotInfo mem_info;
     init_meminfo(&mem_info);
 
-    memslot_get_virt(&mem_info, 1 << mem_info.memslot_id_shift, 16, 0);
+    memslot_get_virt(&mem_info, UINT64_C(1) << mem_info.memslot_id_shift, 16, 0);
 }
 
 static void test_memslot_invalid_addresses(void)