[Spice-commits] vdagent/vdagent.cpp

[GitLab Mirror]

 vdagent/vdagent.cpp |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 8bbb89e92b6b0ebfdeeb32ad11f96922bed29ad4
Author: Jonathon Jongsma <jjongsma at redhat.com>
Date:   Mon Mar 4 13:53:16 2019 -0600

    Don't exit when receiving unknown messages
    
    In 8251fa25, a check on the minimum size of a message was introduced.
    For unsupported messages, the vdagent simply exited. This makes it
    inconsistent with previous behavior and inconsistent with the behavior
    of the linux vdagent.  Instead, just print a warning indicating that an
    unsupported message was received and ignore it.
    
    Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
    Acked-by: Frediano Ziglio <fziglio at redhat.com>

diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index 89019bb..177e663 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -1288,8 +1288,7 @@ void VDAgent::dispatch_message(VDAgentMessage* msg, uint32_t port)
         break;
     }
     if (min_size < 0) {
-        vd_printf("Unsupported message type %u size %u", msg->type, msg->size);
-        _running = false;
+        vd_printf("Unsupported message type %u size %u, ignoring", msg->type, msg->size);
         return;
     }
     if (msg->size < (unsigned) min_size) {