[Spice-commits] common/messages.h

[GitLab Mirror]

 common/messages.h |    4 ----
 1 file changed, 4 deletions(-)

New commits:
commit 92d5dfd4bfa7ae4857e96504a6f14c336ed85338
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Mon Feb 18 15:23:07 2019 +0000

    messages: Remove fields not used by the protocol
    
    These fields are not used by the protocol (not in spice.proto, nor
    will be used in the generated (de)marshallers).
    Avoid spice-gtk and spice-server to use them by mistake.
    This can cause memory errors (data_size is not used or is not set
    correctly) and useless code (spice-gtk uses the pub_key* fields but
    these fields are not sent to the server as the protocol does not have
    them).
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Christophe Fergeau <cfergeau at redhat.com>

diff --git a/common/messages.h b/common/messages.h
index 43d3602..f740a8c 100644
--- a/common/messages.h
+++ b/common/messages.h
@@ -43,7 +43,6 @@
 SPICE_BEGIN_DECLS
 
 typedef struct SpiceMsgData {
-    uint32_t data_size;
     uint8_t data[0];
 } SpiceMsgData;
 
@@ -75,9 +74,6 @@ typedef struct SpiceMigrationDstInfo {
     uint16_t sport;
     uint32_t host_size;
     uint8_t *host_data;
-    uint16_t pub_key_type;
-    uint32_t pub_key_size;
-    uint8_t *pub_key_data;
     uint32_t cert_subject_size;
     uint8_t *cert_subject_data;
 } SpiceMigrationDstInfo;