[Spice-commits] 3 commits - server/red-channel.c server/red-worker.c server/red-worker.h

[GitLab Mirror]

 server/red-channel.c |    3 +++
 server/red-worker.c  |    8 ++++----
 server/red-worker.h  |    6 ------
 3 files changed, 7 insertions(+), 10 deletions(-)

New commits:
commit 20daba6bc3e07cae0e5a815a14f6fbefd64a94bd
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Fri Mar 29 08:25:59 2019 +0000

    red-worker: Remove unused definitions
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Christophe Fergeau <cfergeau at redhat.com>

diff --git a/server/red-worker.h b/server/red-worker.h
index 34c5b4af..a107c178 100644
--- a/server/red-worker.h
+++ b/server/red-worker.h
@@ -202,12 +202,6 @@ typedef struct RedWorkerMessageSetMouseMode {
     uint32_t mode;
 } RedWorkerMessageSetMouseMode;
 
-typedef struct RedWorkerMessageDisplayChannelCreate {
-} RedWorkerMessageDisplayChannelCreate;
-
-typedef struct RedWorkerMessageCursorChannelCreate {
-} RedWorkerMessageCursorChannelCreate;
-
 typedef struct RedWorkerMessageDestroySurfaceWait {
     uint32_t surface_id;
 } RedWorkerMessageDestroySurfaceWait;
commit e8fb0957efd81716a4158512309f637bae48f44f
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Wed Mar 20 21:50:52 2019 +0000

    red-worker: Use bool for driver_cap_monitors_config
    
    Easier to understand.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Christophe Fergeau <cfergeau at redhat.com>

diff --git a/server/red-worker.c b/server/red-worker.c
index bc63fc34..a30148a5 100644
--- a/server/red-worker.c
+++ b/server/red-worker.c
@@ -83,7 +83,7 @@ struct RedWorker {
     RedStatCounter full_loop_counter;
     RedStatCounter total_loop_counter;
 
-    int driver_cap_monitors_config;
+    bool driver_cap_monitors_config;
 
     RedRecord *record;
     GMainLoop *loop;
@@ -646,7 +646,7 @@ static void handle_dev_monitors_config_async(void *opaque, void *payload)
         /* TODO: raise guest bug (requires added QXL interface) */
         goto async_complete;
     }
-    worker->driver_cap_monitors_config = 1;
+    worker->driver_cap_monitors_config = true;
     count = dev_monitors_config->count;
     max_allowed = dev_monitors_config->max_allowed;
     if (count == 0) {
@@ -752,7 +752,7 @@ static void handle_dev_driver_unload(void *opaque, void *payload)
 {
     RedWorker *worker = opaque;
 
-    worker->driver_cap_monitors_config = 0;
+    worker->driver_cap_monitors_config = false;
 }
 
 static
@@ -1076,7 +1076,7 @@ RedWorker* red_worker_new(QXLInstance *qxl)
         dispatcher_register_universal_handler(dispatcher, worker_dispatcher_record);
     }
 
-    worker->driver_cap_monitors_config = 0;
+    worker->driver_cap_monitors_config = false;
     char worker_str[SPICE_STAT_NODE_NAME_MAX];
     snprintf(worker_str, sizeof(worker_str), "display[%d]", worker->qxl->id & 0xff);
     stat_init_node(&worker->stat, reds, NULL, worker_str, TRUE);
commit 70612bf29769f784f79c596224d66286ae79bee6
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Wed Mar 20 20:49:36 2019 +0000

    red-channel: Small comment on "core" field
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Christophe Fergeau <cfergeau at redhat.com>

diff --git a/server/red-channel.c b/server/red-channel.c
index 121c7e47..4015c12d 100644
--- a/server/red-channel.c
+++ b/server/red-channel.c
@@ -70,6 +70,9 @@ struct RedChannelPrivate
     uint32_t type;
     uint32_t id;
 
+    /* "core" interface to register events.
+     * Can be thread specific.
+     */
     SpiceCoreInterfaceInternal *core;
     gboolean handle_acks;