[Spice-commits] 3 commits - server/tests
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Nov 25 16:58:34 UTC 2019
server/tests/valgrind/glib.supp | 199 +++++++++++++++++++++++++++++++++++++--
server/tests/valgrind/spice.supp | 24 ++++
2 files changed, 216 insertions(+), 7 deletions(-)
New commits:
commit 9480df32fe3bb9ee84e8e22750d9f35ae9d4fe0f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon Nov 25 10:00:30 2019 +0000
ci: Disable leak error from Valgrind
For some reason under Fedora 31 the g_socket_client_connect call
from test-listen test caused Valgrind to detect a leak.
Note that the like at gtype.c (g_socket_client_connect) specifically
marks a memory block as malloc-like. Not sure if it's an issue
with Valgrind or with GLib, as a workaround disable the leak report.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Uri Lublin <uril at redhat.com>
diff --git a/server/tests/valgrind/spice.supp b/server/tests/valgrind/spice.supp
index d96b8423..09305149 100644
--- a/server/tests/valgrind/spice.supp
+++ b/server/tests/valgrind/spice.supp
@@ -69,3 +69,14 @@
fun:getaddrinfo
fun:do_lookup_by_name
}
+
+# g_type_create_instance Valgring malloc annotation, for
+# some reason this has issues with Fedora 31 from test-listen test
+{
+ g_type_create_instance-valgrind
+ Memcheck:Leak
+ fun:g_type_create_instance
+ ...
+ fun:g_socket_client_connect
+ fun:fake_client_connect_tls
+}
commit d0614859cf44693b42d4aa8bce7ed28c0a3a3fbb
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Nov 1 09:17:57 2019 +0000
ci: Fix for test-listen leak detection
This suppression was present in former glib.supp version however
the suppression in glib.supp was updated to only catch "reachable"
leaks.
However in test-listen test the allocation is done in a thread
causing the leak to become "definite".
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Uri Lublin <uril at redhat.com>
diff --git a/server/tests/valgrind/spice.supp b/server/tests/valgrind/spice.supp
index 284833a7..d96b8423 100644
--- a/server/tests/valgrind/spice.supp
+++ b/server/tests/valgrind/spice.supp
@@ -56,3 +56,16 @@
...
fun:g_socket_client_class_init
}
+
+# One-time getaddrinfo() configuration loading
+{
+ g-threaded-resolver-getaddrinfo-config2
+ Memcheck:Leak
+ match-leak-kinds:reachable,definite
+ fun:malloc
+ ...
+ fun:__resolv_conf_allocate
+ ...
+ fun:getaddrinfo
+ fun:do_lookup_by_name
+}
commit 80f16f2f265ab0e096221a91bf52982cbb0ace1a
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Oct 31 14:33:26 2019 +0000
ci: Update glib.supp file
Sync with Glib master file.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Uri Lublin <uril at redhat.com>
diff --git a/server/tests/valgrind/glib.supp b/server/tests/valgrind/glib.supp
index ddc2b172..3f7b53eb 100644
--- a/server/tests/valgrind/glib.supp
+++ b/server/tests/valgrind/glib.supp
@@ -22,6 +22,7 @@
{
gnutls-init-calloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:gtls_gnutls_init
@@ -30,6 +31,7 @@
{
gnutls-init-realloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:realloc
...
fun:gtls_gnutls_init
@@ -38,6 +40,7 @@
{
g-tls-backend-gnutls-init
Memcheck:Leak
+ match-leak-kinds:reachable
fun:g_once_impl
fun:g_tls_backend_gnutls_init
}
@@ -45,6 +48,7 @@
{
p11-tokens-init
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:create_tokens_inlock
@@ -55,6 +59,7 @@
{
g-local-vfs-getpwnam
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:getpwnam
@@ -64,6 +69,7 @@
{
glib-init-malloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_quark_init
@@ -74,6 +80,7 @@
{
glib-init-calloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_quark_init
@@ -84,6 +91,7 @@
{
gobject-init-malloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:gobject_init_ctor
@@ -92,6 +100,7 @@
{
gobject-init-realloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:realloc
...
fun:gobject_init_ctor
@@ -100,6 +109,7 @@
{
gobject-init-calloc
Memcheck:Leak
+ match-leak-kinds:possible,reachable
fun:calloc
...
fun:gobject_init_ctor
@@ -108,6 +118,7 @@
{
g-type-register-dynamic
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_type_register_dynamic
@@ -116,6 +127,7 @@
{
g-type-register-static
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_type_register_static
@@ -124,6 +136,7 @@
{
g-type-register-static-realloc
Memcheck:Leak
+ match-leak-kinds:possible,reachable
fun:realloc
...
fun:g_type_register_static
@@ -132,14 +145,34 @@
{
g-type-register-static-calloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_type_register_static
}
{
+ g-type-register-fundamental
+ Memcheck:Leak
+ match-leak-kinds:possible,reachable
+ fun:malloc
+ ...
+ fun:g_type_register_fundamental
+}
+
+{
+ g-type-register-fundamental-calloc
+ Memcheck:Leak
+ match-leak-kinds:possible,reachable
+ fun:calloc
+ ...
+ fun:g_type_register_fundamental
+}
+
+{
g-type-add-interface-dynamic
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_type_add_interface_dynamic
@@ -148,14 +181,34 @@
{
g-type-add-interface-static
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_type_add_interface_static
}
{
+ g-type-add-interface-static-realloc
+ Memcheck:Leak
+ match-leak-kinds:reachable
+ fun:realloc
+ ...
+ fun:g_type_add_interface_static
+}
+
+{
+ g-type-add-interface-static-calloc
+ Memcheck:Leak
+ match-leak-kinds:reachable
+ fun:calloc
+ ...
+ fun:g_type_add_interface_static
+}
+
+{
g-test-rand-init
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_rand_new_with_seed_array
@@ -167,6 +220,7 @@
{
g-test-rand-init2
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_rand_new_with_seed_array
@@ -179,6 +233,7 @@
{
g-quark-table-new
Memcheck:Leak
+ match-leak-kinds:reachable
fun:g_hash_table_new
...
fun:quark_new
@@ -187,6 +242,8 @@
{
g-quark-table-resize
Memcheck:Leak
+ match-leak-kinds:reachable
+ ...
fun:g_hash_table_resize
...
fun:quark_new
@@ -195,6 +252,7 @@
{
g-type-interface-init
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:type_iface_vtable_base_init_Wm
@@ -203,24 +261,121 @@
{
g-type-class-init-calloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
- fun:g_type_create_instance
- ...
fun:type_class_init_Wm
}
{
g-type-class-init
Memcheck:Leak
+ match-leak-kinds:reachable
fun:g_type_create_instance
...
fun:type_class_init_Wm
}
{
+ g-object-do-class-init-signals
+ Memcheck:Leak
+ match-leak-kinds:reachable
+ ...
+ fun:g_signal_new
+ ...
+ fun:type_class_init_Wm
+}
+
+{
+ g-type-prerequisites
+ Memcheck:Leak
+ match-leak-kinds:reachable
+ fun:realloc
+ ...
+ fun:type_iface_add_prerequisite_W
+}
+
+{
+ g-type-add-interface-check
+ Memcheck:Leak
+ match-leak-kinds:reachable
+ fun:malloc
+ ...
+ fun:g_type_add_interface_check
+ ...
+ fun:type_class_init_Wm
+}
+
+{
+ g-type-add-interface-check-realloc
+ Memcheck:Leak
+ match-leak-kinds:reachable
+ fun:realloc
+ ...
+ fun:g_type_add_interface_check
+ ...
+ fun:type_class_init_Wm
+}
+
+{
+ g-object-class-install-property
+ Memcheck:Leak
+ match-leak-kinds:reachable
+ fun:malloc
+ ...
+ fun:validate_and_install_class_property
+ ...
+ fun:type_class_init_Wm
+}
+
+{
+ g-param-spec-pool-new
+ Memcheck:Leak
+ match-leak-kinds:reachable
+ fun:malloc
+ ...
+ fun:g_param_spec_pool_new
+ ...
+ fun:type_class_init_Wm
+}
+
+# weak_locations_lock in gobject.c
+{
+ g-weak-ref-lock
+ Memcheck:Leak
+ match-leak-kinds:reachable
+ fun:malloc
+ ...
+ fun:g_rw_lock_get_impl
+ ...
+ fun:g_weak_ref_set
+}
+
+{
+ g-object-base-class-init-construct-pproperties
+ Memcheck:Leak
+ match-leak-kinds:reachable
+ fun:malloc
+ ...
+ fun:g_slist_copy
+ fun:g_object_base_class_init
+ fun:type_class_init_Wm
+}
+
+{
+ g-type-class-ref
+ Memcheck:Leak
+ fun:calloc
+ ...
+ fun:type_class_init_Wm
+ ...
+ fun:g_type_class_ref
+}
+
+{
g-io-module-default-singleton-malloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_type_create_instance
@@ -231,6 +386,7 @@
{
g-io-module-default-singleton-calloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_type_create_instance
@@ -243,6 +399,7 @@
{
g-io-module-default-singleton
Memcheck:Leak
+ match-leak-kinds:reachable
fun:g_type_create_instance
...
fun:_g_io_module_get_default
@@ -251,6 +408,7 @@
{
g-io-module-default-singleton-module
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_module_open
@@ -261,6 +419,7 @@
{
g-io-module-default-singleton-name
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_strdup
@@ -271,6 +430,7 @@
{
g-get-language-names-malloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_get_language_names
@@ -279,6 +439,7 @@
{
g-get-language-names-calloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_get_language_names
@@ -287,6 +448,7 @@
{
g-static-mutex
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_static_mutex_get_mutex_impl
@@ -295,6 +457,7 @@
{
g-system-thread-init
Memcheck:Leak
+ match-leak-kinds:possible,reachable
fun:calloc
...
fun:g_system_thread_new
@@ -303,6 +466,7 @@
{
g-io-module-default-proxy-resolver-gnome
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_proxy_resolver_gnome_init
@@ -314,6 +478,7 @@
{
g-threaded-resolver-getaddrinfo-config
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:__resolv_conf_allocate
@@ -325,11 +490,11 @@
# memcheck checks that the third argument to ioctl() is a valid pointer, but
# some ioctls use that argument as an integer
{
- ioctl-with-non-pointer-param
- Memcheck:Param
- ioctl(generic)
- fun:ioctl
- fun:btrfs_reflink_with_progress
+ ioctl-with-non-pointer-param
+ Memcheck:Param
+ ioctl(generic)
+ fun:ioctl
+ fun:btrfs_reflink_with_progress
}
{
@@ -593,9 +758,11 @@
}
# g_set_user_dirs() deliberately leaks the previous cached g_get_user_*() values.
+# These will not all be reachable on exit.
{
g_set_user_dirs_str
Memcheck:Leak
+ match-leak-kinds:definite,reachable
fun:malloc
...
fun:set_str_if_different
@@ -603,9 +770,11 @@
}
# g_set_user_dirs() deliberately leaks the previous cached g_get_user_*() values.
+# These will not all be reachable on exit.
{
g_set_user_dirs_strv
Memcheck:Leak
+ match-leak-kinds:definite,reachable
fun:malloc
...
fun:set_strv_if_different
@@ -616,6 +785,7 @@
{
g_get_system_data_dirs
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_build_system_data_dirs
@@ -626,6 +796,7 @@
{
g_get_user_data_dir
Memcheck:Leak
+ match-leak-kinds:reachable
fun:realloc
...
fun:g_build_user_data_dir
@@ -636,6 +807,7 @@
{
desktop_file_dirs_malloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:desktop_file_dirs_lock
@@ -645,6 +817,7 @@
{
desktop_file_dirs_realloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:realloc
...
fun:desktop_file_dirs_lock
@@ -654,6 +827,7 @@
{
desktop_file_dir_unindexed_setup_search
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:desktop_file_dir_unindexed_setup_search
@@ -664,6 +838,7 @@
{
g_io_extension_point_register
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_io_extension_point_register
@@ -673,6 +848,7 @@
{
g_strerror
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_locale_to_utf8
@@ -683,6 +859,7 @@
{
g_socket_connection_factory_register_type
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_socket_connection_factory_register_type
@@ -692,6 +869,7 @@
{
g_dbus_error_quark
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_dbus_error_register_error_domain
@@ -702,6 +880,7 @@
{
g_private_set_alloc0
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_private_set_alloc0
@@ -709,6 +888,7 @@
{
g_private_set_alloc0-calloc
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:g_private_set_alloc0
@@ -718,6 +898,7 @@
{
g_main_context_push_thread_default
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:g_queue_new
@@ -728,6 +909,7 @@
{
g_file_info_attribute_cache
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:ensure_attribute_hash
@@ -737,6 +919,7 @@
{
g_file_info_attribute_cache2
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:ensure_attribute_hash
@@ -746,6 +929,7 @@
{
g_file_info_attribute_cache3
Memcheck:Leak
+ match-leak-kinds:reachable
fun:malloc
...
fun:lookup_namespace
@@ -755,6 +939,7 @@
{
g_file_info_attribute_cache4
Memcheck:Leak
+ match-leak-kinds:reachable
fun:calloc
...
fun:lookup_namespace
More information about the Spice-commits
mailing list