[Spice-commits] tools/spicy.c
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Sep 23 15:14:25 UTC 2019
tools/spicy.c | 1 -
1 file changed, 1 deletion(-)
New commits:
commit b8f22559040c68312f06c47ac74bce68e62ca88d
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Sep 10 10:21:19 2019 +0100
spicy: Do not call gst_init directly
GStreamer is already initialized using gst_init_get_option_group and
gst_init_get_option_group.
From gst_init documentation:
WARNING: This function does not work in the same way as
corresponding functions in other glib-style libraries,
such as gtk_init(). In particular, unknown command line options
cause this function to abort program execution.
This luckily is not true (program won't abort if you pass --gst-foo
for instance) but better to stick to documentation.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Snir Sheriber <ssheribe at redhat.com>
diff --git a/tools/spicy.c b/tools/spicy.c
index 403a66d..8ca62f9 100644
--- a/tools/spicy.c
+++ b/tools/spicy.c
@@ -2017,7 +2017,6 @@ int main(int argc, char *argv[])
/* parse opts */
gtk_init(&argc, &argv);
- gst_init(&argc, &argv);
context = g_option_context_new("- spice client test application");
g_option_context_set_summary(context, "Gtk+ test client to connect to Spice servers.");
g_option_context_set_description(context, "Report bugs to " PACKAGE_BUGREPORT ".");
More information about the Spice-commits
mailing list