[Spice-commits] Changes to 'cpp3'
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Apr 28 05:25:13 UTC 2020
New branch 'cpp3' available with the following commits:
commit 4f20bb77830ce135fa31c238175337b00656d215
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Apr 2 12:41:39 2020 +0100
EEE other debt notes
not a real debt, more a consideration
commit 51a7a3f9b5345611e338da5c361846c0d0b09efa
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon Mar 16 08:57:44 2020 +0000
SAVE not sure what to do with this...
just comments for trying to understand how to simplify...
commit 98b332d9bc8c23708f426018b3084bdcb33dfd00
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 15 18:04:33 2020 +0000
EEE start writing comment for review
commit 203371b64b65e125155596a2bef92ea6f4a586d1
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 15 06:04:29 2020 +0000
EEE some notes from some commit
commit 299ebb2c512cdbd38a112b0d980b8d5c6af21720
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 14 05:27:57 2020 +0000
some notes on build checks
commit 77b67c2d43893c712429aceff7c9d6eb99115032
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 14 04:38:00 2020 +0000
EEE add debt
commit ef13c594892fd9ab56d58c1948de9357238c3711
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Mar 11 09:22:30 2020 +0000
EEE notes debts
commit ba489659b84c7e38b0efc7ab4a2f326e945842e9
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 15:48:03 2020 +0000
EEE add note
commit b83202f8676b71201fc782ba8d0fe4f6c0b7affe
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon Mar 9 03:10:33 2020 +0000
EEE notes
commit ce3db142767b3aaf7b40bf663f8009dccc43270b
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 11:35:28 2020 +0000
EEE update notes
commit e3bfafef2a9114f5f35ddfd6f36db044b3e995d3
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 5 23:44:12 2020 +0000
just some renames
commit 567773f4d5a51d9590ec2ca121f3c87fd7748bc8
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Feb 7 22:33:54 2020 +0000
save compile but memory is handled correctly
but idea is good!
not good cast every time in marshaller (see lambda code)
mix of types here...
commit 9087d57d33573f898befac669e023ebbf9f75850
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Feb 7 22:11:28 2020 +0000
save
commit 77526a29b9673eea4b83e934255822c1c37930e4
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Feb 6 22:49:44 2020 +0000
SAVE misc
protected
notes
simplification (used reference above)
commit 25eb49fbbbb3e6b06285a3e68838907970192304
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Feb 6 22:49:11 2020 +0000
SAVE to review
back from India...
how to get a C++ subclass of RedPipeItem
see header inclusion problem in header red-pipe-item -> red-channel-client
use an additional header to solve header dependency ??
implement template marshall to avoid to cast
reds.cpp uses old test interface (not saved anywhere)
commit 7ddd75eb7b91e6958cba89a3aca004e687ec52ba
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 10:18:28 2020 +0000
left pipe-item
commit 57ab0fab7aa0a1eb406e15b17e17ccb159cbd42d
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed May 29 10:20:22 2019 +0100
xxx SAVE not clear what to do about
commit 5acefeafe7f19d468100bc943d07889b418ea26d
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Mar 4 08:56:29 2020 +0000
SAVE
FIXME the upper container is not calling list destructor leading to
leaks
commit 54f65b5c30f0b8832f1dd61a83d83018b28bd699
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 04:03:53 2020 +0000
<<< SAVE, some experiment trying to use more high level containers - links
not much working I think
commit b4d6e0c64b2e8cba70f761eb9a0089385f0f4eee
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 14 17:36:05 2020 +0000
Implement limit
TODO not fixed
TODO free list at end (see comment)
TODO decrement at the end of the loop only ??
commit d10152f10a0a9a5dafc530ccca5c85d31c1daa4a
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 14 16:45:15 2020 +0000
style style... and better lock!
commit 2c2b896ff6b3b10f97976bc972dbd95a4b1f22fa
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 14 15:58:39 2020 +0000
SAVE reduce API, pass directly
TODO backport
commit 8c7928f60723fcf95a995739560b4b0cac977718
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 14 15:54:57 2020 +0000
dispatcher: More private !!!
TODO merge into other??
TODO try same experiment with other classes (like RedChannelClient ??)
commit eedbd5f226d6f6e3ff6f6beb910d7f56b4e388f3
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 14 11:47:22 2020 +0000
dispatcher: New implementation
--
TODO put a limit on the pending queue, if full wait!
TODO change name from Header!
TODO next is putting dynamic functions in it !
TODO some more comments?
TODO avoid the if (ack) lock/unlock
commit bff58b7801dd7b0bfe8f63225ce06fa843cccd3e
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 14 09:37:10 2020 +0000
test-dispatcher: Test dispatcher
Test that dispatcher work.
--
TODO backport??
TODO more comments ??
commit 99edeee3e480d0714750f1cbce763de74a4c380e
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 12 18:56:32 2020 +0000
SAVE notes for main-channel, still
commit b133726dfb8fbff668a9e420056f172454686b62
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Mar 11 09:03:35 2020 +0000
SAVE
commit 656526846d39d3ae04ef27212ecb6ee141b9bfd9
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Mar 11 09:04:38 2020 +0000
SAVE display-channel
commit 34c4025ff8f6e3a2d923542e7d56432002f760f1
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Mar 11 01:43:55 2020 +0000
EEE save to not delete
commit 7b29218a5d2f2f42cc58488f3aff222737095f4f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Mar 11 01:33:29 2020 +0000
cursor-channel: Automatic move functions to methods
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit e4d04395f7615e2901f154c2403a9560e2f62dc1
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Mar 11 00:56:40 2020 +0000
EEE adapt scripts for cursor-channel.h
commit b2aa33382f114463f9af77b5965568fdf9080951
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 08:23:14 2020 +0000
Avoids registering type just to get the nick of an enum value
We don't use anymore GObject parameters so avoid having to
register enum values to GType system to use them.
We just need to get the nick value of the enum values for
debug purposes.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 00dc9b266d3f9cf79a2a4d40ca9f206584f444a5
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 8 21:42:43 2020 +0000
SAVE Smartcard more encapsulation
commit 66ecb3df34d0991a950476ad294d3cfc4f43ed3a
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 8 21:06:35 2020 +0000
display-channel: Reuse DCC_TO_DC
Remove some XXX_CAST using DCC_TO_DC.
DCC_TO_DC can cast from DisplayChannelClient to DisplayChannel.
Not that is really safe.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit abaebaa8bc5b767b4b4ca21a113ed492e090ec4f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 8 13:46:33 2020 +0000
TRY to fix windows... weird error
not clear when this error appeared
commit 3bf71a6c93eca86ee3c086a07353079f811fe3a0
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 7 10:18:55 2020 +0000
SAVE some comments
commit a98fb72a431241bbf80e3c0a8ed17e65a083297b
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 3 17:07:53 2020 +0000
SAVE use automatic pointer for timer
commit f4f27af2ad6da598123719419dbdfbbe3f75402c
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri May 24 20:33:43 2019 +0100
notes
commit 21d4ee3a70aeea9cda1ba9fc89ad8fb01bd8c8a1
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri May 24 17:29:17 2019 +0100
EEE NOTE notes
commit 45610134a720a118a6d9fc59f74dd28dc99435d1
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Jun 1 00:26:02 2019 +0100
spice-message: Remove set_header_sub_list
TODO merge other
commit 7896d65b2163d98559cb2157433e7588e02cb4cc
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri May 24 06:29:35 2019 +0100
SAVE trying to reduce RCC interface and avoid some pitfall
users should call init instead of get_marshaller
so to make sure they init before getting it
still required by dcc
TODO remove more get_marshaller
TODO also not pass SpiceMessage and marshaller together...
commit e9a2d837e92e77f428addcb51a4dbbee1c37c86d
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 02:52:21 2019 +0100
>>> minor C++ styles
TODOs stop here (commit before has TODO if something need to be done)
commit f02584380e987411b6a06a75cc12e3cac0693c27
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 16:32:51 2020 +0000
sound: Make functions exported not visible
Allows the compiler to do some additional optimizations.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 6a3ec110eeda9f88a9daa0c63c1acba0c89bcd4a
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 8 10:52:53 2020 +0000
build: Remove GObject dependency
Not used anymore.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 5e623e8c74d2fed5131c1bb335db75a9f367c44d
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 15 07:02:42 2020 +0000
red-stream-device: Better encapsulation
Remove all members public, set correct access and create
missing methods.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 60cc2966b9fa3f3a47de7ac9ae5996ddad9bdb08
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 7 22:11:34 2020 +0000
char-device: Remove GObject from RedCharDevice
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
--
TODO see .get() calls in reds.cpp
commit 4b52dd1061f3f73b9d64b0f765fbcd187d8ffb96
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 1 19:38:38 2020 +0000
automake: Link with C++ linker
If automake sees no C++ files in the source it assumes have to
use C linker settings not linking C++ library.
This was not a problem as code did not use C++ libraries but next
patch will use RTTI so allow C++ library linking.
This is done adding an empty "dummy.cpp" file.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 8ae6e0da353a0f4386ac1545809c05cf1382d69e
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 8 12:51:07 2020 +0000
Wrap spice.h in order to do some adjustment
Instead of including spice.h directly include an header that wraps
it. This allows to remove the SPICE_SERVER_INTERNAL define.
Currently is used to rename SpiceCharDeviceInstance to RedCharDevice
and reduce its visibility to hidden. This remove some warnings
and some weird code in the source.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 19be2b2657ca7fd579e08ce7ff59c813cd7c3506
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 15:26:43 2020 +0000
EEE some more TODOs
commit e53604e3121542920298ccd3fe5a03e6860dd7a7
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 7 11:26:13 2020 +0000
utils: Add red::weak_ptr and red::shared_ptr_counted_weak
Implements weak pointers and helper to implement them.
They will be used for RedCharDevice.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 07ad2786cdca1a86f83d832f2a05f79a06ffec23
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon Mar 9 02:25:03 2020 +0000
dispatcher: Reuse base reference counting for Dispatcher hierararchy
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit ecb6bff94d123a0f51bf1862a0b5a032b1ef5659
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 7 12:22:22 2020 +0000
Use red::shared_ptr_counted for RedChannelClient
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 3adc33635336fd2bb6ea0f1310dc490b6fa86382
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 8 05:46:56 2020 +0000
Add and use red::make_shared
Allow to create an object already contained in a shared pointer
to avoid having not owned objects.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 5113fe8bba851aab39b9fce7ef2eaa8415a37475
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 20:23:42 2020 +0000
Use shared_ptr implementation to handle reference counting
This allows to make easier the management of owning.
Reference counting is automatically updated based on shared
pointers modification.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 22f59e7821edc58f0b6c62dabcc465efca6dba88
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 18:49:46 2020 +0000
utils: Very skinny share_ptr implementation for our references
It will be used to refactor reference counting code.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 55004b64288321fc6c69882c6854ea0ac914cf2f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 8 18:54:23 2020 +0000
input-channels: Improve encapsulation
Update member access to limit it.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 117f3c692e94755621c18e542844004978a1cc2f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Mar 7 10:01:42 2020 +0000
reds: Make mig_wait_disconnect_clients a std::forward_list
In the meanwhile remove a leak on the program.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit e0a8869fa0b80d3fd9349fe4fab35abf4e46e781
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 18:40:51 2020 +0000
reds: Move qxl_instances to red::safe_list
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit cea72c354e508bdc0d7a5a8bbb52400a5266122b
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 13:09:39 2020 +0000
EEE add some debts notes
commit 4aa86ac62ed535e99a6307f9da470077e75c839d
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 10:12:22 2020 +0000
char-device: Convert some static functions to methods
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 696f5ad57deafdbefa034a937e692885980263fd
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 10:30:27 2020 +0000
char-device: Automatically convert functions to methods
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 57b59901ec7bb86663171ad364dd111b41ab1dfb
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 06:21:48 2020 +0000
EEE save to not delete - char-device.h
commit 87b3587c4950456315ecec020f39ac082924bede
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 06:47:57 2020 +0000
char-device: Remove define trick, won't work on C++
C++ check parameter type, not founding the functions at
link time.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 039cef2ba924a8b476ce9947a35763110fc7d4de
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 5 18:45:17 2020 +0000
char-device: Prepare to move functions to methods
Move structure declaration at the end.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 9a34d796e0afc66ad81c64a9778a6f284cef2ad9
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Feb 6 21:38:51 2020 +0000
Do not use GError to just return an error string
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit a6343b5bcc7dbc47d1277898a13759023fd9f92f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 04:40:11 2020 +0000
reds: Move clients to safe_list
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 23fa0fcc15b75b5e42b6f817db89cc67af707122
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 13:12:16 2020 +0000
EEE Add some debts notes
commit 07bd237be1d2342bc95a89ceea9eb28704404126
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 10:13:02 2020 +0000
reds: Use red::safe_list instead of GList
Use an utility list.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 16e75b0774fe741efe8700b6c10c045d8c5740f2
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 04:13:00 2020 +0000
Allow to compile without C++ library
Provide a suitable allocator using GLib
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 7319963fa3f8c96c005b5eed58270dbf12904b24
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 17:00:15 2020 +0000
EEE some debts
commit fe20b1f8a030d09912abd3e12a987108a639d553
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 04:03:24 2020 +0000
safe-list: Add a class to implement a list with safe iterators
The reason to not using STL is that our code from how was designed requires
the iterator to be safe to the delete of the element pointed by the iterator.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit b180efd103b76cc4ef9047f6d4edbacf78fe6a51
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Jun 1 00:46:19 2019 +0100
red-channel: Small simplification
Use std::max to make code smaller
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit ffde17afb92714213b4c98f83b6a34477ca3cd05
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 17 19:11:18 2020 +0000
main-channel-client: Automatically convert
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit f7090a6c0240349d4fa7623ea20b3161d48073d8
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri Mar 6 06:13:31 2020 +0000
EEE save to not delete - main-channel-client.h
commit 767017e52ef26934411f2a2d996cb27d16072fa3
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 17 18:56:02 2020 +0000
main-channel: Automatic convert functions to methods
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit ac2a862ad8c2948898d2af0a275bd1aeb2dca2ea
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 5 18:51:32 2020 +0000
EEE Automatize main-channel.h process
commit 7cca027beac82d277af457039467002302f034f2
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 5 10:21:43 2020 +0000
red-client: Make RedClient pure C++
Remove GObject.
Add access protection.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit aff8215eb4bfe058de1ce5aba34093b5c9905ce5
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 5 10:17:38 2020 +0000
red-client: Automatically convert functions to methods
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 8a68a23d60adac200c063509b86cdbfabcffae48
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 5 08:51:10 2020 +0000
EEE save to not delete - red-client.h
commit 6fa389e03033c0f0cdfdabb206902f6918ad87f3
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 5 13:01:27 2020 +0000
reds: Remove a weak pointer usage
RedCharDevice can all be removed just calling unref, beside
the agent that needs special threatment.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 39dc9d43abf12de44835d92b7e8a3fb14a08eda6
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 13:19:04 2020 +0000
EEE some notes
commit 5bb26f8ac5e61a0b144e4d99a4aee5bec3691436
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 5 08:27:57 2020 +0000
Remove GObject from Dispatcher hierarchy
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 2a2b6483cc05ba97ca46b3cb985a2ebac5eadc7d
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 11:47:39 2019 +0100
dispatcher: Add a more safe dispatcher_send_message_custom version
Use a template to wrap the other dispatcher_send_message_custom
avoiding having to pass a void* opaque and extract payload size
from passed type.
Will be used more by next commit when Dispatchers are turned into
C++.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 155c131a46e736c163a2350ccd6caae6850c2c75
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Apr 1 20:50:44 2020 +0100
Define and use (un)ref
Avoids g_object_(un)ref.
This in preparation to remove GObject.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 67ea89a35116c9853fddbfcd9db6b49b6ae9cace
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Apr 1 20:43:04 2020 +0100
dispatcher: Use IS-A relationship for Dispatcher hierarchy
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit a38398dcf2422a7ac9625546574d0f66a810419a
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 5 05:35:43 2020 +0000
char-device: Define and use (un)ref
Prepare to remove GObject.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit f211d3a2a53a174d04862f5422b7ef070bb27bfe
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu Mar 5 05:25:54 2020 +0000
char-device: Do not use signals just to call our routine
The only notify was done from the same file.
All other read of the property were replaced.
Preparing to remove GObject.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 3317bc5ff431a7082e7641c25b34f65be32d9d4c
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed May 29 08:56:32 2019 +0100
sound: Make on_message_done a virtual function
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit d3f2891243955c46db861903f1fe2ef0c2eb5b68
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed Mar 4 07:57:35 2020 +0000
inputs-channel: Move some methods to protected
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 5b70b529efebf5adef89f0f5c3a77d0077776c56
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 3 17:13:20 2020 +0000
inputs-channels-client: Call pipe_add_init from InputsChannelClient::init
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit aa53cea30c1ffc01dcc05632928427ad2e21fa09
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 3 15:34:41 2020 +0000
main-channel: Remove some casts
Add MainChannelClient::get_channel to avoid to manually cast
to derived type.
Pass objects as MainChannelClient instead of RedChannelClient if
we need a MainChannelClient.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 8558fb40de9d1b0c4479810410be7a8aa64ac72c
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 3 10:01:37 2020 +0000
red-channel-client: Make start_connectivity_monitoring protected
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 60fcda90484a01d5ef0e6acc7b580ff5e2ec5d4a
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 09:07:20 2019 +0100
red-channel-client: Make handle_message protected
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 82f5630d22bc4aa1da514847e3a8f7c6dc3f03a8
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 02:32:50 2019 +0100
red-channel-client: Move some methods to a protected section
Reduce visibility and increase encapsulation.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit c1481b1b952bfab0f9445cf0ad16805d833ad33b
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 3 09:07:54 2020 +0000
Improve CommonGraphicsChannel encapsulation
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit de7e4aa2bd69091aa80061125fe53c607d889594
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 1 18:48:42 2020 +0000
stream-channel: More incapsulation for StreamChannel
Put all functions into methods.
Separate public/private part.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 86ce1d608de3bde5fe162fe7ed4baec7ac295bd3
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun Mar 1 06:57:11 2020 +0000
inputs-channel: More C++ on InputsChannel
Removed ugly converts putting in InputsChannelClient::get_channel().
Removed silly accessors.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit da52076c2aa30747379d29aeb7a2ac8af79f3617
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Feb 29 22:13:00 2020 +0000
inputs-channel: Make InputsChannel more encapsulated
Put functions into methods.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 07c1261e2d015594f30f87cfaea61afdc024cc7f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Feb 29 21:22:02 2020 +0000
Remove GObject from RedChannel
The patch seems pretty huge but mainly are mechanical steps:
- remove GObject declarations
- do not inherit from GObject
- add SPICE_CXX_GLIB_ALLOCATOR to avoid using C++ allocators
- CLASS_init and CLASS_constructor code goes into C++ constructor
- CLASS_dispose and CLASS_finalize code goes into C++ destructor
- g_object_new is replaced by new operator
- class members goes into virtual methods
- class parameters became argument to constructor
- use pushvis.h and popvis.h to limit visibility
- temporary use XXX_CAST for old GObject casts, they will
be replaced
- g_object_get is replaced by accessors
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 6c6c8e23eec05b65157dcedfe2cbb75ca21e1633
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat May 25 08:35:36 2019 +0100
cursor-channel-client: Use covariance to avoid some casts
CursorChannelClient knows that the channel is a CursorChannel.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 3d761da4699653ce7b1d7ba85937610077dd2f27
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat May 25 08:27:17 2019 +0100
cursor-channel-client: Move all public functions to methods
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit bf715035d7a5e098c91269827ebbf5db9f2fd470
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 3 14:47:53 2020 +0000
Reduce C++ symbols visibility
This allows the compiler to do some more optimisations on the
produced binary.
To allows possible future portability include header/footer in
some helper header files.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit a2a4900c0ef7ddb2b0da98f742ae75760667c0ff
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon Mar 9 18:31:20 2020 +0000
Use template to make adding timers/watches safer
Instead of forcibly cast functions cast only if data pointer and
function pointers match. This also allows to remove dangerous
casts all over the place.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit d28d2cd474e833d8c7a595466e0496e7b90ab290
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 05:07:19 2019 +0100
dcc-send: Avoid to call DISPLAY_CHANNEL_CLIENT to cast
It's useless now, it's always a DisplayChannelClient, pass the
right type.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 9a87ae3325e98fb0986bda83877f99f3b4a5017f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue May 28 19:53:46 2019 +0100
red-channel-client: Move handle_migrate_data_get_serial as a virtual function
Virtual functions cannot be null so use a return value instead
and return the serial using a reference.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 8ea790094bcf79badc4608549da19ddd65882034
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue May 28 19:46:39 2019 +0100
Make disconnect a virtual function
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit a0c5a305f8963faebb3de1bf2d40e6480fe7e3b2
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue May 28 19:31:44 2019 +0100
red-channel-client: Move handle_migrate_flush_mark as a virtual function
Note that the return value was removed as not used.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 48e54215cd7fd60dbc62c1ba5d253d5e487e84fb
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri May 24 20:23:16 2019 +0100
red-channel-client: Move migrate as virtual method
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit d92b84cfda33d16ad2db2f7c1f831f6ed4603a89
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri May 24 20:00:01 2019 +0100
red-channel-client: Move handle_migrate_data as virtual function
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
--
TODO better name than handle_migrate_data_early ??
commit e80b202c15660722437420dc4cadb23fc555303a
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 08:29:26 2019 +0100
inputs-channel-client: Improve encapsulation for InputsChannelClient
Move most inputs_channel_client_* functions inside the class.
This also helps preparing handle_migrate_data to be virtual.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit bacfca9bd3c72f27446d0926386f667e763ac20e
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 04:35:56 2019 +0100
red-channel-client: Make send_item a virtual function
The items are send from RedChannelClient so move the callback
to a virtual function in RedChannelClient instead of RedChannel.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 4d5553b985c6d4b01be707cacb6aa1f7b3ca9de6
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 03:54:28 2019 +0100
red-channel-client: Preparation, rename send_item to avoid clash
We will use this name for a virtual function from RedChannel.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
--
TODO Find a better name ?
commit 686f0a42f15bcc252108e4f233d39e0ecd4a58f2
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 03:43:52 2019 +0100
red-channel-client: Move handle_message as a virtual function
The messages coming are from the client so it's a better place
to be in RedChannelClient instead of RedChannel.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 4cdc4ad49187536de2463a57ff56fe71f102cde8
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 03:36:54 2019 +0100
Use utils.hpp for allocating/removing priv field
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit d682697fa8026cbf0857173f53ae32bbfeb09bed
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed May 22 05:04:17 2019 +0100
utils: Add red::unique_ptr
red::unique_link will be used to manage "priv" fields.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit bd1863167ab46aa18955235a095ff558cbdb4fb8
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon May 20 17:59:27 2019 +0100
EEE NOTE Add some notes
commit dc8a540e33091780020f4b836bf23efad9705bc6
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon May 20 16:49:17 2019 +0100
red-channel-client: Better private initialisation
Initialise RedChannelClientPrivate fields from the new
constructor instead from RedChannelClient.
Also change some fields to constants (actually many of them).
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 3dbeb94367fbd42d3d03666125f54a0866331f53
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon May 20 16:23:54 2019 +0100
red-channel-client: Remove "self"
It was left unchanged to reduce diff.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 162535f1dd99ccb121cd0852b3685938258b143d
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon May 20 15:39:15 2019 +0100
red-channel-client: Move all functions to methods
Improve incapsulation.
The only not mechanical change is the addition of timer_add to
make timer settings a bit more type safe.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit dcb66cf8a6edf95b9502fd89b552ee19886b04f1
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 11:48:13 2019 +0100
red-channel-capabilities: Removed unused stuff from RedChannelCapabilities
Not used anymore
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit bd86dcc8e833489511bcd1e7d45f7e0c61fd36db
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Fri May 24 12:31:04 2019 +0100
build: Remove GIO dependency
It was used for GInitable, now not used.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit cc962375c7924974fb84dc1b296585d667c2160f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun May 19 22:00:39 2019 +0100
red-channel-client: Remove GObject type
Make all RedChannelClient hierarchy a C++ class.
This allows to use virtual methods.
Added a normal contructor instead or properties and g_object_new.
As we remove GObject conversion macros I added a macro XXX_CAST
to create a function to replace the old macro.
They will be removed when more type safety is introduced.
There's a new SPICE_CXX_GLIB_ALLOCATOR macro in red-common.h.
This macro, added to a class define the class allocator allowing
to use, in this case, GLib for allocation. This to avoid C++ library
dependency and to initialize all structure to 0 (not all fields
are manually initialized, will be improved with more encapsulation).
Currently the methods are mainly public, access will be modified
when more encapsulation (all functions in method) are done.
Some classes are now defined in the header, C++ uses access to
limit accessibility but for efficiency and type safety/inline and
other features require types to be defined in the headers.
Some fields were moved from XxxPrivate structure to class, C++
has accessibility.
Many destructors are defined as protected to forbid the use of
stack, this as these objects uses internal reference counting
to have normal pointers. Maybe in the future pointers like
std::shared_ptr could be used instead.
Reference counting is now implemented very easily using atomic
operations.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit a274167a8d7bb75f8ca407f375db7afd4582869a
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat May 25 15:51:57 2019 +0100
Provides libstdc++ replacement to avoid C++ library dependency
Current code don't depend on C++ library but adding pure
virtual function require to have __cxa_pure_virtual function.
Provide it to avoid adding C++ library dependency.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit c2975a3579b51e2c199e07bd2bab12156937979f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 3 11:04:05 2020 +0000
Reimplement video-codes update with no GObject signals
This is in preparation to remove GObjects, as signals require them.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit e30142e2815de49f5bb0864f5a394ca6dcf40003
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon Mar 2 16:40:59 2020 +0000
Add RedChannel::(un)ref for reference counting and use them
This will reduce code to avoid gobject and make code less
type unsafe.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit b72908ff6254aa57e71e97c5ac89768ee3010fbb
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue Mar 10 02:52:40 2020 +0000
Introduce some utilities for C++
red::add_ref will be used to increment a reference counter
and return the object pointer.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 29a3d447dc80b533f0a890c71e8aeac6113cc932
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun May 19 14:46:09 2019 +0100
Update header style
Avoid typedef useless in C++.
Remove useless forward declarations.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 9b6bdda0c217317efd0a822fdbfe106ff2d2bb33
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun May 19 00:04:26 2019 +0100
Constify some methods
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 038bb6fe85e415904a73e81888d3f5e874bfce49
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue May 28 11:10:30 2019 +0100
[C++Ph1] Move all red_channel_* functions in header as methods
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit f047fa1d600d33e2d6300871294a77891c322527
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue May 28 10:38:30 2019 +0100
EEE Adapt script to adjust red-channel.h
TODO sed on files ??
Of all "this" pointers check only main_channel_is_connected should check for NULL
commit d7894c704e55e773f8a5573fd29c58a3260a2b8d
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue May 28 05:03:01 2019 +0100
[C++Ph1] Move all red_channel_client_* functions in header as methods
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit c72cd831cb9ed8af47aec82ac0eaff1277681d2b
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon May 27 07:26:14 2019 +0100
EEE save script
The dummy function definition in red-chhanel-client.h is there to make
coccinelle pick up the first function definition, I didn't find another way
Checked where was a "this" pointer check that came from places were
pointer was dereferenced already.
commit 5f2c9f7ef217a20cff8a292cbeb3473e407c7d6c
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Feb 29 17:42:56 2020 +0000
[C++Ph1] Remove COMMON_GRAPHICS_CHANNEL where possible
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 8beeb2c5be85e53abda2d523d24142e6d94d2d00
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon May 27 04:08:48 2019 +0100
[C++Ph1] Avoid useless downcast to RedChannelClient or RedChannel
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit c9251b79ff28cfd77ef49be46e27e34761e0332e
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun May 26 16:01:21 2019 +0100
[C++Ph1] Remove RED_CHANNEL where possible
Used Coccinelle:
@@
expression E;
@@
-RED_CHANNEL(E)
+E
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 4b66bbef2cdf636792e8c43409422729a2cc98e9
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun May 26 15:49:05 2019 +0100
[C++Ph1] Remove RED_CHANNEL_CLIENT where possible
Used Coccinelle:
@@
expression E;
@@
-RED_CHANNEL_CLIENT(E)
+E
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 0cdc26519c389aa80bf01189d24ffc1661d20885
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun May 26 15:10:28 2019 +0100
[C++Ph1] Use C++ IS-A relationship for RedChannelClient and RedChannel
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 12151407361b4dac47019f33005405c2629b245d
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed May 22 07:45:30 2019 +0100
[C++Ph1] Remove conversion warnings
Use casts to avoid all that warning.
They should go away once you use more type safe types.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit a17907311f94f740d28100d6d0bc4cc1d2e7359f
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed May 22 08:43:03 2019 +0100
EEE updated script to remove some warnings
commit a05af08e3e24148fcbdf2454ad4d75ff101ee881
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed May 22 08:24:46 2019 +0100
EEE new script to help removing warnings
This script is supposed to try to build and read the messages
from the compiler trying then to fix them (-fpermissive errors).
commit 8ae1f2a6b5bfa51b927b8c909fa630773fa30cee
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue May 21 06:42:24 2019 +0100
[C++Ph1] Remove warnings about combining GParamFlags types
C++ thread enum a bit more safely than C not allowing to combine
them. Avoid warning combining them and passing to functions
expecting enums.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 45554aca0a025973dfaddb48299bb695045f3616
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Tue May 21 06:42:50 2019 +0100
[C++Ph1] Remove -Wliteral-suffix warnings
Avoids warnings like
main-channel-client.cpp:538:27: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
"net test: latency %f ms, bitrate %"G_GUINT64_FORMAT" bps (%f Mbps)%s",
^
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 3b35e159a5b59ca57f90a5261293dd5e707a4d7a
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat May 25 07:34:32 2019 +0100
[C++Ph1] Avoid conversion warnings calling Windows sockets
Some Windows socket functions accepts char* instead of classic void*
causing some warning. Force the cast.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 855ad83b4cb75fbecd6f14d44ad2e820bc8dd0cf
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat May 18 20:24:21 2019 +0100
[C++Ph1] Change string check
In C++ GLib add function declaration (function parameters).
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 0f117b90198fecb4e8080ddacd0823b6507fd476
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Wed May 22 13:42:21 2019 +0100
[C++Ph1] Make sure empty structure are ABI compatible
Empty structure are not really portable however adding
an zero size array seems to be the way to have a zero
size structure portably.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 7444f89e473871a3c7568f6ab65ab2e9f64511ef
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon May 20 21:53:57 2019 +0100
[C++Ph1] Do not leave not initialized fields in the middle
Some old GNU compilers does not allow this (like CentOS 7 one)
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit cfd3127df53b45218a7ba61da63fd384f6e988b5
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 23 05:43:55 2019 +0100
[C++Ph1] Declare exported functions as C
Allows to be used by both C and C++ code.
So to leave part of the code in C and part move to C++.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 3384ed3e14cfe59452f8d45f734b91bb095cdcfa
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat May 18 20:19:50 2019 +0100
[C++Ph1] Declare public exported functions as C
Allows to link externally from a C program.
This will allow C++ code to respect C ABI.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit af09b2603addd5aae11960916b5b5e769ec1245b
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat May 18 20:23:44 2019 +0100
[C++Ph1] Avoid double definitions
In C++ that code would define variable twice giving error.
Define only one.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit f880e2767cf5105ff6b482c38dee51525af6a732
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat May 18 20:21:46 2019 +0100
[C++Ph1] Fix order of initializers
C++ complaints if they are not in the order of
declaration.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit ba31aa00821c4dc2fae2581828e596b61059d25b
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat May 18 20:20:20 2019 +0100
[C++Ph1] Avoid to use reserved C++ keywords
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 3a02ba696adf9bf98748f86ed8aaad59cb28acf7
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Mon Mar 9 10:04:24 2020 +0000
[C++Ph1] Adjust some warnings
Remove -Werror and add -fpermissive, this will allow to compile C code with
a GNU C++ compiler.
Ignore warnings as our code use some feature like empty arrays.
Remove warnings not available in C++.
Bump GLIB_VERSION_MAX_ALLOWED to reduce the warning, looks like the
GLib headers for C++ are not able to handle them correctly.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 011f5deb8008394ffd8b134b8786265a2393ae34
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sat Aug 29 05:35:46 2015 +0100
[C++Ph1] Allows C++ to be used in sources
Enable C++ compiler
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 5012c4273438df58b088d31490c70827a2eed72e
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Sun May 19 05:54:24 2019 +0100
EEE NOTE Start writing some notes on C++ move
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
commit 5a392f7b75857deed0ea194f50a3997bf2df774c
Author: Frediano Ziglio <fziglio at redhat.com>
Date: Thu May 30 06:33:16 2019 +0100
char-device: Remove pool handling
Memory pool handling does not give much but make code more complex.
Current implementation tends to only increasing buffer sizes
leading to potential cases where most of the allocated memory is
not used.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
--- valid
--- single
More information about the Spice-commits
mailing list