[Spice-commits] Changes to 'victortoso/toggle-audio-channels'
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Feb 26 17:27:28 UTC 2020
New branch 'victortoso/toggle-audio-channels' available with the following commits:
commit 8f0c4672d759783846bc7de90d3ce525c75865c4
Author: Victor Toso <me at victortoso.com>
Date: Wed Feb 26 18:20:42 2020 +0100
pulse: implement SpiceAudio::disable_channel()
In case audio is turned off by user, SpicePulse stops any ongoing
audio stream with PulseAudio and stops listening to all events on
related Playback and Record channels till
SpiceAudio::connect_channel() is called again.
Signed-off-by: Victor Toso <victortoso at redhat.com>
commit ae31728186591f6490056a95d2468ca7dc41a822
Author: Victor Toso <me at victortoso.com>
Date: Tue Feb 25 17:53:13 2020 +0100
gstaudio: implement SpiceAudio::disable_channel()
In case audio is turned off by user, SpiceGstaudio stops and clears
any running pipeline and stops listening to all events on Playback and
Record channels till SpiceAudio::connect_channel() is called again.
Signed-off-by: Victor Toso <victortoso at redhat.com>
commit 1306864caef96d94d1edfd80e2c4a549ffaef7df
Author: Victor Toso <me at victortoso.com>
Date: Wed Feb 19 21:43:26 2020 +0100
audio: disconnect audio channels when disabling SpiceSession::enable-audio
While connected, the user might want to disable audio and this commit
allows that to happen by disconnecting both Playback and Record
channels.
In order to keep the singleton SpiceAudio alive while both
SpiceChannel's are disconnected, we need to let back end know does
channels are not enabled anymore. For that reason, the
SpiceAudio::disable_channel() method is introduced, similar to
SpiceAudio::connect_channel() method.
In case audio is enabled once more, SpiceAudio::connect_channel() will
be called once more. Further commits will implement new class method
for both SpiceGstaudio and SpicePulse.
Signed-off-by: Victor Toso <victortoso at redhat.com>
commit abc79fb2c59d3ee2f17f4f6f3424d7a276dee26d
Author: Victor Toso <me at victortoso.com>
Date: Wed Feb 19 21:37:49 2020 +0100
audio: call connect_channel only for audio channels
Small optimization to avoid going all the way to the back end for
this. This also adds some missing braces (style).
Signed-off-by: Victor Toso <victortoso at redhat.com>
commit 71cef572bcf2ea56db7c969a3a2735d146f16c1e
Author: Victor Toso <me at victortoso.com>
Date: Wed Feb 26 18:00:20 2020 +0100
session: emit notify for SpiceSession::enable-audio
Otherwise, SpiceAudio would not get the notification when audio is
turned on or off by user.
Note that disabling audio is currently not implement and doing so
would only generate the following debug message:
> ../src/spice-audio.c:160 FIXME: disconnect audio channels
Signed-off-by: Victor Toso <victortoso at redhat.com>
commit 7650b23713392d4d252857725ed9e249fe7be647
Author: Victor Toso <me at victortoso.com>
Date: Wed Feb 19 21:06:00 2020 +0100
tools: spicy: toggle button for enabling audio
SpiceSession::enable-audio can be enabled and disabled at runtime,
adding this toggle to Spicy can help test it out.
Related: https://gitlab.freedesktop.org/spice/spice-gtk/-/merge_requests/7
Signed-off-by: Victor Toso <victortoso at redhat.com>
More information about the Spice-commits
mailing list