[Spice-commits] server/red-parse-qxl.cpp

[GitLab Mirror]

 server/red-parse-qxl.cpp |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 4466230a853cd9115ec89553ea1c6897f50dbdf8
Author: Frediano Ziglio <freddy77 at gmail.com>
Date:   Wed Jun 10 07:46:58 2020 +0100

    red-parse-qxl: Add a note on red_get_cursor
    
    Signed-off-by: Frediano Ziglio <freddy77 at gmail.com>

diff --git a/server/red-parse-qxl.cpp b/server/red-parse-qxl.cpp
index d71c261e..ac0d85bd 100644
--- a/server/red-parse-qxl.cpp
+++ b/server/red-parse-qxl.cpp
@@ -1566,6 +1566,10 @@ static bool red_get_cursor(RedMemSlotInfo *slots, int group_id,
     } else {
         red->data = (uint8_t*) g_memdup(data, size);
     }
+    // Arrived here we could note that we are not going to use anymore cursor data
+    // and we could be tempted to release resource back to QXL. Don't do that!
+    // If machine is migrated we will get cursor data back so we need to hold this
+    // data for migration
     return true;
 }