[Spice-commits] 2 commits - server/cursor-channel.c server/inputs-channel.c server/main-channel.c server/smartcard.c server/spicevmc.c server/stream-channel.c server/tests

[GitLab Mirror]

 server/cursor-channel.c           |    1 -
 server/inputs-channel.c           |    1 -
 server/main-channel.c             |    1 -
 server/smartcard.c                |    1 -
 server/spicevmc.c                 |    1 -
 server/stream-channel.c           |    1 -
 server/tests/test-stream-device.c |    2 --
 7 files changed, 8 deletions(-)

New commits:
commit b934b828dfdf349682c61ccf62b2a195595c13c3
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Sun Mar 1 12:20:37 2020 +0000

    Remove "migration-flags" setting to 0
    
    0 is the default value, no need to set explicitly.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Victor Toso <victortoso at redhat.com>

diff --git a/server/cursor-channel.c b/server/cursor-channel.c
index baa20539..31459749 100644
--- a/server/cursor-channel.c
+++ b/server/cursor-channel.c
@@ -234,7 +234,6 @@ CursorChannel* cursor_channel_new(RedsState *server, int id,
                         "core-interface", core,
                         "channel-type", SPICE_CHANNEL_CURSOR,
                         "id", id,
-                        "migration-flags", 0,
                         "handle-acks", TRUE,
                         "dispatcher", dispatcher,
                         NULL);
diff --git a/server/stream-channel.c b/server/stream-channel.c
index 1d71c126..d4560497 100644
--- a/server/stream-channel.c
+++ b/server/stream-channel.c
@@ -359,7 +359,6 @@ stream_channel_new(RedsState *server, uint32_t id)
                         "channel-type", SPICE_CHANNEL_DISPLAY,
                         // TODO this id should be after all qxl devices
                         "id", id,
-                        "migration-flags", 0,
                         "handle-acks", TRUE, // TODO sure ??
                         NULL);
 }
diff --git a/server/tests/test-stream-device.c b/server/tests/test-stream-device.c
index 7d901d66..8398839d 100644
--- a/server/tests/test-stream-device.c
+++ b/server/tests/test-stream-device.c
@@ -157,7 +157,6 @@ StreamChannel* stream_channel_new(RedsState *server, uint32_t id)
                         "core-interface", reds_get_core_interface(server),
                         "channel-type", SPICE_CHANNEL_DISPLAY,
                         "id", id,
-                        "migration-flags", 0,
                         NULL);
 }
 
commit 594c2feffad4e00bd986ed95d2162099bc512b74
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Sun Mar 1 12:15:14 2020 +0000

    Remove "handle-acks" setting to FALSE
    
    FALSE is the default value, no need to set explicitly.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Victor Toso <victortoso at redhat.com>

diff --git a/server/inputs-channel.c b/server/inputs-channel.c
index 280783c1..5413a4fb 100644
--- a/server/inputs-channel.c
+++ b/server/inputs-channel.c
@@ -570,7 +570,6 @@ InputsChannel* inputs_channel_new(RedsState *reds)
                          "core-interface", reds_get_core_interface(reds),
                          "channel-type", (int)SPICE_CHANNEL_INPUTS,
                          "id", 0,
-                         "handle-acks", FALSE,
                          "migration-flags",
                          (guint)(SPICE_MIGRATE_NEED_FLUSH | SPICE_MIGRATE_NEED_DATA_TRANSFER),
                          NULL);
diff --git a/server/main-channel.c b/server/main-channel.c
index 0f98eeb5..3ff2cc0e 100644
--- a/server/main-channel.c
+++ b/server/main-channel.c
@@ -252,7 +252,6 @@ MainChannel* main_channel_new(RedsState *reds)
                         "core-interface", reds_get_core_interface(reds),
                         "channel-type", (gint)SPICE_CHANNEL_MAIN,
                         "id", 0,
-                        "handle-acks", FALSE, /* handle_acks */
                         "migration-flags",
                         (SPICE_MIGRATE_NEED_FLUSH | SPICE_MIGRATE_NEED_DATA_TRANSFER),
                         NULL);
diff --git a/server/smartcard.c b/server/smartcard.c
index 9a536064..74c99062 100644
--- a/server/smartcard.c
+++ b/server/smartcard.c
@@ -73,7 +73,6 @@ red_smartcard_channel_new(RedsState *reds)
                         "core-interface", reds_get_core_interface(reds),
                         "channel-type", SPICE_CHANNEL_SMARTCARD,
                         "id", 0,
-                        "handle-acks", FALSE /* handle_acks */,
                         "migration-flags",
                         (SPICE_MIGRATE_NEED_FLUSH | SPICE_MIGRATE_NEED_DATA_TRANSFER),
                         NULL);
diff --git a/server/spicevmc.c b/server/spicevmc.c
index 4f0f8906..cae77bb8 100644
--- a/server/spicevmc.c
+++ b/server/spicevmc.c
@@ -253,7 +253,6 @@ static RedVmcChannel *red_vmc_channel_new(RedsState *reds, uint8_t channel_type)
                         "core-interface", reds_get_core_interface(reds),
                         "channel-type", channel_type,
                         "id", id,
-                        "handle-acks", FALSE,
                         "migration-flags",
                         (SPICE_MIGRATE_NEED_FLUSH | SPICE_MIGRATE_NEED_DATA_TRANSFER),
                         NULL);
diff --git a/server/tests/test-stream-device.c b/server/tests/test-stream-device.c
index abf66f04..7d901d66 100644
--- a/server/tests/test-stream-device.c
+++ b/server/tests/test-stream-device.c
@@ -158,7 +158,6 @@ StreamChannel* stream_channel_new(RedsState *server, uint32_t id)
                         "channel-type", SPICE_CHANNEL_DISPLAY,
                         "id", id,
                         "migration-flags", 0,
-                        "handle-acks", FALSE,
                         NULL);
 }