[Spice-commits] 2 commits - spice/controller_prot.h spice/foreign_menu_prot.h

[GitLab Mirror]

 spice/controller_prot.h   |    4 ++++
 spice/foreign_menu_prot.h |    4 ++++
 2 files changed, 8 insertions(+)

New commits:
commit 4816ae58d211df52c0f576dce0773369feaeb380
Author: Victor Toso <me at victortoso.com>
Date:   Thu Mar 5 18:57:59 2020 +0100

    foreign-menu: mark as deprecated
    
    This patch deprecates this interface and suggests to drop it in the
    next release.
    
    I don't know any user for this interface in the past 5 years. Spice
    clients like remote-viewer do use oVirt API for foreign menu.
    
    Signed-off-by: Victor Toso <victortoso at redhat.com>
    Acked-by: Frediano Ziglio <fziglio at redhat.com>

diff --git a/spice/foreign_menu_prot.h b/spice/foreign_menu_prot.h
index 44f88a2..65b0fd1 100644
--- a/spice/foreign_menu_prot.h
+++ b/spice/foreign_menu_prot.h
@@ -22,6 +22,10 @@
 #include <spice/types.h>
 #include <spice/start-packed.h>
 
+#ifndef SPICE_DISABLE_DEPRECATED
+#error "This SPICE interface is deprecated"
+#endif
+
 #define FOREIGN_MENU_MAGIC      SPICE_MAGIC_CONST("FRGM")
 #define FOREIGN_MENU_VERSION    1
 
commit 2981f214d3d00be68e1e361a940fe598c9195c13
Author: Victor Toso <me at victortoso.com>
Date:   Thu Mar 5 18:47:59 2020 +0100

    controller: mark as deprecated
    
    This patch deprecates this interface and suggests to drop it in the
    next release.
    
    The last known user of this interface was spice-gtk, which dropped its
    implementation in 2017-08-01 with
    
        spice-gtk at 8da3378f "build-sys: remove the spice-controller library"
    
    The commit log there has good enough justification to also drop this
    in the protocol.
    
    Signed-off-by: Victor Toso <victortoso at redhat.com>
    Acked-by: Frediano Ziglio <fziglio at redhat.com>

diff --git a/spice/controller_prot.h b/spice/controller_prot.h
index 0b0316f..9216e38 100644
--- a/spice/controller_prot.h
+++ b/spice/controller_prot.h
@@ -22,6 +22,10 @@
 #include <spice/types.h>
 #include <spice/start-packed.h>
 
+#ifndef SPICE_DISABLE_DEPRECATED
+#error "This SPICE interface is deprecated"
+#endif
+
 #define CONTROLLER_MAGIC      SPICE_MAGIC_CONST("CTRL")
 #define CONTROLLER_VERSION    1