[Spice-commits] 2 commits - server/reds.cpp server/spicevmc.cpp

[GitLab Mirror]

 server/reds.cpp     |    4 ++--
 server/spicevmc.cpp |   17 -----------------
 2 files changed, 2 insertions(+), 19 deletions(-)

New commits:
commit f1e89573b6e88b1065da1c865da9a458b92655a4
Author: Frediano Ziglio <freddy77 at gmail.com>
Date:   Fri Sep 11 09:47:46 2020 +0100

    reds: Specify virtual functions override RedCharDevice functions
    
    Remove some possible warning, like
    
    reds.cpp:216:18: warning: 'remove_client' overrides a member function but is not marked 'override' [clang-diagnostic-inconsistent-missing-override]
        virtual void remove_client(RedCharDeviceClientOpaque *opaque);
                     ^
    
    Signed-off-by: Frediano Ziglio <freddy77 at gmail.com>
    Acked-by: Uri Lublin <ulublin at redhat.com>

diff --git a/server/reds.cpp b/server/reds.cpp
index bfe525bf..803f546f 100644
--- a/server/reds.cpp
+++ b/server/reds.cpp
@@ -213,8 +213,8 @@ struct RedCharDeviceVDIPort: public RedCharDevice
     virtual RedPipeItemPtr read_one_msg_from_device() override;
     virtual void send_msg_to_client(RedPipeItem *msg, RedCharDeviceClientOpaque *opaque) override;
     virtual void send_tokens_to_client(RedCharDeviceClientOpaque *opaque, uint32_t tokens) override;
-    virtual void remove_client(RedCharDeviceClientOpaque *opaque);
-    virtual void on_free_self_token();
+    virtual void remove_client(RedCharDeviceClientOpaque *opaque) override;
+    virtual void on_free_self_token() override;
 
     RedCharDeviceVDIPortPrivate priv[1];
 };
commit efc02a8c0f65487d9a5ef6f07bc4eecf843b3e01
Author: Frediano Ziglio <freddy77 at gmail.com>
Date:   Mon Sep 14 18:42:44 2020 +0100

    spicevmc: Remove unused declarations
    
    Signed-off-by: Frediano Ziglio <freddy77 at gmail.com>
    Acked-by: Uri Lublin <ulublin at redhat.com>

diff --git a/server/spicevmc.cpp b/server/spicevmc.cpp
index fb7a2517..43604f08 100644
--- a/server/spicevmc.cpp
+++ b/server/spicevmc.cpp
@@ -98,23 +98,6 @@ struct RedVmcChannel: public RedChannel
     RedStatCounter out_uncompressed;
 };
 
-struct RedVmcChannelUsbredir final: public RedVmcChannel
-{
-    RedVmcChannelUsbredir();
-};
-
-
-struct RedVmcChannelWebdav final: public RedVmcChannel
-{
-    RedVmcChannelWebdav();
-};
-
-
-struct RedVmcChannelPort final: public RedVmcChannel
-{
-    RedVmcChannelPort();
-};
-
 
 class VmcChannelClient final: public RedChannelClient
 {