[Spice-devel] Modify Qxl surfaces allocation method

Alexander Larsson alexl at redhat.com
Tue Aug 17 07:40:55 PDT 2010


On Tue, 2010-08-17 at 14:26 +0300, Yonit Halperin wrote:
> This patch replaces the DirectDraw dependent surfaces allocation with mspace malloc.
> (bugzilla #29254).
> 
> Future work on this issue can include:
> 1) Tuning mspace for surfaces.
> 2) Separating the deallocations of DEVRAM resources from those of surfaces. Currently, there is only one release_ring.

I'll take a look at this.

> 3) compacting the VRAM.

Also, related is http://bugs.freedesktop.org/show_bug.cgi?id=29053

After talking to you on irc about this and looking at the code in detail
i think we need to move surfaces_info to DevRes so its shared between
all pdevs for the device. This is not a problem since surface ids are
not reused between pdevs (due to the global surfaces_used array).

> However, when real DirectDraw Qxl support does land, the previous
> method can be used again (Though separating the deallocations of
> DEVRAM resources from those of surfaces will be still a good idea).

If we can make our allocator work well, I don't see what using the
directdraw allocator really gives us though.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl at redhat.com            alexander.larsson at gmail.com 
He's an otherworldly devious senator gone bad. She's a brilliant bisexual 
stripper who inherited a spooky stately manor from her late maiden aunt. They 
fight crime! 



More information about the Spice-devel mailing list