[Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

[Gerd Hoffmann]

On 08/18/10 14:15, Alexander Larsson wrote:
> On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote:
>> From: Arnon Gilboa<agilboa at agilboa.usersys.redhat.com>
>>
>> -currently supports text only (UTF8)
>> -add VDAgent::dispatch_message()
>> -in VDAgent::read_completion() handle multi-chunk msgs
>> -fix chunk size bug in VDService::handle_pipe_data()
>> -add size to VDPipeMessage
>
> This reads out the clipboard and writes it to the client on every
> change. This is bad for two reasons:
>
> 1) It sends a lot of data to the client when it might not be needed
> 2) It always forces clipboard using apps to serialize any clip board
> data it has to text and pass it to windows every time someone copies and
> pastes. This is unnecessary in most cases since cut and paste is mostly
> intra-application. Additionally it may be costly since if you copy
> something more complex like pdf or html extracting the text from it may
> not be trivial.

Additionally I think this should be designed with multiple formats in 
mind.  We want only send the format the two parties agreed upon over the 
wire.  So we need some negotiation here about which formats are 
available in the clipboard and which one should be used.

Beside that I think it isn't a great idea to shuffle the (potentially) 
bulky clipboard data over the same channel the agent mouse uses.

cheers,
   Gerd