[Spice-devel] [PATCH] Limiting video streaming to the primary surface. freedesktop bug #28088.

[Yonit Halperin]

Fixed and pushed

----- Original Message -----
From: "Alexander Larsson" <alexl at redhat.com>
To: "Yonit Halperin" <yhalperi at redhat.com>
Cc: spice-devel at lists.freedesktop.org
Sent: Monday, August 23, 2010 1:15:57 PM (GMT+0200) Auto-Detected
Subject: Re: [Spice-devel] [PATCH] Limiting video streaming to the primary surface. freedesktop bug #28088.

On Sun, 2010-08-22 at 09:17 +0300, Yonit Halperin wrote:

> @@ -3262,10 +3271,12 @@ static inline int red_current_add(RedWorker *worker, Ring *ring, Drawable *drawa
>          red_streams_update_clip(worker, drawable);
>      } else {
>  #ifdef STREAM_TRACE
> -        red_detach_streams_behind(worker, &drawable->tree_item.base.rgn);
> +        if (drawable->surface_id == 0) {
> +            red_detach_streams_behind(worker, &drawable->tree_item.base.rgn);
>  #else
> -        red_stop_streams_behind(worker, &drawable->tree_item.base.rgn);
> +            red_stop_streams_behind(worker, &drawable->tree_item.base.rgn);
>  #endif
> +        }

The if is inside the ifdef, but the } is outside it, will not build
with !STREAM_TRACE.

Otherwise ack.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl at redhat.com            alexander.larsson at gmail.com 
He's a fast talking chivalrous werewolf living undercover at Ringling Bros. 
Circus. She's an orphaned paranoid college professor with her own daytime 
radio talk show. They fight crime!