[Spice-devel] [PATCH] spice-vmc: add a reset handler used to unregister spice interface (and trigger server mouse)

Gerd Hoffmann kraxel at redhat.com
Wed Aug 25 00:38:07 PDT 2010


   Hi,

>   static int vmc_initfn(VirtIOSerialDevice *dev)
>   {
>       VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev,&dev->qdev);
> @@ -185,6 +193,7 @@ static int vmc_initfn(VirtIOSerialDevice *dev)
>       svc->vmstate = qemu_add_vm_change_state_handler(
>           vmc_change_state_handler, svc);
>       virtio_serial_open(port);
> +    qemu_register_reset(vmc_reset, svc);

This is depricated.  There is a ->reset callback in DeviceInfo which 
should be used instead.

Otherwise the patch looks fine.

cheers,
   Gerd



More information about the Spice-devel mailing list