[Spice-devel] Fwd: [PATCH 1/3] server: bugfix - make vdi_port_write_retry reiterate if write_queue still not empty

Alon Levy alevy at redhat.com
Wed Aug 25 03:27:55 PDT 2010


----- Forwarded Message -----
From: "Alon Levy" <alevy at redhat.com>
To: alevy at redhat.com
Sent: Sunday, August 22, 2010 10:28:36 PM (GMT+0200) Auto-Detected
Subject: [PATCH 1/3] server: bugfix - make vdi_port_write_retry reiterate if write_queue still not empty

The vdi_port_write_timer_started flag was not being reset, which prevented
another vdi_port_write_timer_start from actually starting the timer. Fix
is to change order of lines. This happens in the callback of the timer, so
no chance of double timer set.
---
 server/reds.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/server/reds.c b/server/reds.c
index b7c6ce7..543c341 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -1144,8 +1144,8 @@ static void vdi_port_write_timer_start()
 
 static void vdi_port_write_retry()
 {
-    write_to_vdi_port();
     reds->vdi_port_write_timer_started = FALSE;
+    write_to_vdi_port();
 }
 
 static int write_to_vdi_port()
-- 
1.7.1



More information about the Spice-devel mailing list