[Spice-devel] [PATCH v4 2/3] client: add announce_capabilities

Hans de Goede hdegoede at redhat.com
Mon Aug 30 22:18:48 PDT 2010


Hi,

Correction make that 1 small nitpick and one bug found, see below.

On 08/30/2010 04:57 PM, Alon Levy wrote:
> diff --git a/client/red_client.cpp b/client/red_client.cpp
> index b6a412e..72b5909 100644
> --- a/client/red_client.cpp
> +++ b/client/red_client.cpp
> @@ -328,6 +328,8 @@ RedClient::RedClient(Application&  application)
>       , _agent_out_msg_pos (0)
>       , _agent_tokens (0)
>       , _agent_timer (new AgentTimer())
> +    , _agent_caps_size(0)
> +    , _agent_caps(NULL)
>       , _migrate (*this)
>       , _glz_window (0, _glz_debug)
>   {
> @@ -361,6 +363,7 @@ RedClient::~RedClient()
>       ASSERT(_channels.empty());
>       _application.deactivate_interval_timer(*_agent_timer);
>       delete _agent_msg;
> +    delete _agent_caps;

This should be:
     delete[] _agent_caps;

Notice the []

Regards,

Hans


More information about the Spice-devel mailing list