[Spice-devel] [PATCH] server: red_current_add_equal - don't push a drawable to the middle of the pipe if it depends on surfaces.

[Yonit Halperin]

On 08/31/2010 12:46 PM, Gerd Hoffmann wrote:
>>> While we are at it: How should surfaces_dest (and surfaces_rect) be
>>> filled for spice 0.4 commands? Right now they are just zero-initialized
>>> (see red_get_compat_drawable() in red_parse_qxl.c).
>>>
>> Best to fill surfaces_dest with -1. For consistency (though not
>> necessary right now), in QXL_COPY_BITS scenario, fill surfaces_dest[0]
>> with the drawable surface id, and surfaces_rect[0] with the rect of the
>> drawabele transformed to src_pos (i.e., starts at src_pos and its width
>> and hight are equal to the drawable destination).
>>
>>> Oh, and I've just seen self bitmaps are not handled yet.
>>>
>>> spice 0.4 has:
>>>
>>> uint16_t bitmap_offset;
>>> QXLRect bitmap_area;
>>>
>>> spice 0.6 has:
>>>
>>> uint8_t self_bitmap;
>>> QXLRect self_bitmap_area;
>>>
>>> I suspect the area can just be used as-is. What about bitmap_offset /
>>> self_bitmap?
>>>
>> if bitmap_offset != 0, it means self_bitmap = TRUE
>
> Ok. How does the attached patch look? Fine or missed I something?
>
Looks good.
> cheers,
> Gerd