[Spice-devel] [PATCH 08/12] server/inputs_channel: don't forget to free PipeItem

[Alon Levy]

On Mon, Dec 06, 2010 at 12:41:43PM +0100, Hans de Goede wrote:
> Hi,
> 
> On 12/06/2010 11:49 AM, Alon Levy wrote:
> >---
> >  server/inputs_channel.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >diff --git a/server/inputs_channel.c b/server/inputs_channel.c
> >index e4e75b7..f6279d5 100644
> >--- a/server/inputs_channel.c
> >+++ b/server/inputs_channel.c
> >@@ -234,6 +234,7 @@ static void inputs_channel_release_pipe_item(RedChannel *channel,
> >      if (item->data) {
> >          free(item->data);
> >      }
> >+    free(item);
> >  }
> >
> >  static void inputs_channel_send_item(RedChannel *channel, PipeItem *base)
> 
> Ah well that addresses one comment of an earlier review, please fold this back
> into the relevant patch.
> 
> Hint, try:
> 
> git rebase -i HEAD^^^^^^^^^^^^

or git rebase -i HEAD~12
> 
> (that are 12 ^'s for you) and then move this commit to directly after the
> other commit and replace the c in front of it with a f of "fix" then git
> will squash this commit into the one it is fixing and silently (iow without
> asking) reuse the commit message of the previous commit (so of the one this
> commit is fixing).
> 
> Ok the next patch requires me to think again, really time for lunch now :)
> 
> Regards,
> 
> Hans