[Spice-devel] [PATCH 00/24] collection of small fixes for mingw32 build on fedora

Alon Levy alevy at redhat.com
Tue Dec 7 13:27:59 PST 2010


This is a collection of mainly (everything except the first) patches
that allow compiling a valid [1] spicec.exe executable using mingw32
tools under fedora.

This is a rebase of the work Gerd started, with some more fixes that were
required to get it all to compile and link.

The patches consist of:
 adding Makefile.am in client/windows
 fixes to configure to not assume linux/x11
 various fixes thanks to -Werror (that make sense regardless of target)

[1] It doesn't actually connect to anything because it fails during link
establishment (throws various exceptions), still investigating - but since
the patches are mainly cleanup, I figured they can get posted already.

Alon Levy (16):
  server/tests: Makefile.am: use AM_LDFLAGS instead of LDFLAGS
  mingw32 build: fix various warnings
  mingw32 build: fix configure.ac typo
  mingw32 build: fix signed/unsigned warnings as errors
  mingw32 build: fixed using -1 as uninitialized value for unsigned
    variables
  mingw32 build: fix assignement as condition warning
  mingw32 build: remove unused, initialize uninitialized, reorder
    constructor initializers
  mingw32 build: check for CXImage, disable if not found (only on
    mingw32)
  mingw32 build: missing linked files for spicec.exe
  mingw32 build: windows/Makefile.am: double NULL definition
  mingw32 build: eol fixes
  mingw32 build: add missing switch flags (nop)
  mingw32 build: fix two functions
  mingw32 build: various fixes
  mingw32 build: python_modules/marshal: use unsigned for for_loop
    index variable
  mingw32 build: use PRIu64 instead of ll

Gerd Hoffmann (8):
  build: alsa is needed on linux only.
  build: only check for x11 extensions when     building for x11
    platform.
  build: use jpeg_boolean with more recent libjpeg versions.
  build: s/HUGE/INFINITY/
  mingw32 build: add client/windows/Makefile, tweak configure
  mingw32 build: -fvisibility test needs refinement, disable for now
  mingw32 build: disable ms compiler pragmas for gcc
  mingw32 build: fix build errors

 client/application.cpp             |   12 ++-
 client/cmd_line_parser.cpp         |    2 +-
 client/common.h                    |   12 ++
 client/controller.cpp              |    2 +
 client/display_channel.cpp         |    2 +-
 client/hot_keys.cpp                |    2 +-
 client/jpeg_decoder.cpp            |    6 +-
 client/mjpeg_decoder.cpp           |    8 +-
 client/mjpeg_decoder.h             |    6 +-
 client/process_loop.cpp            |    6 +-
 client/process_loop.h              |    4 +-
 client/red_client.cpp              |   10 +-
 client/red_client.h                |    2 +-
 client/red_peer.cpp                |    8 +-
 client/tunnel_channel.h            |    2 +-
 client/windows/Makefile.am         |  199 ++++++++++++++++++++++++++++++++++++
 client/windows/event_sources_p.cpp |    2 +-
 client/windows/main.cpp            |   10 +-
 client/windows/platform.cpp        |   60 +++++++----
 client/windows/platform_utils.h    |    3 +-
 client/windows/playback.cpp        |    3 +-
 client/windows/record.cpp          |    2 +-
 client/windows/red_pixmap_gdi.cpp  |    6 +-
 client/windows/red_pixmap_sw.cpp   |    4 +
 client/windows/red_window.cpp      |    7 +-
 client/windows/red_window_p.h      |    2 +-
 client/zlib_decoder.h              |    4 +-
 common/canvas_base.c               |   10 +-
 common/gdi_canvas.c                |    8 +-
 common/lz.c                        |    2 +-
 common/sw_canvas.c                 |    4 +-
 configure.ac                       |   85 +++++++++++-----
 python_modules/marshal.py          |    2 +-
 server/tests/Makefile.am           |    2 +-
 34 files changed, 391 insertions(+), 108 deletions(-)

-- 
1.7.3.2



More information about the Spice-devel mailing list