[Spice-devel] [PATCH 07/24] mingw32 build: -fvisibility test needs refinement, disable for now

[Alon Levy]

On Wed, Dec 08, 2010 at 09:31:59AM +0100, Hans de Goede wrote:
> Hmm,
> 
> Not sure if I like this one, as it will polute the server
> .so will all kinds of symbols. Maybe we should just
> change the test to be:
> 
> if test "x$have_gcc4" = "xyes" -a "$os_linux" = yes; then
> 
> ?

Pushed this one by accident. I like what you suggest, and maybe
this was fixed in the meanwhile for mingw so I can drop it entirely,
I'll test.

> 
> Regards,
> 
> Hans
> 
> 
> On 12/07/2010 10:28 PM, Alon Levy wrote:
> >From: Gerd Hoffmann<kraxel at redhat.com>
> >
> >Signed-off-by: Gerd Hoffmann<kraxel at redhat.com>
> >---
> >  configure.ac |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/configure.ac b/configure.ac
> >index 5fdc544..7287946 100644
> >--- a/configure.ac
> >+++ b/configure.ac
> >@@ -408,9 +408,9 @@ error Need GCC 4.0 for visibility
> >  int main () { return 0; }
> >  ], have_gcc4=yes)
> >
> >-if test "x$have_gcc4" = "xyes"; then
> >-   VISIBILITY_HIDDEN_CFLAGS="-fvisibility=hidden"
> >-fi
> >+#if test "x$have_gcc4" = "xyes"; then
> >+#   VISIBILITY_HIDDEN_CFLAGS="-fvisibility=hidden"
> >+#fi
> >  AC_MSG_RESULT($have_gcc4)
> >  AC_SUBST(VISIBILITY_HIDDEN_CFLAGS)
> >